Received: by 2002:a05:7412:9c07:b0:fa:6e18:a558 with SMTP id lr7csp162044rdb; Sat, 27 Jan 2024 01:01:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGzxvKoXey/Z24sQihgsJY9GaVqph74yhPsumMkb6dGORYPJUfr+Bpd2qdnBPf5L9N+4+I X-Received: by 2002:a17:902:c94e:b0:1d7:78ed:4b7e with SMTP id i14-20020a170902c94e00b001d778ed4b7emr1642214pla.35.1706346106716; Sat, 27 Jan 2024 01:01:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706346106; cv=pass; d=google.com; s=arc-20160816; b=CmUTM0dcla6uVbCiykLXExQQGHQhjZj9Ou2s7d6SPPgu+db3Nfl3gWkdR6TYHgKLvZ RXbTs1O7JsR8o5Qc/rx15mC3rIuGIlA7/9vqkMaRZgrIEGZczyd6Q7AadgBcXOj5y8uZ lYz1qZ38lk9/8eDMR1ZwuagJogx1ykPC5QByKFcbqdk085MqgPKSBgp1e22lP0miVbBj JcIz1On2VMdanCiOKXi3dqmRwKmBbu4taN+a3l8LAp/BXCor6CnupGoGLSSAMKv94uwC Yhph6m8wWxALdDHk6+NGhGy5l9W7H1go7KWdQd1JoPsjU8RYh2up4fxpaITqc487qNgm YSXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=MTcmCQpu8tFv5u/b7S3uCF52aneP6XDxxhzrgLd62ZQ=; fh=KK0LdLJ2z2QfPCpSaQ7qdCR27apq2/3U4AiT+qxR8gw=; b=NeR8qpsyKRaD3cPAk4nTJEVjcDB5pn5+f6l5rk8W8KZ245L5HzYi/vJCMl3m8q84IY 9iMDZxmAhAXCInQuRdwGKkpFbJX55zLm7dGQUgkHyvQ3iBo02YQ1j4GHAeRz5kjLu/mG rmTYV5IE0QoFBiXyGFm4hqL+2BBliTxSq703ldU/2wPM8hehR+AArwJdySQgYlCmY0mM gzZAK2mzKcVPXu4L/iUOQ6RdQVRU7mTz+qwLxB+n3GNqinejXWyRpF627gRWwLaXHIWa twXktpRu1/ZxTYiqzMUComDzr62Ql8XLA6peUN39/PbvwWCm0lSajpnDkO2dggsJdOR+ L/7A== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=enpas.org); spf=pass (google.com: domain of linux-kernel+bounces-41123-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41123-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id q16-20020a170902789000b001cff34e87a0si2456880pll.600.2024.01.27.01.01.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Jan 2024 01:01:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-41123-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=enpas.org); spf=pass (google.com: domain of linux-kernel+bounces-41123-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41123-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D218CB22573 for ; Sat, 27 Jan 2024 09:00:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 541BB1E88C; Sat, 27 Jan 2024 09:00:35 +0000 (UTC) Received: from mail.enpas.org (zhong.enpas.org [46.38.239.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 515F07F; Sat, 27 Jan 2024 09:00:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.38.239.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706346034; cv=none; b=dofGgdGrnEJ8+XiwE3YVd5AgC0QcU7pJ21olsrJSq/spaztgwwqCQJUhuDrMUVWndNCnKib1YaQzYW0li99tgv8sbciRYC5aUQNhZzY2y7AzsI1lBV17wf36PgAO+0pSe1dwB4hZ/gHNSLp0+Oh8TaSBfhYQrVxCtnbgpn4xQW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706346034; c=relaxed/simple; bh=MTcmCQpu8tFv5u/b7S3uCF52aneP6XDxxhzrgLd62ZQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=js+mbm5MZTQH5MBBJB3ITuCwXi6vGf3uWzU2wOkPVYHves6Uh8+J6F0Th9MayKXOmclxyCEPBn9JJP0A1ubjG08bvd5ModQmNeovUshVbY+2Hi9krrmv1HW1sQXqOmfG1U7aItVgJD1d4bFZwUr454ScfM5eVJgcAsnkpaxnU+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=enpas.org; spf=pass smtp.mailfrom=enpas.org; arc=none smtp.client-ip=46.38.239.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=enpas.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=enpas.org Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail.enpas.org (Postfix) with ESMTPSA id 80F7E1015FF; Sat, 27 Jan 2024 09:00:28 +0000 (UTC) Message-ID: <9a51083e-f22d-4bbf-8a16-441becfdf00a@enpas.org> Date: Sat, 27 Jan 2024 18:00:25 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 5/7] HID: playstation: DS4: Parse minimal report 0x01 Content-Language: en-US To: Roderick Colenbrander Cc: Roderick Colenbrander , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240115144538.12018-1-max@enpas.org> <20240115144538.12018-6-max@enpas.org> From: Max Staudt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/25/24 09:54, Roderick Colenbrander wrote: > I would say let's turn this into a 'return 0'. The goto is not useful > since there is no need for any common cleanup or some other common > logic later. Oops, that one slipped through the cracks. Thank you, will do! Max