Received-SPF: pass (google.com: domain of linux-kernel+bounces-41135-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <536971eb-51f0-40e5-d025-7c4c1d683d49@axentia.se>
Date: Sat, 27 Jan 2024 10:40:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] dt-bindings: iio: afe: voltage-divider: Add
 io-channel-cells
To: Conor Dooley <conor@kernel.org>,
 Naresh Solanki <naresh.solanki@9elements.com>
Cc: Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen
 <lars@metafoo.de>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, mazziesaccount@gmail.com,
 linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240126115509.1459425-1-naresh.solanki@9elements.com>
 <20240126-cinnamon-flatware-e042b5773f17@spud>
 <CABqG17hzZf2mme0v7hALhpd6-N3ZHqxdH-AhFg5eF9sbLSC2gw@mail.gmail.com>
 <20240126-scale-serrated-33686467d91b@spud>
 <CABqG17jp6YRGyTmNitz-xDdyhWOPgfT_XpXxw-OJLnXQ777vAA@mail.gmail.com>
 <20240126-blaspheme-calculate-a4134dc1ed68@spud>
From: Peter Rosin <peda@axentia.se>
Content-Language: en-US
In-Reply-To: <20240126-blaspheme-calculate-a4134dc1ed68@spud>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QlFQNmd4TG5TR29MREVBd25mR0dGYnRPNlZVWWNEMDNFVmhMZ1J5dUxCR1h3?=
 =?utf-8?B?NHBHRXJCYlBMaW13V0tRaFo1YTBXZ3hXNWRMSUtKRCsrbUlhbldDQTQ3dXNS?=
 =?utf-8?B?U3AzcFBPS2RxaGp2dGhQSTl2V3crbnhxVFJoSVpyRXVBQTlKYmY2YlhtR1Z2?=
 =?utf-8?B?VUtJUFBvcEt5Ri9vUDN6TkFCVklOZmtCYWswUDJLenlaQTN5cHRxSUxrdWpp?=
 =?utf-8?B?ZjlBS0EwWDUyeFpZajFYeDRleE1TMVVwaWlOekl6aVZQYU1lQ2FQdGRwTWMv?=
 =?utf-8?B?SGtDN2pZcXJxQ29qbjhjZTNBcXFiUEVlRHZjOVRzS2RxMG90VVl0TEhNWk9o?=
 =?utf-8?B?UDRQSUwwNHB0SUZyY09sTHliRGZuUU5DKythMWk5aVh1WlNTK3ZrNjAzV2I4?=
 =?utf-8?B?YkhLL2hJUnNPSmwxM1JudEppRHVub05lTGtHY09TVEV4eGtIZjRYTWY2cFhT?=
 =?utf-8?B?WnNVRWxhNk1lTmJ4SE5GbXJDa0ZqRm9GNE9PdUliWGplZmxIeEFibVlZTUNB?=
 =?utf-8?B?R0VuYkluQ05HYnFvOEl0VkpRaGFLVEtCQW5rS2tYa0FqREJHZjZUY2ZOdWZ1?=
 =?utf-8?B?SlRvQ2pVVGFYYjA1VTV0UE5ZYkxHb3JBcUVQTW5CUWR4L2lpbTJUcDFQcFMx?=
 =?utf-8?B?WDY0WXFQNDJ6YVRPMlRwV2oxU3RJOUIxbjZFNDRXSjB3VFcwUWFlZ0xwZEdF?=
 =?utf-8?B?b01NVFQ4ZHU3amIydFQyR25Mb2hnMEtBRGg3ekdOdHRCZW0zMUtabWtQK0pw?=
 =?utf-8?B?L0kveGQ5YXAxeWtvK2dZajM4aThSVmNCVTVxYWVCckk3VFlLZVV3RnR5RUs4?=
 =?utf-8?B?ZWUxS1dVT3IwWnZNSnBweThKd3BoZWRYOFk1OWFId2tJQ3BVVWZNNkw4WHBp?=
 =?utf-8?B?djFITVlqRDl4ZUM3QVlibDhOb3BzRi9CY05FcVRpQURJRzhSMW96UXpNdG1N?=
 =?utf-8?B?MXhoTWdUK1Zoc2VxUTFYNkcyTzdLZTB1anBhWE9leDA0YVF1clhjeDRIcElk?=
 =?utf-8?B?YVVUQ09hRWV4QkY5ek9raFk2a200MHBTSFF5Y05wSTVRVm4xcVhlZkN0NDR3?=
 =?utf-8?B?bldnVFpSQjBXOTljcHZIVGxkWHRkRkltRnRtTVdaZnphYmFSNDN1ZUtOMDBH?=
 =?utf-8?B?aGxHempFd0pUNHBtZmMrM0RKVm8zMjlvS0xCbDVwSW44MThxUzZhaGpRRUhq?=
 =?utf-8?B?L1FzVm9hQ3p3bmtMWXVyWHM3Q0tDUEdUMkVBa3FJUkpWOU1lQnpESGMzTEVP?=
 =?utf-8?B?ZnFjeHBxaWk3U0ZjdmhRUzFNa213RFY0MXdXR2xpb3QxRXhmZUFUNTNtM3M4?=
 =?utf-8?B?N2QvTS9rSDF6Ry9pbHFyQmNYZ2dQemJtbVVXemxuR01JWWFBN3B0aU9nVG5T?=
 =?utf-8?B?U1FXV1ZQZThxM2FFN2VrNmtLRG1FclMzUzkwN1lYY0RDcDFnR2hvNUcxelpM?=
 =?utf-8?B?S1NiNlBqRFlGNlNNdFQzRXNBVkRvbzZxNWM0SjlEV2NPN2hmL1JUYmpYWXZy?=
 =?utf-8?B?VHVOeUdSeU5QaStyd0xhTWhkRU8xRGNkc1liVHBMVEJkR2xPaXZIcVNvSUha?=
 =?utf-8?B?bU1kK2tzUXpZNnd4TmFISzJvbWg2NUNWWk9IajRIcnRkUHFMR01lcU5rTkRX?=
 =?utf-8?B?aTNqejN1V2ROaFVtK1d6L1BLdWVTNk5lMjZnSnJaL2tyVWJreGRPZFFqdVRy?=
 =?utf-8?B?bmZkQUtkTmVUZHZGd2h0ZVNpd0FzNDhTLzk3WFVqUExOcEhFdnpvQzJxTmRC?=
 =?utf-8?B?UUVJRUhFc3Z1WXl5V0xZMEcySkNDb3JTVUNIdklTdlZMRklxV3Ircm04N25s?=
 =?utf-8?B?VkY0QmdDeGl5RlNLTEpUOXBrc2V5OTNRTW80a3dpL2l5UVpsSWsxWHVtbDE0?=
 =?utf-8?B?L2ZDVUVTZVFUM3NXZ2tTVCtDUzZ6YUZqeC94Z3BwN2Q3a2RFZVQrcHdkMExY?=
 =?utf-8?B?dHRDMSt4RytNcUwzazFRSWtQTEl3eU5LYWc3MlpUd3Z0ZHhueERNZTN3QzJZ?=
 =?utf-8?B?OFVia2JvUDYwdTh3aGd5dks0Nkxiclo1b1pIM0dpUUUzRDZkQUNVWUZOSklE?=
 =?utf-8?B?S1pLU1FhalZBWnhKdjY3VHFZNE9HODhkc1hJaVorZFZkS0xkZVRzY0lnVXlJ?=
 =?utf-8?Q?mz/SCAQjMw0YG+l9uwrw+MfQU?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: efda6bb6-b68d-41b6-ef6e-08dc1f1c01c5
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB8500.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2024 09:40:33.0247
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Lz2DjOBCbyQ5BrBraVJCpj4TWSUbO/28I3Hu87CYkJ7TBDTB3KzcZ3QRb19U1V6b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR02MB10685


2024-01-26 at 23:14, Conor Dooley wrote:
> On Fri, Jan 26, 2024 at 11:10:36PM +0530, Naresh Solanki wrote:

> I did look at what you have there and I think your dts is wrong.
> 
> The iio-hwmon binding says:
> | description: >
> |   Bindings for hardware monitoring devices connected to ADC controllers
> |   supporting the Industrial I/O bindings.
> | 
> |   io-channels:
> |     minItems: 1
> |     maxItems: 51 # Should be enough
> |     description: >
> |       List of phandles to ADC channels to read the monitoring values
> 
> And then you have:
> |	iio-hwmon {
> |		compatible = "iio-hwmon";
> |		// Voltage sensors top to down
> |		io-channels = <&p12v_vd 0>, <&p5v_aux_vd 0>, <&p5v_bmc_aux_vd 0>, <&p3v3_aux_vd 0>,
> |			<&p3v3_bmc_aux_vd 0>, <&p1v8_bmc_aux_vd 0>, <&adc1 4>, <&adc0 2>, <&adc1 0>,
> |			<&p2V5_aux_vd 0>, <&p3v3_rtc_vd 0>;
> |	};
> |
> |	p12v_vd: voltage_divider1 {
> |		compatible = "voltage-divider";
> |		io-channels = <&adc1 3>;
> |		#io-channel-cells = <1>;
> |
> |		/* Scale the system voltage by 1127/127 to fit the ADC range.
> |		 * Use small nominator to prevent integer overflow.
> |		 */
> |		output-ohms = <15>;
> |		full-ohms = <133>;
> |	};
> 
> A voltage divider is _not_ an ADC channel, so I don't know why you are
> treating it as one in the iio-hwmon entry. Can you explain this please?

This is the exact intent of the voltage divider (and the other bindings
handled by the iio-rescaler). The raw ADC reports the voltage at its input,
which is fine, but if there is an analog frontend in front of the ADC
such as a voltage divider the voltage at the ADC is not the interesting
property. You are likely to want the "real" voltage before the voltage
divider to better understand the value.

In this case it's much more interesting to see values such as 12.050V
which is presumably close to the nominal voltage (12V? guessing from
the node name) rather than some unscaled raw ADC voltage (in this
example it would be ~1.359V, which tells you rather little w/o rescaling
it first).

It's all in the description of the binding...

Cheers,
Peter