Received-SPF: pass (google.com: domain of linux-kernel+bounces-41217-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sat, 27 Jan 2024 14:37:39 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: Nuno =?UTF-8?B?U8Oh?= <noname.nuno@gmail.com>, Javier Carrasco
 <javier.carrasco.cruz@gmail.com>, Li peiyu <579lpy@gmail.com>, Lars-Peter
 Clausen <lars@metafoo.de>, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: humidity: hdc3020: fix temperature offset
Message-ID: <20240127143739.1848d64f@jic23-huawei>
In-Reply-To: <20240125110853.GA3857099@debian>
References: <20240125102641.3850938-1-dima.fedrau@gmail.com>
	<0a98e54735cc2a97f393eef6b1cdaf27c946d10e.camel@gmail.com>
	<20240125110853.GA3857099@debian>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, 25 Jan 2024 12:08:53 +0100
Dimitri Fedrau <dima.fedrau@gmail.com> wrote:

> Am Thu, Jan 25, 2024 at 11:49:25AM +0100 schrieb Nuno S=C3=A1:
> > Hi Dimitri,
> > =20
> Hi Nuno,
>=20
> > On Thu, 2024-01-25 at 11:26 +0100, Dimitri Fedrau wrote: =20
> > > The temperature offset should be negative according to the datasheet.
> > > Adding a minus to the existing offset results in correct temperature
> > > calculations.
> > >=20
> > > Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
> > > --- =20
> >=20
> > This is a fix. You're missing a Fixes: tag in your commit message.
> > git log --grep=3D"Fixes:" should give you some examples...
> > =20
> Will fix this and resend the patch. Thanks for your help.
For future reference, you can just send the Fixes tag in a reply
and the b4 tooling most maintainers now use will pick it up
automatically.

Thanks,

Jonathan

>=20
> Best regards,
> Dimitri
> > With that, feel free to add:
> >=20
> > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> >  =20
> > > =C2=A0drivers/iio/humidity/hdc3020.c | 2 +-
> > > =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
> > >=20
> > > diff --git a/drivers/iio/humidity/hdc3020.c b/drivers/iio/humidity/hd=
c3020.c
> > > index 4e3311170725..ed70415512f6 100644
> > > --- a/drivers/iio/humidity/hdc3020.c
> > > +++ b/drivers/iio/humidity/hdc3020.c
> > > @@ -322,7 +322,7 @@ static int hdc3020_read_raw(struct iio_dev *indio=
_dev,
> > > =C2=A0		if (chan->type !=3D IIO_TEMP)
> > > =C2=A0			return -EINVAL;
> > > =C2=A0
> > > -		*val =3D 16852;
> > > +		*val =3D -16852;
> > > =C2=A0		return IIO_VAL_INT;
> > > =C2=A0
> > > =C2=A0	default: =20
> >  =20