Received-SPF: pass (google.com: domain of linux-kernel+bounces-41218-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <3e99ec2e-adb4-961e-4aab-1c6190fac178@amd.com>
Date: Sat, 27 Jan 2024 08:38:00 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 01/11] x86/sev: Rename snp_init() in the
 boot/compressed/sev.c file
To: Dionna Amalie Glaze <dionnaglaze@google.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
 Peter Zijlstra <peterz@infradead.org>,
 Dan Williams <dan.j.williams@intel.com>, Michael Roth
 <michael.roth@amd.com>, Ashish Kalra <ashish.kalra@amd.com>
References: <cover.1706307364.git.thomas.lendacky@amd.com>
 <98db05934aa2d12e7df4e34ca33309b1aa8c0284.1706307364.git.thomas.lendacky@amd.com>
 <CAAH4kHY-K09tMkqDxnrgbH7vW3uvdtZTRfVH0Bysu77YV36AYw@mail.gmail.com>
Content-Language: en-US
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <CAAH4kHY-K09tMkqDxnrgbH7vW3uvdtZTRfVH0Bysu77YV36AYw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Visva2VydjhSWVQzeXBMMjVRSXlWckZ4YXMzRjd5WUJDckFyRjdMNUpPSkJW?=
 =?utf-8?B?THJQSk9lbEJCL3lNRWlWd0phOEIxc25GTzhnYnZtL0tTZkl1MnVydmFkUkto?=
 =?utf-8?B?ZDhqMHVSM2RLRlFZaWtjWFM4K3NUSXhvWTBPTWxjQUk2NGQvSENaajBKQVk5?=
 =?utf-8?B?Wk54SlZjWWFkWVlZQkZWbDYzVi9CRFRDa1RMeEt1bTl2czh4OENvanB2cTZL?=
 =?utf-8?B?Q0RnZWRRRlkzZDE2UHp6TUpiTTlGbjkrRWIxQnIrdUpaU01TMHpxbHg1Y1RY?=
 =?utf-8?B?ZEpQeEFFRnViamlVSWJKeHlCZkJUajZGUG1GZ1JMd0NPL3dsdUFNMlZ1TDVi?=
 =?utf-8?B?VjdaVWkwMzBqOEkxWWJvSm5VWVBKUzNUckRGYThhM1A5RFV3a3JUY2J6NjlH?=
 =?utf-8?B?RDlJelNTMkhPaEIrekhteVZtM3pJVXpGeC9aa1NjM0l5U2VCY3JpUlU4eDUr?=
 =?utf-8?B?dzRxb1NFOVZ1aEd3aGoxZThQS1N6ZjZxMFBHVkZsUVFNRndDK1crM2Mxd3Rs?=
 =?utf-8?B?ZXNXL21ubHNWRytlVG15NXR4dENWaHBSOFZ4UmkwRTV2UGNFeWV4cTVQbDFm?=
 =?utf-8?B?czFQRHB2bEZKeTVpWmk3QURNRTAzbWJEQWZKeWJlcFZscFpGbXBrUFJ5anJX?=
 =?utf-8?B?ZS84Y1dpSG1ReHNRTkNvZ0dsa1Zuck1GNTgvZFI0MXg4ZTcydXlNR1VRejZS?=
 =?utf-8?B?ZUtrMXk5U1lvc2thYmtyYVF0RTlKdE1CZHh2Z0dITko0WVo3TmV0Y29rUEhP?=
 =?utf-8?B?ZGdwQlFjampLaG0rZkdHTlZ2ZXA1MmEydjgyL1BnQ2J0cVdWOFY3Y083aUdO?=
 =?utf-8?B?NFFLNnoydjBXSVo3MWhQNXVkN0hzUHVDa2xLSHNWNTlUMGY4eHd2YzRCa2pC?=
 =?utf-8?B?UWM1NUZsOGlsUXQyeTBEV0Q5R2NkSGVEZ056Q2xuWjltWXpsLzNJUVd5RGhx?=
 =?utf-8?B?eVlEdFptb3Y1T2V4T0ZZMFRVcFRaWC9ZZEJtUDhyZGNiRmpWRERVNVJuK0RY?=
 =?utf-8?B?MlZ5YjhyYkdkOWxEM3VOYmR4aG5nS3h1bGdnU1dlc0NqVlRBalAzQ1c0RHJr?=
 =?utf-8?B?T0ZRSE9rakczSTZuNFVmdVdDa1dlWTRBOHhuSE1mSjJzcUR6R2tuYVlEVzdh?=
 =?utf-8?B?QVRxd1NwaUxPUy9vekgzM294T3paYmI2K0pMdjZpYkdtYU1hRm5mZTl1VE1G?=
 =?utf-8?B?enBNazFNSTV3UzV0Y0VUb3ZiTXdUNHhKTGh4M0NvWHF0RGdaaFRoMHo5MkJ3?=
 =?utf-8?B?eHFQSURFYU5Rd0ZPOEtIMEhxTTkwZzBudktCR2NqNlpJdmZjQUY3NEZQQnRC?=
 =?utf-8?B?enFKZURXODdZdk4yZnIyTDY1d25CRXlVWURNYSszNGQrRS94Q2N3RUpneGtN?=
 =?utf-8?B?VWhvVSt4cUI2VTFYWkpCODR2Mys5T004ZndJdXI0UGE2ZFZGMjRNQ2pqdklJ?=
 =?utf-8?B?d3VsN05IeVNEb1YrcFZPYzNwUXVIOEREeDNPUHlzYjFrM3AwUWFwdFVNNDcz?=
 =?utf-8?B?RUpBYVN2NmRJczdsU2lqVlBZSVo3UWVLZndBSlFSc1c4eDEzQ20vOHNVcWNV?=
 =?utf-8?B?TDZ4Vi9iZ2ZRa3I1ODdGbGJhVTlDY0hwK2lCZ1hhSWR3MUlOT1Y2T2l6MitG?=
 =?utf-8?B?TXZkVllOZmExa0dGRHlIMlZONFVuZ0dIYURMTks5c2d0YlZScnZmMkozbFVx?=
 =?utf-8?B?VWhIWDVIMmpIcHRpMGxIYVI5ZWY3ZTVzQTZzSnc4bGJ6QWRXOHRWTExROWlk?=
 =?utf-8?B?RnZ3eGVWYng2Mk9sL2oyZHo5MnR3MkxZQTEraFlNaWFERTNHalAvWFRTS3Jt?=
 =?utf-8?B?cnBNaVM1eDJxS2tHVWdjbGREd0h3WXBsVGdITmZoL2MwaWpLdmtuV3FNTlBS?=
 =?utf-8?B?a2JVV0FxcVFPMlM1cjkvYlN2eEJNRm1IdjBGd2lZbG5jMzZEbE9BemZ1U2tz?=
 =?utf-8?B?ODZvU3BHSGRKMTRaSHpxdXphSDdMM0IwK2V3S1NHR1o4NFIrYlFtTDgwWHBp?=
 =?utf-8?B?Q2hQdVdWTmtlazJtc1I4Z0Y2Q0h5dDBvS0Z1K0EyZXlNQzVYL3dTazVETkI5?=
 =?utf-8?B?QVdCWnhJSUZoYmdKQjc1REx3QjVKeGNXazhwdTFyWllkdlpCR3hUa2hWbGdo?=
 =?utf-8?Q?k3FjCzGzBu60dvaurqBrBd2qE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e282395-6ec6-405f-a81a-08dc1f4591a0
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2024 14:38:03.7871
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ncBSFjWcSbEOUqQM1OkhxM3NNvrAgpYI/cDSNatEHpDid0M9mENxgrm9Id+bUte8iWf6W/f/2dgXY9BvWp08Rw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5382

On 1/26/24 18:05, Dionna Amalie Glaze wrote:
> On Fri, Jan 26, 2024 at 2:16 PM Tom Lendacky <thomas.lendacky@amd.com> wrote:
>>
>> The snp_init() function is local to the boot/compressed/sev.c file and is
>> not called from outside of the file. Change the name so that it is not
>> tied to the function definition in arch/x86/include/asm/sev.h. Move the
>> renamed snp_init() and related functions up in the file to avoid having to
>> add a forward declaration and make the function static, too.
>>
>> This will allow the snp_init() function in arch/x86/kernel/sev.c to be
>> changed without having to make the same change in boot/compressed/sev.c.
>>
>> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
>> ---
>>   arch/x86/boot/compressed/sev.c | 162 ++++++++++++++++-----------------
>>   1 file changed, 81 insertions(+), 81 deletions(-)
>>
>> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
>> index 454acd7a2daf..c3030cfb6484 100644
>> --- a/arch/x86/boot/compressed/sev.c
>> +++ b/arch/x86/boot/compressed/sev.c

> 
> Did some kind of whitespace replacement happen accidentally? There's a
> lot that isn't changed but the diff is quite big.

No whitespace damage. As mentioned in the commit log, the functions were 
moved within the file to avoid forward declarations.

Thanks,
Tom

> 
>>   void sev_prep_identity_maps(unsigned long top_level_pgt)
>>   {
>>          /*
>> --
>> 2.42.0
>>
>>
> 
>