Received-SPF: pass (google.com: domain of linux-kernel+bounces-41238-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <3399426b-57f3-17b2-9fa2-9244ee13542e@amd.com>
Date: Sat, 27 Jan 2024 09:18:24 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 05/11] x86/sev: Perform PVALIDATE using the SVSM when not
 at VMPL0
Content-Language: en-US
To: Dionna Amalie Glaze <dionnaglaze@google.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
 Peter Zijlstra <peterz@infradead.org>,
 Dan Williams <dan.j.williams@intel.com>, Michael Roth
 <michael.roth@amd.com>, Ashish Kalra <ashish.kalra@amd.com>
References: <cover.1706307364.git.thomas.lendacky@amd.com>
 <d89b9ebb592a2436a1969304f826ddf3866682bc.1706307364.git.thomas.lendacky@amd.com>
 <CAAH4kHaX8T01wrA1XUUK5bJGKHHTw7GSY9ua0bVvo-6MkODUOw@mail.gmail.com>
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <CAAH4kHaX8T01wrA1XUUK5bJGKHHTw7GSY9ua0bVvo-6MkODUOw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cG82bGNzL05aczU3ektlMi9ZMUxiaVdIOUg1WjYzZjFnemFveTAxUGJoYnMz?=
 =?utf-8?B?SGtjRVNxa0pRTitVU0o2RjYwdVlhS2Q1aFZhZUVKUzBDaDdVKzc0Y1g3aTZU?=
 =?utf-8?B?T0ZYeUh6TElJUVBOdFhGTDdHZ3Z3MXZSQ0xZTUhhUVNrYWovVzA5K0pjSzAw?=
 =?utf-8?B?dDFpd2VWWU94RGZnM05WZEZ3WXk4elBPVExuY2dDUWNGMGpJYnFsNUg5S3lh?=
 =?utf-8?B?M2JuUjhYeFVGUi8rVU91YWJnejh0c2M4TklJN0RKbjBGZTJPOTMwQlkxU2gw?=
 =?utf-8?B?Tm9EZzlVM1VTbFVwY2p5ei91dndyVUFES3RGbzN2QXZ4VklzSjIyN1V1eXpk?=
 =?utf-8?B?RnVqelVlc0dJZXFWaTFRanZtajFyZ2JQbmhBYWxnN095V3RXNzdNVTdjTzcr?=
 =?utf-8?B?bHE1UHlmNnBoeUs3djFvMzQ2NWtwRm1pNWF2UTFHSmpleGF6T3BxZ25WYzZK?=
 =?utf-8?B?aFp0M21HMlpRaXNISFJQMFVFZ2FvWnMvbnl3KzFQWE1FOW1uMkN6V0dTWUZ0?=
 =?utf-8?B?R29zZnQ2Q2FURC80R0FFOFFsK0lLYzMyMDdONjc3SHo1NlJpbkthWVErOTVY?=
 =?utf-8?B?bzI2WEVZaUJhVktqeVU5aC8rOWU0a2tjR2hTZmpUSmFBR2RDenFCNldOSkxZ?=
 =?utf-8?B?OThJdHkycHRzL0pOL3Z0TmsyMWZ4b0hqS092Tk56Q3ZPQzNvUi9WZWJPUnIw?=
 =?utf-8?B?UGlGSStPMzRsL3JBL1krY2kyYTZoVDBiOEZhQWFHamxHdHMzbUdpVWcweUpM?=
 =?utf-8?B?TEljUm4zb1NUUE50SzJ1OG9Qd0ZqdzNZdHBobkFva0xFSDU2ZkRmc09VTmNH?=
 =?utf-8?B?cnNHWEdNTS9SaitFa2dGREozU1dKQlV2RGhucGR5c0RpRVlQdXJ6Vzc4TjNy?=
 =?utf-8?B?YTRxZmM4T1RETWJUMGFUYlZhSklxRlZQVEwvTjVnOFQyaGp2T05Dc0xCbU9j?=
 =?utf-8?B?S0hoQ0hvRHNhMlJVS0dtL0pQY3JweDdXRHFiRUMwR1VDcC9DZDFKamtablFl?=
 =?utf-8?B?N3drRTFxTDJHK1MzZEpsY0paQXBKUTUvQ1hMVFI0M2s5R1Q0OGNTYm9CTWNT?=
 =?utf-8?B?bElxNjVua1RNL2VGejlia01VWm9FalNzNEhVRWxFRVhkdTVGOGdCREJVQjlT?=
 =?utf-8?B?Q2pXOUFsbUI0cnVQK3ZPbExmZW5oR3dOSmZnSTlWc2xUMVRvRjkvV016TjNO?=
 =?utf-8?B?Z09COUxhRllRRkxLVnVHa3dZL0diQmwvaDczNThCRW41UDNDUGVmbXRmcWVs?=
 =?utf-8?B?c2ZFLzFQcS9Kdm01Tk56VjM5QWtKbXVpK0xJUGJqNURpazhqVXF3TE9CVnZ3?=
 =?utf-8?B?aWgvMmdjWU43bllua0l1Z3BNZ29RODNmc3E1djZWaGF2dHJSV09neGZ2T0di?=
 =?utf-8?B?REdNaWV4Yk52VWtDRHBTQnVxZE9vSUVRZDFnMmhmWll5T1ZWUldGTVNacG1R?=
 =?utf-8?B?cGloblh3bzRtOWhLY0MwVXJwRGQwMTRjaDBmQWhKMU81d2dIbTNTZ05CSmV6?=
 =?utf-8?B?Nk85S2RyOXkzU2tibjh2TTMrWlk1YU9OUlJlRUFiOFRZYk9CTDBUTVdLUXJX?=
 =?utf-8?B?WlN2ZDh5VTFINEpTd1RuUGNwWUkrbFZVMjRTdThuZ0xCdEhyTlhMVTN5dUh0?=
 =?utf-8?B?WGQ1V1ArdFI1YnpCV2xDVUhpUkppWWVWY0k2c2RuYjVhWVlrUUs4VDZmM21w?=
 =?utf-8?B?Tk9MM2JpdFRDejY1Ym45WDMyVGIydDlrMmx0NFVGQmViV045YmlDUEYvM3Zk?=
 =?utf-8?B?MFo1K1E3SnAzYnZtaGh2VnBvWFZ1aGFuT2VaVzZHYjRqb2VzUXJSUUVsZVJp?=
 =?utf-8?B?LzcvV0g1S1hLajc5OVhWNDB1ZzNJeW5NbUJaUlBOUzRPQ2RWT1hkRmpMY2pT?=
 =?utf-8?B?MC9rVzFpaU9HSkJUcm90UWlJbmlIMUpQSUpPTlpManhLVko3cm90em5JaWd4?=
 =?utf-8?B?L0prVkY1NXRDaUExZzdxYTZmSUYvOU1jNkZCZmhpUmsrd2YyQXdFK2NablBh?=
 =?utf-8?B?UERkN1hDTVBxbmJyRWlFeGpaeUhKb3BEci8zc2hINWNVYm1PblBxVVp6M0tx?=
 =?utf-8?B?ZVFjMmtVcjQ5LzlZZTBiaTRGanM2ZVJ2NHpMZ1UvQXQ1bkZ5MHU4OFM0eFRy?=
 =?utf-8?Q?R9tZSxUCSqWc/73X58UdfEWCz?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf7c0f8e-d114-4dea-35d2-08dc1f4b360f
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2024 15:18:27.0623
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Dt050czlfvV+5CqdZDyV3lCJZ3x7gBTEYjllw4vgKq2bF3qrug/MqwdCe+6vFuCBVrr3/dGQwtmekdi/pviodw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7094

On 1/26/24 18:59, Dionna Amalie Glaze wrote:
> On Fri, Jan 26, 2024 at 2:18 PM Tom Lendacky <thomas.lendacky@amd.com> wrote:
>>
>> The PVALIDATE instruction can only be performed at VMPL0. An SVSM will
>> be present when running at VMPL1 or a lower privilege level.
>>
>> When an SVSM is present, use the SVSM_CORE_PVALIDATE call to perform
>> memory validation instead of issuing the PVALIDATE instruction directly.
>>
>> The validation of a single 4K page is now explicitly identified as such
>> in the function name, pvalidate_4k_page(). The pvalidate_pages() function
>> is used for validating 1 or more pages at either 4K or 2M in size. Each
>> function, however, determines whether it can issue the PVALIDATE directly
>> or whether the SVSM needs to be invoked.
>>
>> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
>> ---
>>   arch/x86/boot/compressed/sev.c |  42 +++++++-
>>   arch/x86/include/asm/sev.h     |  22 +++++
>>   arch/x86/kernel/sev-shared.c   | 176 ++++++++++++++++++++++++++++++++-
>>   arch/x86/kernel/sev.c          |  25 +++--
>>   4 files changed, 247 insertions(+), 18 deletions(-)
>>
>> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
>> index 5d2403914ceb..3fbb614c31e0 100644
>> --- a/arch/x86/boot/compressed/sev.c
>> +++ b/arch/x86/boot/compressed/sev.c

>> +static int svsm_protocol(struct svsm_call *call)
>> +{
>> +       struct ghcb *ghcb;
>> +       int ret;
>> +
>> +       if (boot_ghcb)
>> +               ghcb = boot_ghcb;
>> +       else
>> +               ghcb = NULL;
>> +
>> +       do {
>> +               ret = ghcb ? __svsm_ghcb_protocol(ghcb, call)
>> +                          : __svsm_msr_protocol(call);
>> +       } while (ret == SVSM_ERR_BUSY);
> 
> Should this loop forever or eventually give up and panic?

The question becomes how many times before giving up. This would likely 
only happen if the hypervisor is causing an issue for the SVSM, so it 
would be similar to a DoS. I'm open to suggestions, though.

On a side not, that does remind that this should also be checking for 
SVSM_ERR_INCOMPLETE.

> 

>>   void snp_set_page_private(unsigned long paddr)
>> @@ -261,6 +289,12 @@ void sev_es_shutdown_ghcb(void)
>>          if (!sev_es_check_cpu_features())
>>                  error("SEV-ES CPU Features missing.");
>>
>> +       /*
>> +        * Ensure that the boot GHCB isn't used for the PVALIDATE when running
> 
> Why the definite article? Which PVALIDATE is this referring to?

I'll clarify the comment, but it is specifically relates to the 
set_page_encrypted() for the boot_ghcb_page that immediately follows. 
Since the GHCB page is being changed to encrypted, we need to use the MSR 
protocol by zeroing out the boot_ghcb variable. The comment should have 
said for the Page State Change and not PVALIDATE.

Thanks,
Tom

>