Received-SPF: pass (google.com: domain of linux-kernel+bounces-41252-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <b50a822d-e9f3-58b2-7797-be5de0ee4626@amd.com>
Date: Sat, 27 Jan 2024 09:43:01 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 08/11] x86/sev: Provide guest VMPL level to userspace
Content-Language: en-US
To: Dionna Amalie Glaze <dionnaglaze@google.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
 Peter Zijlstra <peterz@infradead.org>,
 Dan Williams <dan.j.williams@intel.com>, Michael Roth
 <michael.roth@amd.com>, Ashish Kalra <ashish.kalra@amd.com>
References: <cover.1706307364.git.thomas.lendacky@amd.com>
 <61316ac5a8217f0397da87c78c2db08580ad75a5.1706307364.git.thomas.lendacky@amd.com>
 <CAAH4kHZjqq5OTyTqhCGxeCSrgw==_FyLqqLOaWK3JxQytF=k7A@mail.gmail.com>
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <CAAH4kHZjqq5OTyTqhCGxeCSrgw==_FyLqqLOaWK3JxQytF=k7A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TWc5c040cjZtenBlaE8rbjQ1QUl3SnlieTVJanYzWWJ3bDBYNVlhRWVKKzlt?=
 =?utf-8?B?dzM5MXVyRm4vcW9OTXJwTlloZUROM01FeU9wUkUvZEliSVFqaXY0QlN0aUlD?=
 =?utf-8?B?Tlp4STJJbEdBRGdEeFlPZ2JUK2dWV1B5bVhqcmNYVVlXTE1OQUo5Nm5JemtM?=
 =?utf-8?B?ZmVLdCtDdHFtbnpZaG1abktmdXN5ZGIxZkdSczc4MEVBMTRvemVncENaU1cw?=
 =?utf-8?B?M1RJeWR6YWV2ZHdKZDZPWDJtYk54dUFjMittSi9kZUZFQ2s1L3R1UlVUSk82?=
 =?utf-8?B?Vnh5eVRvVGN5ODdoMWsrOUExcURUYmJYaWhRV2pyYUNMUS93MTc5SWd1N3U2?=
 =?utf-8?B?UXlEQUNhQ240MUtkeTFUQ2VnWmhEUVZtejl4dUhoWXVaZGdOcExmUFZLMW1P?=
 =?utf-8?B?WEFLRCs0Z0FWczBGL3g0WEF1QTZ1TDYzR0FzWHBZS2VjNnI2Y1JuaGxOWURP?=
 =?utf-8?B?ekFzSE55andFZi81Wm9BbExYdlRiQkVLMUJLdFZUY3NRclk2bFZVbVpCanFI?=
 =?utf-8?B?MGNnQjgxTzFGSlN6OEU3MHQ2ZVZzTVFkOTdxMnNyRWFlakJrQXhQWHN5K0kw?=
 =?utf-8?B?bkhTNmxualV2ZXhzTE9kaGpvVHNnbSt1M25FQlZ6SkRrYmd0dE9wdERkWnpQ?=
 =?utf-8?B?d2UweFFYWnI3ZDJWQVVGYllXTDhVaUNWcjBUTm1jT3V0OWh1T3VqOWJTcTN0?=
 =?utf-8?B?T05ydUVUK0d0azF1ZVNvV3J4bkwzcllTM28wZ3F5ZTBIemlPVHFzOVlGeDdz?=
 =?utf-8?B?T25hZFZVYy9ONDFjdTdIUUVueG5uWUNQazhWc2U1TmNsM250UXZ4dU1YeTc3?=
 =?utf-8?B?RGpNNlNKWWtuYko5ZFp5TFowTVZWTmtBeG0vVjdncXZ4NlVrTTBMY3BoUVRJ?=
 =?utf-8?B?QXlCVHFvcmdjallHRUN0dVdtcVhBL0MwL3dDRUc4VGNpY0FuZjYzWGhXZjM5?=
 =?utf-8?B?SllwWURwTGdzcUl6WlJPUEZ5ZUJPS3U2NUJ2aisrZ0tOR1NwRmcrdlk3VURh?=
 =?utf-8?B?bENaamZZVGF4TnNmZkxpNEJ2VjlzR3B2S2txQkR4MEVjU1hBK2J1empRam9I?=
 =?utf-8?B?dysvazFXSEt0SDhxVHpNWDVMeGpVUVNldDBVUzN5RDA0cTl0SUwwWXZHdWJC?=
 =?utf-8?B?eGFrM0xMSDZ3UkFvZDdZcjJmU1AxbHJYS3RsdWxGOW9XUlNlMC9DZVhURUpK?=
 =?utf-8?B?bWJMRUZKM0lOcWVxb0ZmYW9oK2ZiRkU4dFNqNVA3L0QzbVFucU9Tc3ZUWW83?=
 =?utf-8?B?NHFaek05SXFIK04wV1dNRmNuSXVqZ3o5V042ditreHVjNW0xVWwyM2hleXd4?=
 =?utf-8?B?MlZzRUhiaVBoNlhRZDFFWGV6blJKMy84NTZldzJIZ0hJNDNORnZ3QjIyZDZN?=
 =?utf-8?B?bTB3cDFWK1FrZzNsR3lSWjZRSktVVkhEN3VxdFZqeURkWkpKZURlSlhyck1U?=
 =?utf-8?B?b3F2YmhhWm1NK3BjdWV5ZElzdlA1cXZSb0plSlRGRzBwcTF0VDFGN21lY25W?=
 =?utf-8?B?MVptZU9YWHhIazZSSGE5andWMnNQM1NQNVVDNSt1d0FIS2kzVGRPSkoxRWlq?=
 =?utf-8?B?UEFmWkc3ZTFCNis0d0dja3c4MUp6OW12OXQ0dVBEdDR2QWZFSC9uMlp3L21m?=
 =?utf-8?B?UkNzQzBORWQyektNaUt4d3pNa3dnN21ZNS82dE1XbE9rbWJpelhpN1RjMFR0?=
 =?utf-8?B?d1Vvc1RGRHcyenhMOWRQSUZYd1VvWTluUTBWZ0ZsL2Zwa0YrSElobjhwclJ0?=
 =?utf-8?B?OTNYVmNnY3g1MU1wY2prUlZITEpxWTU0LzQ4aVZ6ZEhpTjNKUzI3Z1J6TklF?=
 =?utf-8?B?UzErM01oZEtNSkNHakJ0dUcvODgyR0EvWDdFa3MyNExmek8zSWRJNU5aZDlB?=
 =?utf-8?B?T3VKby9zbkxaZVQrRTlYQ0QwODhZaVhjdDg3anVvQ2VZUXJ2c1pDRTBMQ3p6?=
 =?utf-8?B?WkI2SGtFMzR3NkV1ZTdCc1FoRG1pY0JMV0FUK2YyUXgrSFZyRTRsRVlnN3d4?=
 =?utf-8?B?bmg3bFZZUmxzanJzMjUybjIwQWFqdHBBejZKMUZPTTZ2R2Rmelo1MTJLOFBE?=
 =?utf-8?B?WER6UDRnY0VURkQ2UFVRR1c4bm9BeS9TSFhnTDlDNnQ2QUo2RlZXbS9tUURT?=
 =?utf-8?Q?mCSqHEEJqHKpJ16Qj3iYoXU0U?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4189d0fe-06fc-42da-cfd6-08dc1f4ea6d7
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2024 15:43:04.8211
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0zZ4AyHKaZ0Y6aTV5eijlzxW3RL5xYAxhQ2psi9ivy07+X2NzWUN6VKrkPkulJ03GzqNStd/gvlbi68Bpd7Y6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7094

On 1/26/24 19:06, Dionna Amalie Glaze wrote:
> On Fri, Jan 26, 2024 at 2:19 PM Tom Lendacky <thomas.lendacky@amd.com> wrote:
>>
>> Requesting an attestation report from userspace involves providing the
>> VMPL level for the report. Currently any value from 0-3 is valid because
>> Linux enforces running at VMPL0.
>>
>> When an SVSM is present, though, Linux will not be running at VMPL0 and
>> only VMPL values starting at the VMPL level Linux is running at to 3 are
>> valid. In order to allow userspace to determine the minimum VMPL value
>> that can be supplied to an attestation report, create a sysfs entry that
>> can be used to retrieve the current VMPL level of Linux.
> 
> Is this not the intended meaning of privlevel_floor in
> /sys/kernel/config/tsm/report/$report0/privlevel_floor?

Hmmm... possibly. But that would make someone using the ioctl() (which is 
still available) have to use the config-tsm support to get the value. If 
the overall consensus is not to have a sysfs entry, I'll remove it, but it 
could be useful beyond just attestation.

Your comment does make me realize that I did miss changing privlevel_floor 
for the TSM support. I need to set privlevel_floor to the current VMPL level.

Thanks,
Tom

>