Received: by 2002:a05:7412:9c07:b0:fa:6e18:a558 with SMTP id lr7csp380291rdb; Sat, 27 Jan 2024 10:16:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGZlDRwGpV3tOROZ0ATw5CprsM3mn8sKQwmue/9mxl5b9jul2Ye2igll6cdpW3IUoHrg7Qa X-Received: by 2002:a05:6a00:2d0c:b0:6db:c6b3:25e5 with SMTP id fa12-20020a056a002d0c00b006dbc6b325e5mr1084417pfb.12.1706379388518; Sat, 27 Jan 2024 10:16:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706379388; cv=pass; d=google.com; s=arc-20160816; b=SLkyEP80To79vDvjc5L7UGhypLsQU2IFQC3XHlJKPGkCff3nqVDvR/4kG0IuD86HId 6oS0NVXPqL+Z3whmzlSwGHW2yeZwNZSGs+6i7r9CFR5GyjlevzaltKm1p9jqdC8oVir6 C630S7ZH8h1pEm8ud/0TtHiES8ebMbX+QAqiLELeoIviZKdb2LYlbUk9bjvPQf2xqc6i s+noOZEbxvTYd1ULL1kMtfyMRR4PkH1DfGv0i5m6zOwIvIc2AwgMnHIfDgdWTlLLGlDX q4Ta3H8YYwkKIQFsunrxCE2aYcrSwvea65bzP/S9uVmlqyfvfsWEDyxAjI1cKVXGl/U9 oBVw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=vSQ5UafRZbdqjyXBg6v4aWqFM1oypbaRkfL89IWosPg=; fh=f4SnCP18GcvdWICWlZ/o9/0mE+7famEFm5zezDEmU9w=; b=Dh8RE0t+7B0ZFmZnHSbUGetrxZ21Ui4lto2bqPO4iFDAcQfp2gudrV7LWM0DTk6mx1 /IL+iGdBzswnBC6JUYjj+iR2f49NmIABGykchIV4nV5kJJvAbzOHmyxh07pFD2mld1J7 3d8RIo77ACxZSmnFyWcIbuZIAw0rUwkx+i2rSsHHZ794U/qvWLnsbmyMreFvAiPOCO1a rV26jx5H1Bv6fRNtMp1okIsYFovGtkjODRSY8GOL942fHKIAa1P1RTxgilT+tvcM3x8e 6LLNvGtqltNiLzwP7X8Bjvu/nMiYPmPqsaOBf8rxjq+ovUIg6Gz1qAUXlHI34DIdgvVM Kdcw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gJzblu0j; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-41351-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41351-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id z6-20020a63e546000000b005d8b3af5d3asi1556878pgj.769.2024.01.27.10.16.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Jan 2024 10:16:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-41351-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gJzblu0j; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-41351-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41351-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2CC60283ED9 for ; Sat, 27 Jan 2024 18:16:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1A7472D629; Sat, 27 Jan 2024 18:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gJzblu0j" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5D0B2D610 for ; Sat, 27 Jan 2024 18:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706379368; cv=none; b=a5PfNfvMkTvnzQy46XSooS/TarNJ7qOWHIA0eHyXbX+fB0XFQi63nUPrzMD60oFHWIAHdGgd7IBVJNDfmwIiChaOCXAw7AIksKFalSE8+/wCr/QFPthNTF5YWSCh6O+KToUTn5poEydA6Xve9dpvQb7jpRBi0rrAidhYGCOt1YQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706379368; c=relaxed/simple; bh=ZaHfr8zzpIiXgdpCUTc6QBJVotPOw1kev8Awy0ZxIXE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T9cF4E7j3sK4wAKFlrWiCvWp5g2yLs+ApyJOpZ1DAFHEyX2PTfs3FrMhO1CsDmzKsZms32C36TmJMKPgwB2pZ8dMO7Zj1NTLNR+IBTp4y1kGb+T0genPVSTospWzUSkQvWIT2rHgzXsTDX5foQ8vGLCh72WEVAOd52thzLl4kD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gJzblu0j; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706379366; x=1737915366; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZaHfr8zzpIiXgdpCUTc6QBJVotPOw1kev8Awy0ZxIXE=; b=gJzblu0jpKRnX+zKMk9EXijQgQXGXHVfWmcwSGw83eSiTbGCemJ1M0zX vPKb3GIXmfJDDglceRDSQpp7Woi8Zk53IxOAYS8UgTet20YKJgBt1JW0W ofSRzfTZ/rR39UgMBgSHh2/b4Pa0q320amqZrcveEiRggOZk4MiHhmACp eR21czmZ7FKH7yCJlQ6gqHzKlbnDhXOf9ktb+XGnbEBJJ2tWuaYEmOmf+ fq5795eIhCjuUPm7anW52gg/p3WefUHh0zwUxDnaEEXTBckARZaCxq0Uh VnfZTgJGuJe2p/fFeYmn4NF5Kx8umT81b4CpBumJgDuiKLosM9TxC0AxQ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10966"; a="10084691" X-IronPort-AV: E=Sophos;i="6.05,220,1701158400"; d="scan'208";a="10084691" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2024 10:16:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10966"; a="787423836" X-IronPort-AV: E=Sophos;i="6.05,220,1701158400"; d="scan'208";a="787423836" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 27 Jan 2024 10:16:00 -0800 Received: by black.fi.intel.com (Postfix, from userid 1000) id 9CC521F1; Sat, 27 Jan 2024 20:15:59 +0200 (EET) Date: Sat, 27 Jan 2024 20:15:59 +0200 From: "kirill.shutemov@linux.intel.com" To: "Huang, Kai" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "x86@kernel.org" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "Edgecombe, Rick P" , "Reshetova, Elena" , "Nakajima, Jun" , "rafael@kernel.org" , "peterz@infradead.org" , "linux-kernel@vger.kernel.org" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Hunter, Adrian" , "thomas.lendacky@amd.com" , "ashish.kalra@amd.com" , "kexec@lists.infradead.org" , "seanjc@google.com" , "bhe@redhat.com" , "linux-coco@lists.linux.dev" Subject: Re: [PATCHv6 16/16] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method Message-ID: References: <20240124125557.493675-1-kirill.shutemov@linux.intel.com> <20240124125557.493675-17-kirill.shutemov@linux.intel.com> <075348cdf2b4d3361db5c7d420f09a1c8935328e.camel@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <075348cdf2b4d3361db5c7d420f09a1c8935328e.camel@intel.com> On Fri, Jan 26, 2024 at 02:21:30PM +0000, Huang, Kai wrote: > > +static int __init acpi_mp_setup_reset(u64 reset_vector) > > +{ > > + pgd_t *pgd; > > + struct x86_mapping_info info = { > > + .alloc_pgt_page = alloc_pgt_page, > > + .free_pgt_page = free_pgt_page, > > + .page_flag = __PAGE_KERNEL_LARGE_EXEC, > > + .kernpg_flag = _KERNPG_TABLE_NOENC, > > + }; > > Nit: Reverse Christmas-tree style > > [...] Okay, will fix if new version is required. > > > > -#define ACPI_MP_WAKE_COMMAND_WAKEUP 1 > > +#define ACPI_MP_WAKE_COMMAND_WAKEUP 1 > > Nit: Is this change intended? Yes. Changed to indentation with tabs. -- Kiryl Shutsemau / Kirill A. Shutemov