Received-SPF: pass (google.com: domain of linux-kernel+bounces-41369-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sat, 27 Jan 2024 16:28:06 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Yang Jihong <yangjihong1@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org,
	mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
	jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf evsel: Fix duplicate initialization of data->id in
 evsel__parse_sample()
Message-ID: <ZbVZRrPp9YusOHzB@kernel.org>
References: <20240127025756.4041808-1-yangjihong1@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240127025756.4041808-1-yangjihong1@huawei.com>

Em Sat, Jan 27, 2024 at 02:57:56AM +0000, Yang Jihong escreveu:
> data->id has been initialized at line 2362, remove duplicate initialization.
> 
> Fixes: 3ad31d8a0df2 ("perf evsel: Centralize perf_sample initialization")
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>

Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>

- Arnaldo

> ---
>  tools/perf/util/evsel.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 4d14f14f2506..a0f36a6b8a2d 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -2363,7 +2363,6 @@ int evsel__parse_sample(struct evsel *evsel, union perf_event *event,
>  	data->period = evsel->core.attr.sample_period;
>  	data->cpumode = event->header.misc & PERF_RECORD_MISC_CPUMODE_MASK;
>  	data->misc    = event->header.misc;
> -	data->id = -1ULL;
>  	data->data_src = PERF_MEM_DATA_SRC_NONE;
>  	data->vcpu = -1;
>  
> -- 
> 2.34.1
> 

-- 

- Arnaldo