Received: by 2002:a05:7412:9c07:b0:fa:6e18:a558 with SMTP id lr7csp426561rdb; Sat, 27 Jan 2024 12:28:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IFi7C+LYtVpszaXbH+hLi4/Lb4HIySWIwWDfGakmcwZ9Fr5LnwmOsSgwQSK1jqkzuBn8fVR X-Received: by 2002:a17:902:7ed6:b0:1d5:dfc6:c32d with SMTP id p22-20020a1709027ed600b001d5dfc6c32dmr1823756plb.63.1706387325404; Sat, 27 Jan 2024 12:28:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706387325; cv=pass; d=google.com; s=arc-20160816; b=Y5rn2fNjLtErp5IwGCZqGphtHm1TZIqeKeSISPVOGS3xvzAQSkyCmji7kJHgNE9tlw SSANjbAXgGm/izoFSCEsFq2z3Jj55klxQtsRsr0rUWArgSNDinZTk6XO+iw+t4cnRn64 CUpXCwnZUWuxwJUU9ARqZz2/PqAQIDvySxThjPIIZGdFO40qNDy9siHq6oQ+P9dnuzMO ZH1SUYiLlEfoVIeV6kyd9KAjz24XeKOjtg3J9/X2IYO8Kni8aiPlN/sM+qlNNb52fYCy JaYp70e5VA7Gip2b+zaoVXff3pPHQ1emHiTBIthjq+OLS9NkHSymZ1GtAv242Rx254j1 0I2A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=LUBeGALBzMiCBd9c1SReM0q1tcU5b9jqGILvsbgJMIY=; fh=AZKpBq+DSXAgcWh1hBmGJZYmiH5WlenACAo0e5hB/10=; b=K9yuwljAMuzgoCVBBdTDwQV8TcKHK4TeO7ykxepXnGm11yTZC/n8hID5TZiZaMP+vE +/E2Hd7X4zXj+5wfeqH/uSZdmCJDKFWW2qvnybyzEYmZdB2kku0v+xjhVr7vUM7tNGj+ 1qA3a7AEZFCXW2MFZwUpOe0ll/JWgW8lwwlElKkVi72PeGMjKqmxAfvyf34RJZkLoY/s pEQAFIjs1pCv3fEscn43F7GjxTNaOUAxwDXGO81v8Y700MlIsRFWYSXXsV9KI7knl5qR de2Bab9p76Xyag5GGvJiCgjx70bPtmyKmq6DH4l43HV/aicE3JfxUF2Z4nA/tzAbgcnf zkuA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@iwanders.net header.s=google header.b=cPiUlOQC; arc=pass (i=1 spf=pass spfdomain=iwanders.net dkim=pass dkdomain=iwanders.net); spf=pass (google.com: domain of linux-kernel+bounces-41392-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41392-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d11-20020a170902cecb00b001d767df9dd9si3321721plg.333.2024.01.27.12.28.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Jan 2024 12:28:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-41392-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@iwanders.net header.s=google header.b=cPiUlOQC; arc=pass (i=1 spf=pass spfdomain=iwanders.net dkim=pass dkdomain=iwanders.net); spf=pass (google.com: domain of linux-kernel+bounces-41392-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41392-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 145432834F8 for ; Sat, 27 Jan 2024 20:28:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 727732E83F; Sat, 27 Jan 2024 20:28:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=iwanders.net header.i=@iwanders.net header.b="cPiUlOQC" Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D21352E419 for ; Sat, 27 Jan 2024 20:28:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706387315; cv=none; b=fKPb0a9C3UAoYnKZqZ7Xnbd2qYpOwvT3OmQl06x//rBJ9LeMWxnk6zRSoQS8dr5cebfpqckdZcZ/h7WuBMStsrpd9LG8GHFdEIdpuucOf5aKgrGs4nEh4MFCPVDVrISlWFO9040hGCh5ruD1L8HLin+P48u1ylfOS6Bi9vSLNoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706387315; c=relaxed/simple; bh=LUBeGALBzMiCBd9c1SReM0q1tcU5b9jqGILvsbgJMIY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=SWJ4VIu0XRacarVkyF9VyV2qjfhy0ZueFnX4PU/Zyqt5jP8Ft/q1IUwcnltHIqDZA9yrA140ZkWj7YYT1zVeFgfWTK2lqkeRis143vp0RZ4OffEXshRIlWiEtqgG7HkRxaGzVTz3359d/WGtU07K1l6Suc6CKdTp/stRl1Yb9rI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iwanders.net; spf=pass smtp.mailfrom=iwanders.net; dkim=pass (1024-bit key) header.d=iwanders.net header.i=@iwanders.net header.b=cPiUlOQC; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iwanders.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iwanders.net Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-783f0995029so46838785a.1 for ; Sat, 27 Jan 2024 12:28:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iwanders.net; s=google; t=1706387312; x=1706992112; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=LUBeGALBzMiCBd9c1SReM0q1tcU5b9jqGILvsbgJMIY=; b=cPiUlOQCphIO0s9NPenE2RFlAlyb8S/K+R4BYa5wtGhyJBvb2gRqVjjR8CnNDunySp Xbh8vGeIFcowaaGMk7FGDYGfMGysPL9EXx+tCaH8yBW7Utj96SM82gxSduB5Z3B8CUc5 cjcvlVDGKD1h85A82xGLxgStlA5Srwy6Bs08E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706387312; x=1706992112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LUBeGALBzMiCBd9c1SReM0q1tcU5b9jqGILvsbgJMIY=; b=hlqMFyMYYOTx6nQ39o+5fYW04T30qQWT03g2HVZG95sa2Jv8r9NzEge2vhSa2/Rkkl NubwJsQEHJOGDhrVv1h1w9qgFM8p7wSgogxQ9smrG/x/bxdq6evjQE+WH48ru9gXXooG MZ20aq7Ras/7wQqOW0uVLIlMpQNSUSkkhAUCJI70nYWk4x6UmlfLDdOCWzouvdcSSIhx qf/STunoWydQTbSJzhjaLLjkmvKqLCXx2FZzUw4xHIZb2pg5DDok6JWci0LMMvyO9/jy ktmFbWJZbwQopM1JtsgwCpdSFwsPTBBJkKgeE4dEYDMK/FK6C1jO3fPdnb36wYT9NFeV tlsw== X-Gm-Message-State: AOJu0YzqypuaARxeYebUOprAikb0xvMC7oB2BR4eD9jePFBoTGn0iLE6 j4hO5eVss1R0tCAcbaZzyHCbKBqQ/jTRIkJkAldf92fY8Y839Yeg2girFBHWh7E= X-Received: by 2002:a05:620a:22c6:b0:783:949f:cbe2 with SMTP id o6-20020a05620a22c600b00783949fcbe2mr2208737qki.150.1706387312664; Sat, 27 Jan 2024 12:28:32 -0800 (PST) Received: from eagle.lan (24-246-30-234.cable.teksavvy.com. [24.246.30.234]) by smtp.gmail.com with ESMTPSA id b7-20020a05620a270700b00783e18e45desm868815qkp.104.2024.01.27.12.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Jan 2024 12:28:32 -0800 (PST) From: Ivor Wanders To: w_armin@gmx.de Cc: corbet@lwn.net, hdegoede@redhat.com, ivor@iwanders.net, jdelvare@suse.com, linux-doc@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linux@roeck-us.net, luzmaximilian@gmail.com, markgross@kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v3 2/2] hwmon: add fan speed monitoring driver for Surface devices Date: Sat, 27 Jan 2024 15:28:28 -0500 Message-Id: <20240127202828.11140-1-ivor@iwanders.net> X-Mailer: git-send-email 2.17.1 In-Reply-To: <34960bb8-fb85-4cca-8b84-d99596d046e4@gmx.de> References: <34960bb8-fb85-4cca-8b84-d99596d046e4@gmx.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Hello Armin, thank you for your second review. > maybe you can just return 0 here. Good idea, that's indeed the only option for ret, so that makes it clearer. > Maybe use PTR_ERR_OR_ZERO() here? Definitely, thanks for suggesting this; cleans it up nicely. ~Ivor