Received-SPF: pass (google.com: domain of linux-kernel+bounces-41344-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Luca Weiss <luca@z3ntu.xyz>
To: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
 Bjorn Andersson <andersson@kernel.org>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Vladimir Lypak <vladimir.lypak@gmail.com>,
 Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 2/2] arm64: dts: qcom: msm8953: Add GPU
Date: Sat, 27 Jan 2024 18:32:43 +0100
Message-ID: <4539846.LvFx2qVVIh@z3ntu.xyz>
In-Reply-To: <c58c5897-b3f0-4449-a5b1-df10b117733c@linaro.org>
References:
 <20240125-msm8953-gpu-v1-0-f6493a5951f3@z3ntu.xyz>
 <20240125-msm8953-gpu-v1-2-f6493a5951f3@z3ntu.xyz>
 <c58c5897-b3f0-4449-a5b1-df10b117733c@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

On Freitag, 26. J=E4nner 2024 00:50:43 CET Konrad Dybcio wrote:
> On 1/25/24 22:56, Luca Weiss wrote:
> > From: Vladimir Lypak <vladimir.lypak@gmail.com>
> >=20
> > Add the GPU node for the Adreno 506 found on this family of SoCs. The
> > clock speeds are a bit different per SoC variant, SDM450 maxes out at
> > 600MHz while MSM8953 (=3D SDM625) goes up to 650MHz and SDM632 goes up =
to
> > 725MHz.
> >=20
> > To achieve this, create a new sdm450.dtsi to hold the 600MHz OPP and
> > use the new dtsi for sdm450-motorola-ali.
> >=20
> > Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> > Co-developed-by: Luca Weiss <luca@z3ntu.xyz>
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> >=20
> >   arch/arm64/boot/dts/qcom/msm8953.dtsi            | 115
> >   +++++++++++++++++++++++
> >   arch/arm64/boot/dts/qcom/sdm450-motorola-ali.dts |   2 +-
> >   arch/arm64/boot/dts/qcom/sdm450.dtsi             |  14 +++
> >   arch/arm64/boot/dts/qcom/sdm632.dtsi             |   8 ++
> >   4 files changed, 138 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi
> > b/arch/arm64/boot/dts/qcom/msm8953.dtsi index 91d083871ab0..1fe0c0c4fd15
> > 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
> > @@ -1046,6 +1046,94 @@ mdss_dsi1_phy: phy@1a96400 {
> >=20
> >   			};
> >   	=09
> >   		};
> >=20
> > +		gpu: gpu@1c00000 {
> > +			compatible =3D "qcom,adreno-506.0", "qcom,adreno";
> > +			reg =3D <0x01c00000 0x40000>;
> > +			reg-names =3D "kgsl_3d0_reg_memory";
> > +			interrupts =3D <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
> > +
> > +			clocks =3D <&gcc GCC_OXILI_GFX3D_CLK>,
> > +				 <&gcc GCC_OXILI_AHB_CLK>,
> > +				 <&gcc GCC_BIMC_GFX_CLK>,
> > +				 <&gcc GCC_BIMC_GPU_CLK>,
> > +				 <&gcc GCC_OXILI_TIMER_CLK>,
> > +				 <&gcc GCC_OXILI_AON_CLK>;
> > +			clock-names =3D "core",
> > +				      "iface",
> > +				      "mem_iface",
> > +				      "alt_mem_iface",
> > +				      "rbbmtimer",
> > +				      "alwayson";
> > +			power-domains =3D <&gcc OXILI_GX_GDSC>;
> > +
> > +			iommus =3D <&gpu_iommu 0>;
> > +			operating-points-v2 =3D <&gpu_opp_table>;
> > +
> > +			#cooling-cells =3D <2>;
> > +
> > +			status =3D "disabled";
> > +
> > +			zap-shader {
> > +				memory-region =3D <&zap_shader_region>;
> > +			};
> > +
> > +			gpu_opp_table: opp-table {
> > +				compatible =3D "operating-points-v2";
> > +
> > +				opp-19200000 {
> > +					opp-hz =3D /bits/ 64 <19200000>;
> > +					opp-supported-hw =3D <0xff>;
> > +					required-opps =3D <&rpmpd_opp_min_svs>;
> > +				};
>=20
> If you remove all OPPs but this one, can the GPU still spit out pixels?

Yep, phosh is starting and is rendering at a few fps.

fairphone-fp3:~$ cat /sys/devices/platform/soc@0/1c00000.gpu/devfreq/1c0000=
0.gpu/min_freq
19200000
fairphone-fp3:~$ cat /sys/devices/platform/soc@0/1c00000.gpu/devfreq/1c0000=
0.gpu/max_freq=20
19200000
fairphone-fp3:~$ cat /sys/devices/platform/soc@0/1c00000.gpu/devfreq/1c0000=
0.gpu/cur_freq=20
19200000

Regards
Luca

>=20
> Konrad