Received-SPF: pass (google.com: domain of linux-kernel+bounces-41342-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Luca Weiss <luca@z3ntu.xyz>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
 ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
 Bjorn Andersson <andersson@kernel.org>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Vladimir Lypak <vladimir.lypak@gmail.com>,
 Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 1/2] arm64: dts: qcom: msm8953: Add GPU IOMMU
Date: Sat, 27 Jan 2024 18:24:46 +0100
Message-ID: <6009977.lOV4Wx5bFT@z3ntu.xyz>
In-Reply-To: <a75d8b2f-a55a-4087-b039-60769678a480@linaro.org>
References:
 <20240125-msm8953-gpu-v1-0-f6493a5951f3@z3ntu.xyz>
 <d576e655-5d00-44ff-9405-0fceaa2d3935@linaro.org>
 <a75d8b2f-a55a-4087-b039-60769678a480@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

On Freitag, 26. J=E4nner 2024 00:49:55 CET Konrad Dybcio wrote:
> On 1/25/24 23:24, Dmitry Baryshkov wrote:
> > On 25/01/2024 23:56, Luca Weiss wrote:
> >> From: Vladimir Lypak <vladimir.lypak@gmail.com>
> >>=20
> >> Add the IOMMU used for the GPU on MSM8953.
> >>=20
> >> Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> >> ---
> >>   arch/arm64/boot/dts/qcom/msm8953.dtsi | 31
> >> +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)
> >>=20
> >> diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi
> >> b/arch/arm64/boot/dts/qcom/msm8953.dtsi index dcb5c98b793c..91d083871a=
b0
> >> 100644
> >> --- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
> >> @@ -1046,6 +1046,37 @@ mdss_dsi1_phy: phy@1a96400 {
> >>               };
> >>           };
> >> +        gpu_iommu: iommu@1c48000 {
> >=20
> > Nit: most of the platforms use the adreno_smmu label. But maybe the
> > msm-iommu vs arm-smmu makes difference here.
> Not really :)
>=20
> Please keep the labels unified

Ack, renaming to adreno_smmu

>=20
> > Nevertheless:
> >=20
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> >=20
> >> +            compatible =3D "qcom,msm8953-iommu", "qcom,msm-iommu-v2";
> >> +            ranges =3D <0 0x01c48000 0x8000>;
> >> +
> >> +            clocks =3D <&gcc GCC_OXILI_AHB_CLK>,
> >> +                 <&gcc GCC_BIMC_GFX_CLK>;
>=20
> And align these

They are?

Also any comment about the issues listed in the cover letter?

Regards
Luca

>=20
> Konrad