Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757157AbXLRByx (ORCPT ); Mon, 17 Dec 2007 20:54:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751759AbXLRByo (ORCPT ); Mon, 17 Dec 2007 20:54:44 -0500 Received: from wa-out-1112.google.com ([209.85.146.180]:33802 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751462AbXLRByn (ORCPT ); Mon, 17 Dec 2007 20:54:43 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=gunBwzrwACQZg+3j/t8NlG1VIZO5fv7B/RHKc2TOn/oz+Rr6RPpQKXI4CYrmzwNkNXhFL8KYjOcrggDhUSDA1mrewTqTdYRIorByCQoJaAW/2lTpb9cYBNOvrYvDwi2iT/zifCNxpTkEFSrMKpLnt0YL2sspH63Z2CHYhafEiwk= Message-ID: Date: Tue, 18 Dec 2007 09:54:42 +0800 From: "eric miao" To: "Jean Delvare" Subject: Re: [PATCH 2.6.24-rc5-mm 3/3] gpiolib: obsolete drivers/i2c/chips/pca9539.c Cc: "David Brownell" , linux-kernel@vger.kernel.org, i2c@lm-sensors.org, bgardner@wabtec.com In-Reply-To: <20071217212953.260f7826@hyperion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071216204214.01fd7a16@hyperion.delvare> <20071217180953.1BB8E16AF21@adsl-69-226-248-13.dsl.pltn13.pacbell.net> <20071217212953.260f7826@hyperion.delvare> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2357 Lines: 64 Well, I guess it would be a smooth path if we rename the drivers/i2c/chips/pca9539.c since that's old style I2C driver, which means the driver name is not so useful external so the impact is actually minimum. On Dec 18, 2007 4:29 AM, Jean Delvare wrote: > Hi David, > > > On Mon, 17 Dec 2007 10:09:53 -0800, David Brownell wrote: > > > Date: Mon, 17 Dec 2007 14:33:27 +0800 > > > From: "eric miao" > > > > > > for the following reasons: > > > > > > 1. there is currently no known users of this driver > > > > > > 2. the functionality of this driver is well supported with the recent > > > proposed drivers/gpio/pca9539.c, using GPIO_LIB > > > > > > Signed-off-by: eric miao > > > Acked-by: Ben Gardner > > > --- > > > Documentation/i2c/chips/pca9539 | 47 -------- > > > drivers/i2c/chips/Kconfig | 10 -- > > > drivers/i2c/chips/Makefile | 1 - > > > drivers/i2c/chips/pca9539.c | 196 ---------------------------------- > > > > Jean, do you sign off on this? In any case I think this should > > be going through your I2C patches. > > > > I'd be a trifle uneasy just deleting this, because it's possible > > there are *unknown* users ... and also because nobody's yet done > > a userspace interface to the gpiolib infrastructure. (It seems > > to be the usual case of nobody wanting such a thing quite enough > > to write the code.) > > > > I'd be more comfortable marking it as obsolete and flagging it > > for removal a release or two after Eric's new version merges ... > > though maybe that's just paranoia. > > I'm fine with this and I agree that it would be safer, however please > note that both drivers are mutually exclusive because they have the > same name, meaning that deprecating the old driver is not enough, you > also need Kconfig magic to make sure that both drivers aren't built at > the same time. Or alternatively the old driver could be renamed... I > don't really care myself, I'll take whatever patch you or Eric submit. > > -- > Jean Delvare > -- Cheers - eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/