Received-SPF: pass (google.com: domain of linux-kernel+bounces-41512-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240122053348.6589-1-arinc.unal@arinc9.com> <20240123154431.gwhufnatxjppnm64@skbuf>
 <d32d17ed-87b5-4032-b310-f387cea72837@arinc9.com>
In-Reply-To: <d32d17ed-87b5-4032-b310-f387cea72837@arinc9.com>
From: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Date: Sat, 27 Jan 2024 23:23:33 -0300
Message-ID: <CAJq09z6pidHvtv=3F_yKHDdY89kzYSF+xh89pzg1raAiQPMyMg@mail.gmail.com>
Subject: Re: [PATCH net-next] net: dsa: remove OF-based MDIO bus registration
 from DSA core
To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
Cc: Vladimir Oltean <olteanv@gmail.com>, Andrew Lunn <andrew@lunn.ch>, 
	Florian Fainelli <f.fainelli@gmail.com>, "David S. Miller" <davem@davemloft.net>, 
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, 
	mithat.guner@xeront.com, erkin.bozoglu@xeront.com, 
	=?UTF-8?Q?Alvin_=C5=A0ipraga?= <ALSI@bang-olufsen.dk>, netdev@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

> > IIUC, Luiz made the original patch for the realtek switches. Shouldn't
> > we wait until realtek registers ds->user_mii_bus on its own, before
> > reverting? Otherwise, you're basically saying that Luiz made the DSA
> > core patch without needing it.
>
> My findings point to that. Luiz made the patch to optionally register the
> MDIO bus of the MDIO controlled Realtek switches OF-based. So it's not
> necessary to wait.

Back in the time when I wrote that code, with the phy_read/write in
dsa_switch_ops, the OF node was only required to associate IRQ to each
port. Until my patch to register its own mdiobus driver lands (I hope
that happens before the next version), the port status will fall back
to polling. I don't think it is a critical feature but I'll let the
maintainers decide. ACK for me.

Regards,

Luiz