Received: by 2002:a05:7412:9c07:b0:fa:6e18:a558 with SMTP id lr7csp611071rdb; Sun, 28 Jan 2024 00:39:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHud7OS9LEko8jgd7gTJAyr6PaiazN/i1EQujMFI7+My5j2Mnvj9x4jSGLeTEh8nD8L/soH X-Received: by 2002:a05:6214:2021:b0:681:301d:4c0 with SMTP id 1-20020a056214202100b00681301d04c0mr4112046qvf.72.1706431177425; Sun, 28 Jan 2024 00:39:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706431177; cv=pass; d=google.com; s=arc-20160816; b=qOKeZmS6ioDJyuBzzD7dy/VaOw9OWntiLzIIV0keB6nm1fDMzGtUaJwtav6v6zI1Gr Pq5/LzteO8cv84ImIybAZHQC9Xp6h8ROvkBN5KUeoxjfHZ44Uf8MrVLAXKiQaGCT+6sL gQwUPES83CCXBCoBYR+2y4vQDyXl5dEuXGOWN3tejAwW6GY3Xcf79MY7/VMCfiXVV4Ny ErNOAPs0McUNYnNjHrY+MpDWFbXLmdDHEHYfSikvkuh8+F/io+KFYUYgBdzlF88sBVkC bxBTA/fdn8NbJ35WRDXheWi48CZ1NsmURF/uHJlXiYvwdinwJ5rMx/ulKlZ43bhqsYyF 5mLg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=RvZ5Io0RuJBaQqGXuTB/cV5lrPQkLLFNN0oKaea8T94=; fh=3nO3ufrhjADE+99APK7FC0WC4pJqridV9aXiaPTsof4=; b=QK8vBsL28ZayAl13Ezh5s4B+W0eB1pnCegsiRnZq8u1ZRlvu36x2F5z2gxNT5LjVdB bQdcYLOCXvJgwdh4w2LApuZ5qYzSHVCKoc55Q026AKSQtJA/9umVr0RVAPDqb+Vidp+Q Oqs9QYF4k3CnLpMCS4QgoO01kRDuj0L2MHOVGr54pv0MjUveB+LRwKUPDm7J8a/csjc6 dhsOysXo7fnNVgNNqYXUnjfp6rXY7AY4vE53P1VlTM1069wKOZ3W7DaozRYPS29aOsqr ApFMc+TYAJDBA3L2LMfO1vZEX9yw/rB63DBiMzCrcn+PuXeTlmNerxYOXHoXnXJr829D gm7g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=KkY1L1xm; arc=pass (i=1 spf=pass spfdomain=wanadoo.fr dkim=pass dkdomain=wanadoo.fr dmarc=pass fromdomain=wanadoo.fr); spf=pass (google.com: domain of linux-kernel+bounces-41565-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41565-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wanadoo.fr Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id f2-20020a056214076200b0068c4caadce8si10368qvz.53.2024.01.28.00.39.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 00:39:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-41565-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=KkY1L1xm; arc=pass (i=1 spf=pass spfdomain=wanadoo.fr dkim=pass dkdomain=wanadoo.fr dmarc=pass fromdomain=wanadoo.fr); spf=pass (google.com: domain of linux-kernel+bounces-41565-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41565-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wanadoo.fr Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 291E71C210B1 for ; Sun, 28 Jan 2024 08:39:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BFC73DDDC; Sun, 28 Jan 2024 08:39:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wanadoo.fr header.i=@wanadoo.fr header.b="KkY1L1xm" Received: from smtp.smtpout.orange.fr (smtp-26.smtpout.orange.fr [80.12.242.26]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0579ADDAE for ; Sun, 28 Jan 2024 08:39:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.12.242.26 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706431170; cv=none; b=hd4kRbK5Pmkq+EQaohHwuDi+3+TjxUZw3bquPzi5D963x45rKuwi+uX8zV3U+wbVX8XiRbIeVUlP9VhVcJ2YuffoR5osJ04sW+uxp73f5c+LeM5MM0gLv37xUR+0chpDW1tRbPM1pey2w7PLCUawhdgut2QQ9t5yw4FQXumXLdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706431170; c=relaxed/simple; bh=8r1VLIdtrkxcint45jps0p80JK8DBAEYsVjKQfZTKcA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BN+qPrcX+vOe3u04sH0svyCQYzGiNJ/wR0D7qum3rzQcQXv8yRT55kXPEN1UxAh2hMFoN49fRzYezAQdWb3w01rE6jFLJrmxMQr8WriWPplL5KQji6GthP/W6/Y+6HrirSZtN9PK+J0zEQ7jEo8MCw4+DO/xx4PCLTi2R9VHZTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wanadoo.fr; spf=pass smtp.mailfrom=wanadoo.fr; dkim=pass (2048-bit key) header.d=wanadoo.fr header.i=@wanadoo.fr header.b=KkY1L1xm; arc=none smtp.client-ip=80.12.242.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wanadoo.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wanadoo.fr Received: from fedora.home ([92.140.202.140]) by smtp.orange.fr with ESMTPA id U0gBr3CH8wnxGU0gCrvtYv; Sun, 28 Jan 2024 09:38:20 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1706431100; bh=RvZ5Io0RuJBaQqGXuTB/cV5lrPQkLLFNN0oKaea8T94=; h=From:To:Cc:Subject:Date; b=KkY1L1xm+CslAfCnBetSSorAkB+OaeXBaDHr4YV0PRu1JZB5Sy18yYAWI0OuvejoE 3yheer7k0bQlVvFFjbEDuXIbmoRotWyrxMNWW7Ec601FRIW8wTVOdGABkn69BH9iCh 7HyNoeovoBD7ul9yGBW3W9Tp2IRShtHCquEJOZNo4M/AiKlyOol1dh8MRF+wHc32Ib YTc2anfLqXfHzeU3Kr38LtT2sWYHe1fJPDAL04XrgyX6GKl1mAzSIKCN6RkfcTrmST fePLWsovz0bloH1y8a84RQHIPdcyjTj7Bs4/pGsc8bMJNvvsKQgbWOKqpy4q23lwnm iTzRs1HT1NB+g== X-ME-Helo: fedora.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 28 Jan 2024 09:38:20 +0100 X-ME-IP: 92.140.202.140 From: Christophe JAILLET To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Matthias Brugger , AngeloGioacchino Del Regno , Balsam CHIHI Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH] thermal/drivers/mediatek/lvts_thermal: Fix a memory leak in an error handling path Date: Sun, 28 Jan 2024 09:38:10 +0100 Message-ID: <481d345233862d58c3c305855a93d0dbc2bbae7e.1706431063.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If devm_krealloc() fails, then 'efuse' is leaking. So free it to avoid a leak. Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver") Signed-off-by: Christophe JAILLET --- drivers/thermal/mediatek/lvts_thermal.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c index 98d9c80bd4c6..fd4bd650c77a 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -719,8 +719,10 @@ static int lvts_calibration_read(struct device *dev, struct lvts_domain *lvts_td lvts_td->calib = devm_krealloc(dev, lvts_td->calib, lvts_td->calib_len + len, GFP_KERNEL); - if (!lvts_td->calib) + if (!lvts_td->calib) { + kfree(efuse); return -ENOMEM; + } memcpy(lvts_td->calib + lvts_td->calib_len, efuse, len); -- 2.43.0