Received-SPF: pass (google.com: domain of linux-kernel+bounces-41570-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Jiri Olsa <olsajiri@gmail.com>
Date: Sun, 28 Jan 2024 10:04:55 +0100
To: Menglong Dong <dongmenglong.8@bytedance.com>
Cc: andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net,
	john.fastabend@gmail.com, martin.lau@linux.dev, eddyz87@gmail.com,
	song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org,
	sdf@google.com, haoluo@google.com, bpf@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next] bpf: remove unused field "mod" in struct
 bpf_trampoline
Message-ID: <ZbYYtx7-Z-A07K4N@krava>
References: <20240128055443.413291-1-dongmenglong.8@bytedance.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240128055443.413291-1-dongmenglong.8@bytedance.com>

On Sun, Jan 28, 2024 at 01:54:43PM +0800, Menglong Dong wrote:
> It seems that the field "mod" in struct bpf_trampoline is not used
> anywhere after the commit 31bf1dbccfb0 ("bpf: Fix attaching
> fentry/fexit/fmod_ret/lsm to modules"). So we can just remove it now.
> 
> Signed-off-by: Menglong Dong <dongmenglong.8@bytedance.com>

Fixes: 31bf1dbccfb0 ("bpf: Fix attaching fentry/fexit/fmod_ret/lsm to modules")

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka


> ---
>  include/linux/bpf.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> index b86bd15a051d..1ebbee1d648e 100644
> --- a/include/linux/bpf.h
> +++ b/include/linux/bpf.h
> @@ -1189,7 +1189,6 @@ struct bpf_trampoline {
>  	int progs_cnt[BPF_TRAMP_MAX];
>  	/* Executable image of trampoline */
>  	struct bpf_tramp_image *cur_image;
> -	struct module *mod;
>  };
>  
>  struct bpf_attach_target_info {
> -- 
> 2.39.2
>