Received-SPF: pass (google.com: domain of linux-kernel+bounces-41583-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <000000000000e171200600d6d8bd@google.com> <000000000000910cf5060fe42991@google.com>
In-Reply-To: <000000000000910cf5060fe42991@google.com>
From: Amir Goldstein <amir73il@gmail.com>
Date: Sun, 28 Jan 2024 12:11:58 +0200
Message-ID: <CAOQ4uxg-nL69cbs8J4xmOd=EAQTiB-cfWgZR0TvY+hb144nZSA@mail.gmail.com>
Subject: Re: [syzbot] [overlayfs?] possible deadlock in seq_read_iter (2)
To: syzbot <syzbot+da4f9f61f96525c62cc7@syzkaller.appspotmail.com>
Cc: axboe@kernel.dk, brauner@kernel.org, dhowells@redhat.com, hch@lst.de, 
	jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-unionfs@vger.kernel.org, miklos@szeredi.hu, rafael@kernel.org, 
	syzkaller-bugs@googlegroups.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 27, 2024 at 4:28=E2=80=AFAM syzbot
<syzbot+da4f9f61f96525c62cc7@syzkaller.appspotmail.com> wrote:
>
> syzbot suspects this issue was fixed by commit:
>
> commit da40448ce4eb4de18eb7b0db61dddece32677939
> Author: Amir Goldstein <amir73il@gmail.com>
> Date:   Thu Nov 30 14:16:23 2023 +0000
>
>     fs: move file_start_write() into direct_splice_actor()
>
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=3D105aa1a018=
0000
> start commit:   2cf4f94d8e86 Merge tag 'scsi-fixes' of git://git.kernel.o=
r..
> git tree:       upstream
> kernel config:  https://syzkaller.appspot.com/x/.config?x=3De5751b3a22261=
35d
> dashboard link: https://syzkaller.appspot.com/bug?extid=3Dda4f9f61f96525c=
62cc7
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=3D176a4f49e80=
000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=3D154aa8d6e8000=
0
>
> If the result looks correct, please mark the issue as fixed by replying w=
ith:
>
> #syz fix: fs: move file_start_write() into direct_splice_actor()

Yes. I already wrote that this work is going to fix this repro
as well as other potential deadlocks.

#syz fix: fs: move file_start_write() into direct_splice_actor()

Thanks,
Amir.