Received-SPF: pass (google.com: domain of linux-kernel+bounces-41650-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <e5d9404d-eb3b-4d35-a027-790229986cdf@web.de>
Date: Sun, 28 Jan 2024 15:35:19 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: linux-arm-msm@vger.kernel.org, kernel-janitors@vger.kernel.org,
 Arnd Bergmann <arnd@arndb.de>, Amol Maheshwari <amahesh@qti.qualcomm.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Content-Language: en-GB
Cc: LKML <linux-kernel@vger.kernel.org>, Cong Liu <liucong2@kylinos.cn>,
 Kunwu Chan <chentao@kylinos.cn>
From: Markus Elfring <Markus.Elfring@web.de>
Subject: [PATCH] misc: fastrpc: Use memdup_user() rather than duplicating its
 implementation
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:nBeIRC6Gwa8=;SOz2uok6iiYTx+oo4qTbZNPc9z+
 XA9ypAbomu0MU5kJNtcwx+69odXvSk3UOsT+aB1bHPx8AWPDIebHl9o6Ux+NxLaw08bP/T3uB
 uzEZlo9Ug47s4A4VR1ChhfGRht8kLvJuxhvZLjFtP61q9SSgOx0os3s3kAUqAhm7hgt6Zrc0w
 6rVrU+6eSm+UdZQC2zZTtWfJOkHbBubCrs/NkTQwk4E+08Wy6C6f/q9Kj0jnvBPN7t3VqEbFu
 shT9Mkr4gyzRAGA6q1atE+gzzdPDPZKWDdgFcrmBxf5dXI7c1nFo2htop5hhPuiG6Thpn2cpl
 k9P2oEYQ+Mj8aBv4feQl7ONYNjCEdor0mqP2jUtKYhvN6kVWAqTD4d3KgDCEuatmSKsPlxPdt
 +uweEjw9Vq45Cdf8sdiSlqfXZaRqnn4FUEcJ9rec6ZmXzN+k6Qoag6IDqm9jUl7Gnq6XcSwtq
 4pa8Co6rvj4MNnrbSHZ5S/cNl13cleTWO3jH0cQpK+njtx76NOAZB+esdfEVPPOWnwBRuDYg5
 IoORNqAa2meEx8tea1hAVDcZiOsyvqTr6ZIa+01LPimEHjjPbjpoEVyeBKFiDA5MuaTO7yPWp
 pJTFQbQ2fcbzUAfeJ9+27h7fs+8QBUBMN62mUUGesmZ1Nbc1yFMU76haTBas4F5WFisWyjQxn
 x83c2w+y8N0n7NgdzA3i0ZMVu9wybfPoWho9G6HVqGmVXJ6XUyZnpJKWFmaJCVD4KumLQvi9H
 U1r91xuGWx5RTDFAXYF5yRWB3ucL1v8StYFavKAxiIZjEOn9DauUovoa2uKcQ1571gcR/R7Vl
 7Yp9IUgn1RUrJa95S3uz5xq+Evuat37N6AfAxv9nHJIpN6wG9d2AEzuz3EhUJ/kXnx6MnMQES
 VUbH3hlcJm4vjRpHcOZXRLqY7Wpj1dGPG/c0VREF0VSTS9EYNmXYkEXBhFtlq2TiWGOkXiOtR
 KcSBZNTSSbXksyR71YBE/Zn8M8M=

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 28 Jan 2024 15:17:03 +0100

Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.

Generated by: scripts/coccinelle/api/memdup_user.cocci

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
=2D--
 drivers/misc/fastrpc.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index 1c6c62a7f7f5..83da6ad4e541 100644
=2D-- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -1260,17 +1260,12 @@ static int fastrpc_init_create_static_process(stru=
ct fastrpc_user *fl,
 		goto err;
 	}

-	name =3D kzalloc(init.namelen, GFP_KERNEL);
-	if (!name) {
-		err =3D -ENOMEM;
+	name =3D memdup_user(init.name, init.namelen);
+	if (IS_ERR(name) {
+		err =3D PTR_ERR(name);
 		goto err;
 	}

-	if (copy_from_user(name, (void __user *)(uintptr_t)init.name, init.namel=
en)) {
-		err =3D -EFAULT;
-		goto err_name;
-	}
-
 	if (!fl->cctx->remote_heap) {
 		err =3D fastrpc_remote_heap_alloc(fl, fl->sctx->dev, init.memlen,
 						&fl->cctx->remote_heap);
=2D-
2.43.0