Received-SPF: pass (google.com: domain of linux-kernel+bounces-41652-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sun, 28 Jan 2024 14:38:42 +0000
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Sergio Palumbo <palumbo.ser@outlook.it>
Cc: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: sfp: add quirk for OEM DFP-34X-2C2 GPON
 ONU SFP DFP-34X-2C2 is a GPON spf module working at both1000baseX and
 2500baseX. Setting the module to LAN_SDS_MODE=6 the module is working at
 2500baseX with auto negotiation see at
 https://hack-gpon.org/ont-odi-realtek-dfp-34x-2c2/ Unfortunatly the module's
 PHY is accessible at 1000baseX only. ethtool returning: Supported ports:
 [Fibre ] Supported link modes: 1000baseX/Full
Message-ID: <ZbZm8jWM4pxR2tVm@shell.armlinux.org.uk>
References: <AS1PR03MB81897EB6C46BCC9514CB55C7827F2@AS1PR03MB8189.eurprd03.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AS1PR03MB81897EB6C46BCC9514CB55C7827F2@AS1PR03MB8189.eurprd03.prod.outlook.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>

Your subject line is way too long. Didn't look further because that
makes it difficult to read.

Please wait at least 24 hours for other review comments before
re-posting. Thanks.

On Sun, Jan 28, 2024 at 12:56:25PM +0100, Sergio Palumbo wrote:
>  After applying the quirk:
>  Supported ports: [ Fibre ]
>  Supported link modes: 1000baseX/Full
>                        2500baseX/Full
>  Tested on BANANA PI R3 in OpenWRT v 23.05.2 Kernel 5.15.137
>  Tested on sfp to ethernet Media Converter.
>  Autonegotiating 10001000baseX or 2500baseX according to the connected
>  host speed.
>  
>  This module is existing in 2 versions:
>  Vendor = "ODI"
>  Vendor = "OEM"
>  This is the patch for vendor "OEM"
>  
>  Patch has been inserted keeping the list in alphabetical order
>  first by vendor first and then by part string.
> 
> Signed-off-by: Sergio Palumbo <palumbo.ser@outlook.it>
> ---
>  drivers/net/phy/sfp.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> index f75c9eb3958e..260917488c77 100644
> --- a/drivers/net/phy/sfp.c
> +++ b/drivers/net/phy/sfp.c
> @@ -502,6 +502,9 @@ static const struct sfp_quirk sfp_quirks[] = {
>  	SFP_QUIRK_F("Walsun", "HXSX-ATRC-1", sfp_fixup_fs_10gt),
>  	SFP_QUIRK_F("Walsun", "HXSX-ATRI-1", sfp_fixup_fs_10gt),
>  
> +	// OEM FP-34X-2C2 GPON ONU support 2500base-X
> +	SFP_QUIRK_M("OEM", "DFP-34X-2C2", sfp_quirk_2500basex),
> +
>  	SFP_QUIRK_F("OEM", "SFP-10G-T", sfp_fixup_rollball_cc),
>  	SFP_QUIRK_M("OEM", "SFP-2.5G-T", sfp_quirk_oem_2_5g),
>  	SFP_QUIRK_F("OEM", "RTSFP-10", sfp_fixup_rollball_cc),
> -- 
> 2.34.1
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!