Received: by 2002:a05:7412:9c07:b0:fa:6e18:a558 with SMTP id lr7csp735770rdb; Sun, 28 Jan 2024 06:53:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSzQOgvSbEnF6ae5MZXk39rf69eMUYm9uCyzwU8PTLQ+7VQkoKef6aE6yCfxHkZ8ks8/tv X-Received: by 2002:a17:906:54e:b0:a35:518f:551a with SMTP id k14-20020a170906054e00b00a35518f551amr2373000eja.26.1706453608617; Sun, 28 Jan 2024 06:53:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706453608; cv=pass; d=google.com; s=arc-20160816; b=SEuzf02vIdxQYszeeeQbxbqte3090NM9jzBjP/gCSl3q4Fe9eohFjtxjUX29ubJDKN /K8O3l1bDUMuq5HAX+gcpF28buh5PCDDvE2fKRDesYGS6v8o4s4xuU/QaMkGUkK9n3W4 setGf44fFw9KMp3cziiYzjqicpF4Z7VLKg5gzg/wNJIsOHyTtQgmbICGNnBw/TOyz9fZ 87e5VFy/PbvafNQKhgbPN58IiS6TwjfGGIvvO+UNQFS2fdqj6nM5aA2QNOuXswY0CFBl YL1ihXsNmf9g1NtP498xTd8co5oq5/l5A8ZWWnOfoaYJ72n3StbblOrVYFA6NMqLpO3k MtHA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=K8lwTZg76jLh6Tpc789lFU8+PO2xYK4vEAyh411hwx4=; fh=Bilpvthh7wRR3INr34VOCwTUXVFHxPvCPQNxjsILSIg=; b=frjtqh/Cmj1t6958gJ4AGSZhGAouXrOUpr1xtZ7m25xqqPA0RQEY100kR6MA54T8qY iyvn1XAfSUSM4ynddO2xuv1XFOIyj0lp/qcuupbD9RIz0Ayi8yD9F1e86c/ETAYEYSfC IwTyEOuYvsgit8D3+ndnDxFMkNzaQ1zZT9s2uodWdECXCFjvk+WxBKr/Yog4C6FzxJJj /JpJslnWqDDmdcoiocNSN8iqqXR6YRvX8y1WCH8p0W2wWAw+nC3hs+l7FAw6NF0J6iZv IgelCry0AtZ8wk2DeMiIBmr4NnrBYhhrgPdFG7eeFPl1lmcjEcYhdmj2ob3hGzDUUDVC HleQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hwBFC0gJ; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-41660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41660-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gs8-20020a170906f18800b00a3160c1e339si2644950ejb.118.2024.01.28.06.53.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 06:53:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-41660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hwBFC0gJ; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-41660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41660-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5E1401F21E31 for ; Sun, 28 Jan 2024 14:53:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A13B522F17; Sun, 28 Jan 2024 14:53:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hwBFC0gJ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 935E622F1D; Sun, 28 Jan 2024 14:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706453598; cv=none; b=DcwWXWjEFjMneRiVXHubP2KNpCdTDJ3/xHm2OBiHjzn266LyF8AmTa2UuSP+K1WmSiHcZVFhm66n5548gnD4+/j5JqSAlRIlo2MAdyMwPt7L37JLzjn40K4UMPLEX8T8gmsDntlYlmHv2Y3/RqgzTgQdHOlXQodphDpzWWaiqPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706453598; c=relaxed/simple; bh=X+8FkEZoC8PItaOFui9G+nO+r1xWuz0EZ2Fj5H7CVOk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eYS7qtj1b+NA5Lup9kNtHm7n10QboKxGa3i3RgEeOHeImMW9UMKWHGXHLSkP2g+dBrxImKb0itd+rXg5oRw5chD6Jz0Z9rjSrEX0XNkF5pAxTjJx0ZqssweN/5eLROyILVIwGfAQ5AlvzvmBqXnZBaZUgP2iNr2eg0ovcrwLRQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hwBFC0gJ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8F52C433F1; Sun, 28 Jan 2024 14:53:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706453597; bh=X+8FkEZoC8PItaOFui9G+nO+r1xWuz0EZ2Fj5H7CVOk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hwBFC0gJ3F9MASW51QPtsNiaVIFzowQ3+OlJRJkf6iFRNwz9u712uue7mAnoJYoQI 7dinJv2gDRDZUIcZDvNl7pCOm7zAwmPSMJDmOrkrkTl7A4OSwXKVXkhYG84RebFHsX kMNdDN+VvNV08eF7cRafX9bql9iYsFnXaIzsRiag= Date: Sun, 28 Jan 2024 06:53:17 -0800 From: Greg KH To: Dan Williams Cc: Alistair Francis , bhelgaas@google.com, linux-pci@vger.kernel.org, Jonathan.Cameron@huawei.com, lukas@wunner.de, alex.williamson@redhat.com, christian.koenig@amd.com, kch@nvidia.com, logang@deltatee.com, linux-kernel@vger.kernel.org, chaitanyak@nvidia.com, rdunlap@infradead.org, Alistair Francis Subject: Re: [PATCH v6 2/3] sysfs: Add a attr_is_visible function to attribute_group Message-ID: <2024012855-limb-monument-cd86@gregkh> References: <2024012321-envious-procedure-4a58@gregkh> <65b1739b2c789_37ad294f5@dwillia2-xfh.jf.intel.com.notmuch> <65b400bf65c33_51c7f294c5@dwillia2-mobl3.amr.corp.intel.com.notmuch> <2024012631-removed-stuffed-ecc0@gregkh> <65b4112db4de0_51c7f2943a@dwillia2-mobl3.amr.corp.intel.com.notmuch> <65b471ced39b_4e7f529431@dwillia2-xfh.jf.intel.com.notmuch> <2024012703-exclaim-ground-2b8b@gregkh> <65b5b11ed7af0_51c7f29463@dwillia2-mobl3.amr.corp.intel.com.notmuch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65b5b11ed7af0_51c7f29463@dwillia2-mobl3.amr.corp.intel.com.notmuch> On Sat, Jan 27, 2024 at 05:42:54PM -0800, Dan Williams wrote: > Here it is again without being beholden to keeping the old > WARN()/pr_warn() regime when the group directory is not found. Thanks for all of the response to my questions, much appreciated. I think this looks great, let me test it here and add it to the patch series which caused me to want to do this in the first place and see how it goes. Give me a day or so, thanks so much I owe you a lot for digging into this! greg k-h