Received-SPF: pass (google.com: domain of linux-kernel+bounces-41682-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <8cf38c26-c8ec-401e-8aab-527ef811af90@amd.com>
Date: Sun, 28 Jan 2024 10:06:18 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 0/3] usb: typec: ucsi: Adding support for UCSI 3.0
To: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
 Heikki Krogerus <heikki.krogerus@linux.intel.com>, linux-usb@vger.kernel.org
Cc: pmalani@chromium.org, jthies@google.com,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Bjorn Andersson <andersson@kernel.org>,
 Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
 Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Hans de Goede <hdegoede@redhat.com>,
 Neil Armstrong <neil.armstrong@linaro.org>,
 Prashanth K <quic_prashk@quicinc.com>,
 Rajaram Regupathy <rajaram.regupathy@intel.com>,
 Saranya Gopal <saranya.gopal@intel.com>, linux-kernel@vger.kernel.org
References: <20240126183930.1170845-1-abhishekpandit@chromium.org>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20240126183930.1170845-1-abhishekpandit@chromium.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NE9CenplNjFZbnVwVTNSTG1hUjc5d2pWZVExSnp5OHhRTUVUUG00bDM1VWVy?=
 =?utf-8?B?VFpIajgxc2QxQ2kwdm5WdFViNXVHTWY2Z0x3ZW5ob1JUQ2pLenV2UFNrUmMx?=
 =?utf-8?B?VlVZUWJzNDBRblZKcnZKOWVBSzNDeUFKZkxyNGV2YkorQ0tSSDVxeXlWZG9y?=
 =?utf-8?B?TTQrN1kwTTIwMmlYZEVrdWpmc21PYU1vR1RXQm4yNndqR2JCWGRLYUdmMk1W?=
 =?utf-8?B?UUZ6d0JzcXh1RW9wdHFpSTVJMGMva2RnMVV3NHpqemc2Zmhxc0NhUzhrbC9s?=
 =?utf-8?B?K0loL25KS2dUOVRRamZCNFczczFmYkozc0RoL2ZOcnRFbUNid2Qwcm81WExJ?=
 =?utf-8?B?VHpZWjd3NnBmL2MwTUl0aFVkNU5LMXBWSVVHazJ1UWF3K1NVTHI1MStZeFFT?=
 =?utf-8?B?RTJja0ZDOTlhWnhkbStsSDl6bENaR3Zvd3ZCd3dNS3VYcEFCWjN6N0tNMzNy?=
 =?utf-8?B?Uncwd1lscHNOQWtaeHl5NWRjT0NQeXZDMjllaUlseU9LSVNoeUxtQVNRQ0Zo?=
 =?utf-8?B?N2h5YWdvajFsNE9WS0o4VU1JaCtaeEtvV2QzV3J0Mk85czBybURUQVlHbnFS?=
 =?utf-8?B?L1lwUW1Ld2ZvVk5wcUJaTnBhRzBPNW9GTnB2U3VxUUJJL2hrbFRxMVFVZTNx?=
 =?utf-8?B?aXg5djVZSDdrejdyZzBJbVBhRUtIdUdFcXJuTUR5S3N5T1hHOFVUTXZFZ0V6?=
 =?utf-8?B?R3RDOCtTOHVUeEg1eU5LVHZVc3MyWGNsdFcrdmprTFViNlEwckpYRG1hM0VM?=
 =?utf-8?B?a0lPd21ieExJWUpheVorL3B5eHU4WGpCczB5YnpzR1Bxb0lidFVSTzM2WDM4?=
 =?utf-8?B?V1d1WUFFUVZ6N1JvS3poVlM1MG0wTFNnTGVycnVwVmxrUHpGc2tNS1ZyWFBR?=
 =?utf-8?B?SkNBUGlqUTNZTjd1aDRGU2xUa09qNXNLUmdONnZvUTB4UmpHbjZWdHpYdHlm?=
 =?utf-8?B?TlVnR1ExV0U2VEw2OXR1WUpEY2I0cUk1RWNraDMvb0NyT0VISTRqN0VteEdF?=
 =?utf-8?B?YnBUTmZHd3Z1MUMxeVY3ZHZ2WUZ6WFVKVXJyak90R1I2WktJUG9HcVZSbE5G?=
 =?utf-8?B?N3VLWGNJUnRLOXEvUHZNYytxNEhVYlVQUU1JQzdhQ1NRbFJnRjZ6M3ZISnZy?=
 =?utf-8?B?OGFoMkg0VzJKUlBVWHF3R1VuRVFyMGpRZDU0WHBEeVdDSVpKOVpIK3FBcVdw?=
 =?utf-8?B?ODNYa05valVyc3BBZC9CZ3VXVjhHdEcxZ3VTbTRJYnpoUFo4RjRFaC91Ykd3?=
 =?utf-8?B?VWFhbU9lRTQrb0p4VkJSYXU4T3VjWVBnaFdrUm0veUJSUTI5dnJYdkpaRkdI?=
 =?utf-8?B?UWQvTGU2SjVGY0ovU0dVOWZFM2I2aC8xTTUwWTFmMGplUEhWOVpiOGp6Ullh?=
 =?utf-8?B?RnVIbDU2Mm0xNC90OW9DcGtkL0pRQ0c1WStmNklkNU9HNi9EVUtmTVZjMUZD?=
 =?utf-8?B?VlkwR3o2ZUlVck9qWWRzWkVzRkVzcHlMSk1Sb3VvT3VEc0VKcWkxeHN6TVlX?=
 =?utf-8?B?aXh0cHBWUVlvY0xyakZITmV4WERxazVEQXpPYkpnckdETi81N3hYUWNsRURL?=
 =?utf-8?B?eHJ0eFpQeEMxcnEyS1hDMWNZYW5WSE94UVJQVEdFM05rWlU2Ni9QVjY1cTc2?=
 =?utf-8?B?bXBrV3NoQ2oxdExxeFl1Um5zTE1kanBzaGY3U1lMVHR4bmJZQWlCejFvcFBy?=
 =?utf-8?B?RTd6ejFCaTdPRlBSQmlTbjlaNmxLNTBQTjlPVlhZTjVUL29kck9Wamhzd2h5?=
 =?utf-8?B?YXN4aHBDdGdDUWFNNXlCTnRHMlhsYTc3YlczZURCOUFZZEcvdFVLb3hpMTUr?=
 =?utf-8?B?blBPUTJWek9ndmFUWWlzVXNJWk9rMTkwV3lrbXZ1Nlc3cUFjRFlzY2NJaGJM?=
 =?utf-8?B?dm5vQ1NzWDRvc2FYY3Y0VzgxVXZBN0NZZWU3cVRqTTUyMHp4TjhLK0ZTWVBp?=
 =?utf-8?B?RlFWekY1U2g5K2VVMklqMVYwVkVOaWp5OGNxZkxBa0JkMlZ0R1dBcWhZWUY1?=
 =?utf-8?B?ZEpzc25lTEdZSzJQWkVjMUo5NUk0MGRLbUtQMHlDYmZXbTkzV0djWGl6Wjg5?=
 =?utf-8?B?bWFMQ1NRenVLZWtIMzdUWUE1NWJsd1pGS2NzdVFPQy9ObGl4YWs3ZXpXdlFM?=
 =?utf-8?Q?LO55OajejYjtce4SnzBEiLetb?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a72ba11b-074a-4519-70ff-08dc201b11ce
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2024 16:06:21.8132
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MyjwdJBMUQ+q4UYQw2RadI2OZCtVWD0GObf8bYhp3t9w86D6Rsvc3+DrEBzU3gZop6pJB28yUskZxyLUJBogZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5857

On 1/26/2024 12:39, Abhishek Pandit-Subedi wrote:
> 
> Hi Heikki,
> 
> This series starts the work adding UCSI 3.0 support to the UCSI driver.
> 
> There's a couple of pieces to start here:
> * Add version checks and limit read size on 1.2.
> * Update Connector Status and Connector Capability structures.
> * Expose Partner PD revision from Capability data.
> 
> These were tested against on a 6.6 kernel running a usermode PPM against
> a Realtek Evaluation board.
> 
> One additional note: there are a lot more unaligned fields in UCSI now
> and the struct definitions are getting a bit out of hand. We can discuss
> alternate mechanisms for defining these structs in the patch that
> changes these structures.

On the Windows side I notice that Microsoft explicitly checks the UCSI 
version to decide what data structures to use.

https://learn.microsoft.com/en-us/windows-hardware/drivers/usbcon/ucsi#ucm-ucsi-acpi-device-for-ucsi-20-and-greater

Perhaps doing something similar makes sense in Linux?

> 
> Thanks,
> Abhishek
> 
> Changes in v3:
>    - Change include to asm/unaligned.h and reorder include.
> 
> Changes in v2:
>    - Changed log message to DEBUG
>    - Formatting changes and update macro to use brackets.
>    - Fix incorrect guard condition when checking connector capability.
> 
> Abhishek Pandit-Subedi (3):
>    usb: typec: ucsi: Limit read size on v1.2
>    usb: typec: ucsi: Update connector cap and status
>    usb: typec: ucsi: Get PD revision for partner
> 
>   drivers/usb/typec/ucsi/ucsi.c | 49 +++++++++++++++++++++++++--
>   drivers/usb/typec/ucsi/ucsi.h | 64 ++++++++++++++++++++++++++++++++---
>   2 files changed, 107 insertions(+), 6 deletions(-)
>