Received-SPF: pass (google.com: domain of linux-kernel+bounces-41837-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sun, 28 Jan 2024 17:55:00 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Raag Jadav <raag.jadav@intel.com>, jarkko.nikula@linux.intel.com, 
	mika.westerberg@linux.intel.com, lakshmi.sowjanya.d@intel.com, linux-pwm@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] pwm: dwc: use to_pci_dev() helper
Message-ID: <q5mde3tak2mpqnkphue7vdez33l4bh2urjqryljzzpvz556yjw@2gmnudzle3my>
References: <20240122030238.29437-1-raag.jadav@intel.com>
 <20240122030238.29437-4-raag.jadav@intel.com>
 <ZbZo2A3qU9RIz568@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="rfhsoumljfh5ev2l"
Content-Disposition: inline
In-Reply-To: <ZbZo2A3qU9RIz568@smile.fi.intel.com>


--rfhsoumljfh5ev2l
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Sun, Jan 28, 2024 at 04:46:48PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 22, 2024 at 08:32:38AM +0530, Raag Jadav wrote:
> > Use to_pci_dev() helper to get pci device reference.
>=20
> PCI
>=20
> ...
>=20
> >  static int dwc_pwm_suspend(struct device *dev)
> >  {
> > -	struct pci_dev *pdev =3D container_of(dev, struct pci_dev, dev);
> > +	struct pci_dev *pdev =3D to_pci_dev(dev);
> >  	struct dwc_pwm *dwc =3D pci_get_drvdata(pdev);
> >  	int i;
> > =20
> > @@ -120,7 +120,7 @@ static int dwc_pwm_suspend(struct device *dev)
> > =20
> >  static int dwc_pwm_resume(struct device *dev)
> >  {
> > -	struct pci_dev *pdev =3D container_of(dev, struct pci_dev, dev);
> > +	struct pci_dev *pdev =3D to_pci_dev(dev);
> >  	struct dwc_pwm *dwc =3D pci_get_drvdata(pdev);
> >  	int i;
>=20
> I don't see how pdev is being used. That said, why dev_get_drvdata() is n=
ot
> suffice?

I would even consider using dev_get_drvdata() a nice cleanup given that
pci_get_drvdata() works because dwc_pwm_alloc() called dev_set_drvdata()
(and not pci_set_drvdata()).

Not so long ago (i.e. before commit a357d1493f0c ("pwm: dwc: Move memory
allocation to own function")) the dwc driver was pci only and used
pci_set_drvdata(). Then the upside of first converting the struct device
to a struct pci_dev was not to hard code knowledge about the
implementation of pci_[gs]et_drvdata().

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--rfhsoumljfh5ev2l
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmW2huQACgkQj4D7WH0S
/k6xAAf9FrXzNIGYd31goHKYoohHhptzWd8EBhHqM1GX6oWyeea03c7SQ3q7aOr0
xEMthrjkaLf5Pqj3xO8okMKcN2dOtFG1Jv5Fx4No6ylh9LNFU5kJwnG8s24a82dV
x12AlAfLsd2PpCKxTFgj5ZaadkB0y/Fd9z28yArE5zE2kZgVS4IQaaUZJun8NvxV
V56mrHH7jk3qAR4/alfr9nKSNkgEiL1fpjpD22gF1Fh77fn+J6wK4b22xSsqESXL
Xg5PHq1uqZwoR++ooGr05Dt5EW3fub8IjKzfSUMSSh76tWy5PL69aFJzbATWHRmM
kiyl339nCMNX/y40/FTSqT4KSLMPZQ==
=lEBB
-----END PGP SIGNATURE-----

--rfhsoumljfh5ev2l--