Received-SPF: pass (google.com: domain of linux-kernel+bounces-41838-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sun, 28 Jan 2024 17:58:38 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Raag Jadav <raag.jadav@intel.com>, jarkko.nikula@linux.intel.com, 
	mika.westerberg@linux.intel.com, lakshmi.sowjanya.d@intel.com, linux-pwm@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/3] pwm: dwc: simplify error handling
Message-ID: <r6vulwv76x7ydkmszlwlswjve7y2pmasz77wkqub73qopd5src@y3ta72owtw5b>
References: <20240122030238.29437-1-raag.jadav@intel.com>
 <20240122030238.29437-3-raag.jadav@intel.com>
 <ZbZpMO9b7L-DNIcb@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="4vfzke46slaro6ed"
Content-Disposition: inline
In-Reply-To: <ZbZpMO9b7L-DNIcb@smile.fi.intel.com>


--4vfzke46slaro6ed
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Sun, Jan 28, 2024 at 04:48:16PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 22, 2024 at 08:32:37AM +0530, Raag Jadav wrote:
> > Simplify error handling in ->probe() function using dev_err_probe() hel=
per.
>=20
> ...
>=20
> >  	ret =3D pcim_iomap_regions(pci, BIT(0), pci_name(pci));
> > -	if (ret) {
> > -		dev_err(dev, "Failed to iomap PCI BAR (%pe)\n", ERR_PTR(ret));
> > -		return ret;
> > -	}
> > +	if (ret)
> > +		return dev_err_probe(dev, ret, "Failed to iomap PCI BAR (%pe)\n", ER=
R_PTR(ret));
> > =20
> >  	base =3D pcim_iomap_table(pci)[0];
>=20
> > -	if (!base) {
> > -		dev_err(dev, "Base address missing\n");
> > -		return -ENOMEM;
> > -	}
> > +	if (!base)
> > +		return dev_err_probe(dev, -ENOMEM, "Base address missing\n");
>=20
> This check is bogus. Just remove it completely.

This would be a separate patch though. IMHO mechanically converting to
dev_err_probe() is fine.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--4vfzke46slaro6ed
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmW2h7gACgkQj4D7WH0S
/k7MpggAoa8e8OxiEWhR+vVyUOs0kgmdMkXRNj2a6v+Rorm2yFeWHT1q6R/snxrN
fLGDycNB+K9ApjaSUvs3moSkWQ0z2ZTkWHQozQjABA61pYSLy5ZR9sZmm0pjuZyX
b/mQ0nyhb+HLQQOg2y1AaRS/0PR4GuytagNjjYULCQEYN81fZvEnJ/VKKZGMgGGq
qrLRjp8WnOR/wiKM8bwUuHtYrjUCIwtd3WlH2a/88qOjiuGjSd3fT7Jnkyb5PUXk
VunvmyyirBt0FM1QVdkGzECfsnpkgFSXLThZ3/va10AKd6VRBNugGnHJ5oWUkPkY
FRCBzUaZIH6nZvk1hMyJA416f/ppLg==
=QQyq
-----END PGP SIGNATURE-----

--4vfzke46slaro6ed--