Received-SPF: pass (google.com: domain of linux-kernel+bounces-41844-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sun, 28 Jan 2024 17:28:03 +0000
From: Conor Dooley <conor@kernel.org>
To: Duje =?utf-8?Q?Mihanovi=C4=87?= <duje.mihanovic@skole.hr>
Cc: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, dmaengine@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmp-dma: convert to YAML
Message-ID: <20240128-feminine-sulfite-8891c60ec123@spud>
References: <20240127-pxa-dma-yaml-v1-1-573bafe86454@skole.hr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="FsqycuUB7fyG5ylo"
Content-Disposition: inline
In-Reply-To: <20240127-pxa-dma-yaml-v1-1-573bafe86454@skole.hr>


--FsqycuUB7fyG5ylo
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey,

On Sat, Jan 27, 2024 at 05:53:45PM +0100, Duje Mihanovi=C4=87 wrote:
> Convert the Marvell MMP DMA binding to YAML.
>=20
> The TXT binding mentions that the controller may have one IRQ per DMA
> channel. Examples of this were dropped in the YAML binding because of
> dt_binding_check complaints (either too many interrupt cells or
> interrupts) and the fact that this is not used in any of the in-tree
> device trees.
>=20
> Signed-off-by: Duje Mihanovi=C4=87 <duje.mihanovic@skole.hr>
> ---
>  .../devicetree/bindings/dma/marvell,mmp-dma.yaml   | 82 ++++++++++++++++=
++++++
>  Documentation/devicetree/bindings/dma/mmp-dma.txt  | 81 ----------------=
-----
>  2 files changed, 82 insertions(+), 81 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/dma/marvell,mmp-dma.yaml b=
/Documentation/devicetree/bindings/dma/marvell,mmp-dma.yaml
> new file mode 100644
> index 000000000000..fe94ba9143e0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/marvell,mmp-dma.yaml
> @@ -0,0 +1,82 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/marvell,mmp-dma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell MMP DMA controller
> +
> +maintainers:
> +  - Duje Mihanovi=C4=87 <duje.mihanovic@skole.hr>
> +
> +description:
> +  Marvell MMP SoCs may have two types of DMA controllers, peripheral and=
 audio.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - marvell,pdma-1.0
> +      - marvell,adma-1.0
> +      - marvell,pxa910-squ
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    description:
> +      Interrupt lines for the controller, may be shared or one per DMA c=
hannel
> +    minItems: 1
> +
> +  '#dma-channels':
> +    deprecated: true
> +
> +  '#dma-requests':
> +    deprecated: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - '#dma-cells'
> +
> +allOf:
> +  - $ref: dma-controller.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - marvell,adma-1.0
> +              - marvell,pxa910-squ
> +    then:
> +      properties:
> +        asram:
> +          description:
> +            phandle to the SRAM pool
> +          minItems: 1
> +          maxItems: 1
> +        iram:
> +          maxItems:=20

These properties are not mentioned in the text binding, nor commit
message. Where did they come from?

That said, for properties that are only usable on some platforms, please
define them at the top level and conditionally permit/constrain them.

> +unevaluatedProperties: false
> +
> +examples:
> +  # Peripheral controller
> +  - |
> +    pdma0: dma-controller@d4000000 {

The label is not needed here or below.
In fact, I'd probably delete the second example as it shows nothing that
the first one does not.

thanks,
Conor.

> +        compatible =3D "marvell,pdma-1.0";
> +        reg =3D <0xd4000000 0x10000>;
> +        interrupts =3D <47>;
> +        #dma-cells =3D <2>;
> +        dma-channels =3D <16>;
> +    };
> +
> +  # Audio controller
> +  - |
> +    squ: dma-controller@d42a0800 {
> +        compatible =3D "marvell,pxa910-squ";
> +        reg =3D <0xd42a0800 0x100>;
> +        interrupts =3D <46>;
> +        #dma-cells =3D <2>;
> +        dma-channels =3D <2>;
> +    };

--FsqycuUB7fyG5ylo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbaOowAKCRB4tDGHoIJi
0m+3AP9YxodicQITyEr/b/mKRwodDU8jOXJAYo19Ub+5NXgh3QEAjNIVJuDzLiYE
yllcgmsNqNpWgE9hTaQcUSvqNwkinQc=
=hw/+
-----END PGP SIGNATURE-----

--FsqycuUB7fyG5ylo--