Received: by 2002:a05:7412:3110:b0:fc:8d27:76e1 with SMTP id es16csp834170rdb; Sun, 28 Jan 2024 10:23:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IGWLPgEl5hK7zu9wwdJ92+p0QKIMfzS1z0Ni2KJ7UkWik6iQiVncyaMgPJ8tT6VwCUVCfg9 X-Received: by 2002:a17:902:bcc9:b0:1d0:a791:7598 with SMTP id o9-20020a170902bcc900b001d0a7917598mr3272261pls.129.1706466215189; Sun, 28 Jan 2024 10:23:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706466215; cv=pass; d=google.com; s=arc-20160816; b=o9IkQlnOct1z6cJfrjOOOq2YYbrPo0vdWqWOVUDF7LaWIarpcyp2njPtL+37pUhGAU bSVdeHShU0r+2nZt1Z/QMBRUH3vwwcwZK/0CKw7wLEXKDg2A0LRgLUupCdR+CDcmj2NF X8JkwBhX5kJ43EbbEv2slYgIZmATzp3KtZDOUrWfTJR39kk/l14FBrFaZFxKCiRqfLLr 2yUTKnmvwFrKL5g68giuS+RboTtx9uFOS83LJ6606E3/xPP8gkMXg9EnZx5QjCdrLKWm Cg2rZdeg3CLDO1PnLusHeDEYdUFCGbiVnidgWOqilT7jfxkf3s0C+3cU3Fqg4/lni76O KpiA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:organization:references:cc:to:from:subject; bh=IRltd6O2kf9YbyrQUxBsrCmegZeVA7nyinSMHsoc2+s=; fh=4TbGRyu74MVGBD1ojLEXm/qR6lrg8ldwqoVM6Mhhpg8=; b=cxNcvzv8EjcG8O94UZaSiOvYQvcztT8dWwA4k/m4GK5YIB381a/fieY8xOkwT3bwyE BohYuEXNYpaWuyPed6PhLYsQu4aJeUzxDqv9pC7uZ4AiqdHQWEWzxWUj8i61q9UzoGxM JgJXsJuKHP41HPAncpJTYyjSmWjDul9y6RQJf9f4PSzhgGe2NSO69C59HO1PFXybmhR/ g7V6MI4FB3lJBH3qZ/2JqN9QwWKCYl2V4eNB4EAPWCuHi5+0KEZ1Q9K6gXsZsUpOPJ0j djTlDNbp1xAoNmP6+5+GARINezMx5WchtY8wA6s5dXuDvyt9exjAzkYUIY23oE8QljJ1 gBBA== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-41879-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41879-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id u1-20020a17090282c100b001d8e8519ef7si86343plz.557.2024.01.28.10.23.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 10:23:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-41879-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-41879-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41879-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id F3789B20E36 for ; Sun, 28 Jan 2024 18:23:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E4E2631A8F; Sun, 28 Jan 2024 18:23:14 +0000 (UTC) Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9977331A93; Sun, 28 Jan 2024 18:23:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706466194; cv=none; b=QKhOfGdZlHmpwBdJgxuGZrQW/QmhPhWaDGkYWhkGW9VqNttn9a4sv0fEXsZZoc8VaCB+CQTHuN+mQVyL4P3B8P/bGqYOXQoAf//CFHF+tYxihmaWZSvuolhw1B1ItnTNiQkfHiC2lSWmS6AsDdCdnvsz1apDBfq0r5gTmhK3LRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706466194; c=relaxed/simple; bh=4/rZR42xEDUEKBuhsxAoPbAjoVhj37dpEubn0dEsJmo=; h=Subject:From:To:CC:References:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=DQsAYf1tS7OUsWAIaJf2hqraMX3VcFynrxscA63x5W0aQMYarxJypDMWi68VxS+yeLYTYL4Aqr6iYvXlcfl29AB9BHgQfMkjYQV930rT2cqaHhoPGF/jjUEUCO/4fkBrbkarnXErTjnQpuj0yQDg1PqJNtgv7OiVvD+ovZuwYwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.105] (178.176.74.225) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Sun, 28 Jan 2024 21:23:02 +0300 Subject: Re: [PATCH net-next v4 08/15] net: ravb: Move the IRQs get and request in the probe function From: Sergey Shtylyov To: Claudiu , , , , , , , CC: , , , Claudiu Beznea References: <20240123125829.3970325-1-claudiu.beznea.uj@bp.renesas.com> <20240123125829.3970325-9-claudiu.beznea.uj@bp.renesas.com> Organization: Open Mobile Platform Message-ID: Date: Sun, 28 Jan 2024 21:23:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 01/28/2024 18:08:14 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 182981 [Jan 28 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Int_BEC_cat_st_0} X-KSE-AntiSpam-Info: {Tracking_arrow_text} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.74.225 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.74.225 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: 178.176.74.225:7.1.2,7.7.3,7.4.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;127.0.0.199:7.1.2;omp.ru:7.1.1 X-KSE-AntiSpam-Info: {cloud_iprep_silent} X-KSE-AntiSpam-Info: ApMailHostAddress: 178.176.74.225 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 01/28/2024 18:13:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 1/28/2024 3:09:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 1/28/24 9:03 PM, Sergey Shtylyov wrote: [...] >> I suggest the following subject "net: ravb: Move getting/requesting IRQs in >> the probe() method". Or the probe() API, if you prefer this naming... > Oops, s/in/to/. :-) Well, we don't move getting IRQs to the probe() method, but we move the platform_get_irq[_byname]() calls to a sperate function. So, pperhaps "in" was good... :-) [...] MBR, Sergey