Received-SPF: pass (google.com: domain of linux-kernel+bounces-41931-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Stefan Wahren <wahrenst@gmx.net>
To: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Cc: Lino Sanfilippo <LinoSanfilippo@gmx.de>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Stefan Wahren <wahrenst@gmx.net>
Subject: [PATCH V4 02/15 net-next] qca_spi: Improve SPI thread creation
Date: Sun, 28 Jan 2024 21:10:46 +0100
Message-Id: <20240128201059.6259-3-wahrenst@gmx.net>
In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net>
References: <20240128201059.6259-1-wahrenst@gmx.net>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:rKY1ZPzsqiU=;x6UvKh/oCtolnBl8IPtzKpMzoJu
 0XtzR/eXHTLA7bk/ONfy1zL84PIvnpg7bSR3kxHIohnoXh5joLpx/hBvR0TqyLAfVyVW28/4A
 J/F/UWZIwvwuXypZVXUip+wyly/2ZQupVjcjq1k7ULjUbM4w6rzsHHKlid72yEUfN13ZfPsif
 c+p2wY3z6Dat2Fa8xUmexn+Jbrc6133UcLPYTM4AVZzJOfoLGfceNZwwRRy49F1xSDJjB5Kny
 m835jvDSf5sPl7sJCbYrvjfFiMOv3h1p8NWwEwm7ofIze/wlAvPS4T4kFXhwuWBqHQLa5p5PI
 6bO7xL7svKzVCbIShMAuvM2eymn4OEfz1/ts0ghgpj7AvJhNE7c7jim0a47tUr9mZwUgkHQ46
 kAotx6zQLzqaMsAf5CjcRK3j7ecLWOxSOg9uuy07rp8V1Y7/752ptKLwq13viZbbNY++zgryL
 3Isxlu24//mR2UWN0V12S5+WtkI4T7QYiKwfKaMBxQXpD9xrZPpRDpYM9/FXhjGVWWQXmCXHO
 lDEJ2/nVU8teTSKKNscKc7ROgTPvWCgmNnGztQIVJHI7FnjGAZ4QtqIz4jTt5/3eBJvGGCSZ+
 +0vx5Q2X4mLrJQh0NX/JhMr1Lt/650kOY6BV2l58GovHW4TD3xEr+W8MfnthagavvO94W5hXN
 ihAYbgR5IxZkIA4ZuplhkD+ea4fGLfoVOj8kLG4EyBxfQBSLanUQx7Ct8ntPQdVM/f6wT3T8e
 HzCOEBe/AIrS8z9AD+Qlz6dTQYpVugqO8vTrrWbWC0smMCQqTxVzZ6NxfyNDQahtBcDjmBxXx
 TL69+J61mNhld67uurJi8qjtTeT9A19qnoOZX0PyNjHP6EV0bjYzybfJ7+Y1DolbmAL/xMCrY
 NeWawaLU5X0iPrlha7xxU8cvaxllGkaj9GH075BNv3jPCP4yYgEK33p1Gwh4889hzOzot9dTN
 ojYiHA==

Directly storing the result of kthread_run within the private
driver data makes it harder to identify if the pointer has a
running thread or not. So better use a local variable for
the result check and we don't have to care about error pointer
in the rest of the code.

Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
=2D--
 drivers/net/ethernet/qualcomm/qca_spi.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/etherne=
t/qualcomm/qca_spi.c
index 77bab8bf5203..fe50c2dd7cc8 100644
=2D-- a/drivers/net/ethernet/qualcomm/qca_spi.c
+++ b/drivers/net/ethernet/qualcomm/qca_spi.c
@@ -687,6 +687,7 @@ static int
 qcaspi_netdev_open(struct net_device *dev)
 {
 	struct qcaspi *qca =3D netdev_priv(dev);
+	struct task_struct *thread;
 	int ret =3D 0;

 	if (!qca)
@@ -697,15 +698,17 @@ qcaspi_netdev_open(struct net_device *dev)
 	qca->sync =3D QCASPI_SYNC_UNKNOWN;
 	qcafrm_fsm_init_spi(&qca->frm_handle);

-	qca->spi_thread =3D kthread_run((void *)qcaspi_spi_thread,
-				      qca, "%s", dev->name);
+	thread =3D kthread_run((void *)qcaspi_spi_thread,
+			     qca, "%s", dev->name);

-	if (IS_ERR(qca->spi_thread)) {
+	if (IS_ERR(thread)) {
 		netdev_err(dev, "%s: unable to start kernel thread.\n",
 			   QCASPI_DRV_NAME);
-		return PTR_ERR(qca->spi_thread);
+		return PTR_ERR(thread);
 	}

+	qca->spi_thread =3D thread;
+
 	ret =3D request_irq(qca->spi_dev->irq, qcaspi_intr_handler, 0,
 			  dev->name, qca);
 	if (ret) {
=2D-
2.34.1