Received-SPF: pass (google.com: domain of linux-kernel+bounces-41934-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Stefan Wahren <wahrenst@gmx.net>
To: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Cc: Lino Sanfilippo <LinoSanfilippo@gmx.de>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Stefan Wahren <wahrenst@gmx.net>,
	Jacob Keller <jacob.e.keller@intel.com>
Subject: [PATCH V4 08/15 net-next] qca_spi: Introduce QCASPI_RX_MAX_FRAMES
Date: Sun, 28 Jan 2024 21:10:52 +0100
Message-Id: <20240128201059.6259-9-wahrenst@gmx.net>
In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net>
References: <20240128201059.6259-1-wahrenst@gmx.net>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:Xbs6vihAokg=;TwnCR9Wkj9Yf9wWnXU7JTQFfjuN
 j4lLumrIOJdvJ+UDLcQFSjoUwAULG0VuUfqo1qCiqlJxN223c/U4nATZUJEpvSsvDAowQI/IE
 tMux6eDwbIlnmt65anhHRuuXW+bbSKH4DxYZaf1c8nccAtFug6e3916Hogt7Q9C6+5uaJ7BOV
 +Lr4WEoDe4C9vSrCvk3n6mJxLlnXayaiOQc5HAEn2Y+iF0fsuN5UcsBNIs0rTxWfSFNZF4NPv
 QzFsllIFZpzmyG6/7LeDuCjuyQ8ZuxL8qzykHJzBnWVmGCnbzsruvApOJ8bkEyDqv8ukvuiVJ
 gxJut0S2i2QKp0Mk+KKHe7Nllj/eWMLM3CgMf8c5v0Am+I9hCinLGDUpvyAuwrYrG7/18KB56
 kc+LmjkBHWWhpVUPRFns3M6993kGPDAwFbNxYMwuQ6QOWcg2Sh3TflrXrGZ6/mwjZCNRcmB2V
 dcWxUkgG9tdfH1ucQMQ0e9kYXTrzxc7PkMcbet1ZmmehfRXzvU/7i5i1O6VUxAG2NmSF3Ko/u
 yyQwdvfIrOaN6J7kVbvk5gglnmXojj/wjMALLob9m0H2SqAA6vlmf8COchMFvk4DwbotLyM1w
 ED5OpaGW3csS3rx3JoW/VFv82Mv3Txb8IWs0Tl34X/0wnG3SrYnXe3Qf4ZfsooEluxYXGUXF6
 hydq5scQkB+ntcYq6HLZFqXC3iIiiNI4hKGVEAbqdPjFciphhraRn77xEG1S+LKEcQAolhicu
 +yw1eh94o05v70zGA8VkUiDZdVNMI/Ek6tqkxYssb4u+08bTdoqkw7E1Teup1vE56042JYESw
 Dxvv8uEPxk+GfB3D12iep02XDvZcER3wCWR/7vkCW9S9/LuvFx3MCVCarrEvRJ+VBAH/fHd5B
 vnKRiV2f6nvsRcmrbeg/29spD0cCzpF/qh0JjhY1up2XAr6igWOtwNPczbHBt4msdatq5ovLx
 0Vi20A==

Currently qca_spi reserves enough space for 4 complete Ethernet over SPI
frames in the receive buffer. Unfortunately this is hidden under a magic
number. So replace it with a more self explaining define.

Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
=2D--
 drivers/net/ethernet/qualcomm/qca_spi.c | 2 +-
 drivers/net/ethernet/qualcomm/qca_spi.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/etherne=
t/qualcomm/qca_spi.c
index f53438c4aea2..c0f6bd3d331a 100644
=2D-- a/drivers/net/ethernet/qualcomm/qca_spi.c
+++ b/drivers/net/ethernet/qualcomm/qca_spi.c
@@ -829,7 +829,7 @@ qcaspi_netdev_init(struct net_device *dev)
 	qca->burst_len =3D qcaspi_burst_len;
 	qca->spi_thread =3D NULL;
 	qca->buffer_size =3D (dev->mtu + VLAN_ETH_HLEN + QCAFRM_HEADER_LEN +
-		QCAFRM_FOOTER_LEN + 4) * 4;
+		QCAFRM_FOOTER_LEN + 4) * QCASPI_RX_MAX_FRAMES;

 	memset(&qca->stats, 0, sizeof(struct qcaspi_stats));

diff --git a/drivers/net/ethernet/qualcomm/qca_spi.h b/drivers/net/etherne=
t/qualcomm/qca_spi.h
index dcecb072b8eb..f735ad77402f 100644
=2D-- a/drivers/net/ethernet/qualcomm/qca_spi.h
+++ b/drivers/net/ethernet/qualcomm/qca_spi.h
@@ -41,6 +41,7 @@

 #define QCASPI_TX_RING_MAX_LEN 10
 #define QCASPI_TX_RING_MIN_LEN 2
+#define QCASPI_RX_MAX_FRAMES 4

 /* sync related constants */
 #define QCASPI_SYNC_UNKNOWN 0
=2D-
2.34.1