Received-SPF: pass (google.com: domain of linux-kernel+bounces-41937-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Stefan Wahren <wahrenst@gmx.net>
To: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Cc: Lino Sanfilippo <LinoSanfilippo@gmx.de>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Stefan Wahren <wahrenst@gmx.net>,
	Jacob Keller <jacob.e.keller@intel.com>
Subject: [PATCH V4 09/15 net-next] qca_spi: Improve calculation of RX buffer size
Date: Sun, 28 Jan 2024 21:10:53 +0100
Message-Id: <20240128201059.6259-10-wahrenst@gmx.net>
In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net>
References: <20240128201059.6259-1-wahrenst@gmx.net>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:CbkIpR0cq8k=;X2z0o+pYvxeEgaoaRyY+zRdtQyT
 apwhvG98UPrU9OylE7Vl9lVbBrAPx33/cNI38hNA87ZrJ9+BqNVn3WYGi8EFMgQ1VR+WHZ3Qa
 WRiB4p9iMbVsgIlWwMQuVwPVEBD/MMC9iUGgV9tqp/7xTUOYqMWgJ66Od6u9v2774hu2Ny8+N
 aAGl05kyOF04OiTU3JcR5qgeCJ4ErLRsEsKtHX+9aIZO4VhTO0b/vGKDrdWpPmD8yUkLfsYJk
 v6tRvU8YX2oeMtq9X7d8XzCbheIUzZliJFjT9Facty8u+GRBNNKRpBihW3ZO2BMUmgN9nOCje
 gZsa6L+qT5GsGhd4rgR5GQxbZlCFoScuqqAUIbYJ3EqmQuwFg/nqCl+mGkfVHf/6lCsUNnoVl
 BvLMppVYZVq0NovnvT4NKMMeWT8Gq2SbfcHrrATWfmzhM1WWzWrDL6XbUt+PjRWIzYkxwtVbz
 w4jA0yJ8DIqPrI+gT7Za2jaX4x+15act1PosMFc8VmICiH9Oun3hT6AKg+d0hXIduFH4/VjFF
 NQ4l9YwfZWxKi5G6XNeV2EihsAHZq4uBa1rBzY2eFCAKY4OgHA6RtMUrGwUcBLemdmS9Jvzak
 Qs6pmtoc8Hcsm1FNiB2XB//ZLvjQVvPLCargZNMq71xBm81D4qpqaVTzt/GAe84yJL7RQmPnL
 BDOq2wvzvxOHdpocy7eGPOSSAvvATGeb8v5zSieExbQExAkPKyCOKWklKTma5EeyELCzNd56n
 fBiZvPhE6Tm3s6LMSpvzRT0zvmtQtEegP8Fa76y2VIDeDzl2xq2qiURbVkNQzdvIS+uJrlaiv
 o7Wd5e4zz4iNnui2F1WF+ON2iuo2dg39OTuOVVaDihwAGwBo4H35WdN91q0iJJ38WDYyBpmBp
 VQOjYcwtuHgLekBUpOa35YFMjBS1itrCeVmDSzK4S2iVHXz9cXSRt/IcBrhXf3UuhkK6UU7Lq
 q4Hnsw==

There are two points with the calculation of RX buffer size which are
not optimal:
1. dev->mtu is a mutual parameter and it's currently initialized with
   QCAFRM_MAX_MTU. But for RX buffer size calculation we always need the
   maximum possible MTU. So better use the define directly.
2. This magic number 4 represent the hardware generated frame length
   which is specific to SPI. We better replace this with the suitable
   define.

There is no functional change.

Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
=2D--
 drivers/net/ethernet/qualcomm/qca_spi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/etherne=
t/qualcomm/qca_spi.c
index c0f6bd3d331a..b35fabcd488b 100644
=2D-- a/drivers/net/ethernet/qualcomm/qca_spi.c
+++ b/drivers/net/ethernet/qualcomm/qca_spi.c
@@ -828,8 +828,8 @@ qcaspi_netdev_init(struct net_device *dev)
 	qca->clkspeed =3D qcaspi_clkspeed;
 	qca->burst_len =3D qcaspi_burst_len;
 	qca->spi_thread =3D NULL;
-	qca->buffer_size =3D (dev->mtu + VLAN_ETH_HLEN + QCAFRM_HEADER_LEN +
-		QCAFRM_FOOTER_LEN + 4) * QCASPI_RX_MAX_FRAMES;
+	qca->buffer_size =3D (QCAFRM_MAX_MTU + VLAN_ETH_HLEN + QCAFRM_HEADER_LEN=
 +
+		QCAFRM_FOOTER_LEN + QCASPI_HW_PKT_LEN) * QCASPI_RX_MAX_FRAMES;

 	memset(&qca->stats, 0, sizeof(struct qcaspi_stats));

=2D-
2.34.1