Received-SPF: pass (google.com: domain of linux-kernel+bounces-41939-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Stefan Wahren <wahrenst@gmx.net>
To: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Cc: Lino Sanfilippo <LinoSanfilippo@gmx.de>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Stefan Wahren <wahrenst@gmx.net>,
	Jacob Keller <jacob.e.keller@intel.com>
Subject: [PATCH V4 10/15 net-next] qca_spi: Log expected signature in error case
Date: Sun, 28 Jan 2024 21:10:54 +0100
Message-Id: <20240128201059.6259-11-wahrenst@gmx.net>
In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net>
References: <20240128201059.6259-1-wahrenst@gmx.net>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:R9CMuJyLgoQ=;34SKGDBlBplOqnPuEy9NEznJpAy
 PD2abgE73JEFTVPZj58zRHAgGKp9cY8X6zkRmYvoXx566PlgCH4Yi9w6moj46hxDyTxe4c/Nt
 qR9NisDCwllxtR76/dYQs12hVMIcc3FpKq1r/BS4NOZa13EfHortGf5RZpNk4pwnheZl6+W5r
 15Gxb8EPZB7TwTI3auh5+SjfEeYWLCqzo4KgMjjrfeTqVp3rdJeL4WeVTckdgnq+DdvFv1kSl
 qSWREEeRNQvXyn/57Mj4gsdw5Na/2OIbKydi9aDMSpCdBBjLxuIHGEVTiOkMVK1xBRCfItFLV
 B3a+dOa0YXUH3bq+o1cxuCE9kkufiEyF7JhLFPPo91RUnl+lNS4abwwOqPiGSXuOyfXvecMla
 5aAZjWc8eyFigywhRkqRNOa2q7HGibMHpRWPaLFoCWgu1vjT8dIuV8ckklCVjU2cUfHNNOT/+
 Fj3+BS0J06yQa0f6cxSpccH20bbzcxeAl4Uwdk9e5oBJlh/RzCLh1QsgvLBm47m1k1/he2aHH
 hnbKJ90175CecMwdIFjVJKRFoK8addabPRiThYdFxAmXawOm0PoneIFhfKXhWJra6jOPbxVEx
 YI/RKz9C42OgFMlPq6QYiCW7+9j14QXleMHJmQuIVvrVmQ8xQ79TsNmmznSsf1LDKThgETLgg
 Tl9BVbfa5MQtz9/s3/NLR6kR388llSM06+Uchc/QT4eKeRmNplEIoXT2E7mOCPva1ZfHPYyTo
 Ovm2Xlf9qucKrSl45FLFpcwOTgJQzV2fhzdVqn6MC0FQvzSB/EliuRpYS/OoxGqxW08pHyHiM
 3H6GgV4H9tv+xu/9x41JkQJUjS8TWW6CpoMOgsY5yI11Kb/xlOzzsvtdIOhQdKX1CURk+yOMA
 WE0Y1aBiHRo92pKxAakGqXzdaDCFeLmITWM82uCjT3pgunflGAZ7DYI4YvaUAFHZQOs14A4Un
 0KYcyOdP1CLxrBMKqjX9BdC+xfo=

Most of the users doesn't know the expected signature of the QCA700x.
So provide it within the error message. Btw use lowercase for hex as
in the rest of the driver.

Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
=2D--
 drivers/net/ethernet/qualcomm/qca_spi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/etherne=
t/qualcomm/qca_spi.c
index b35fabcd488b..d2d68c20b32c 100644
=2D-- a/drivers/net/ethernet/qualcomm/qca_spi.c
+++ b/drivers/net/ethernet/qualcomm/qca_spi.c
@@ -1006,8 +1006,8 @@ qca_spi_probe(struct spi_device *spi)
 		qcaspi_read_register(qca, SPI_REG_SIGNATURE, &signature);

 		if (signature !=3D QCASPI_GOOD_SIGNATURE) {
-			dev_err(&spi->dev, "Invalid signature (0x%04X)\n",
-				signature);
+			dev_err(&spi->dev, "Invalid signature (expected 0x%04x, read 0x%04x)\n=
",
+				QCASPI_GOOD_SIGNATURE, signature);
 			free_netdev(qcaspi_devs);
 			return -EFAULT;
 		}
=2D-
2.34.1