Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp35719rdb; Sun, 28 Jan 2024 12:16:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGZkBS6h5YQO/vBAq78FHGGC4OC4jBUZnNVSp0KBzzvZ/4tcZ5PlXRPeqnyjNDs1YjDKYyy X-Received: by 2002:a05:6808:198b:b0:3be:493d:db5f with SMTP id bj11-20020a056808198b00b003be493ddb5fmr1774331oib.23.1706472980470; Sun, 28 Jan 2024 12:16:20 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706472980; cv=pass; d=google.com; s=arc-20160816; b=ZXoIwgr4cGIEK+KnQaiABc/mY1kUDVWxBgRuEtf2KxS2hcaqxksiiueJzUEwom/bW5 ecegVrtGPgN8ivI9DUyM/s7JN9ojn+fbSeNL+theMNeu0KrB7L1QyH7NwBWjXIk/xhQD LQzGCax92gI24Opm9ulKjVJ4ml6dJHF9g5r1C2EpjdsUPJKg99GzIfjKWTljUA+KBMa2 SXao5Bpoprks9FRjqPsPX9ICrxznbozj0YuSZoXMIxSbHonKJumERZAWNX68dDiB1J2v MvstfrkJ+ENv9VQF2lBpr5XeUmam4rkrxP76wTNW6NDpgNF/bsolJ+rZd3spHgl/MZUo mVew== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=kx8xOA8cpl4X9lppIusxnVdoG6wvQINRU0nJ/t2l8GI=; fh=4TbGRyu74MVGBD1ojLEXm/qR6lrg8ldwqoVM6Mhhpg8=; b=LGYk4M/bVIhIIykjD6U4enuv8/9q7pryoxU4uvRVFk5/1/Wtaest7V8dgKRp+duPVn i/GM9RslcJrBub2/7s2d8K1hbfOacp5cgiYEowqh9mFg4R/Z5695wnWwGMpr8Y6Thwh4 Ey/o3txUGiJKfmZkTnMU7GMnHVEADCUvrvXeYmeczFUvoHkjHOBayih9aB8T+gv0ghQt MZn4yLDy7qq7uF+H4l+7JUn6kPkpjormOhNo/ewPuGQPL+tsB/19jBIkUnvv8VZ8P8i1 pe8pGewt+3+eI0w2JorwzmS090rq7ydN6eL0RmoC68aaXCn2f4lj91e1puElnhLCPp5a EgtA== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-41945-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41945-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id n27-20020a056a000d5b00b006d9b4294509si4500844pfv.200.2024.01.28.12.16.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 12:16:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-41945-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-41945-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41945-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1B32928337A for ; Sun, 28 Jan 2024 20:16:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C76B23C47B; Sun, 28 Jan 2024 20:12:58 +0000 (UTC) Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A73B33CFC; Sun, 28 Jan 2024 20:12:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472778; cv=none; b=hL42yziUCntn+SrqSqu3ysAuLyjva4pFYQ0DfLdq8GHt+9LLeiXJoJZ19UIIBowMcoM0MHlF55Hc4zw4SpV5dLlgfG+ekl9WIstpsUvhpYVcwc0S6/cARwGrtck+jtvGtKlpKzQNgRiSPNY91ByWDvMSzDw/umVCo84BEqxzYy0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472778; c=relaxed/simple; bh=eLB+vP2BqWigZLoa+gqJwPItZJUPUQPTdY+BITXJySA=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=NSpr0r7xIm+p58/+1+w1RVwa7YvoPFTjbDvr9pxAmbf0DPDbMCXUlwM6vOrK1D8Taq9aui8k5TrkbcA5E3kHAQ8Fgdvd14F7JxFrluQq02qwy/KGfO++4lGrdvOg0DJESlPJrQ+qgCfMmfD48hR6rdigGxgAZIf5m2AyNPRORF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.105] (178.176.74.225) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Sun, 28 Jan 2024 23:12:44 +0300 Subject: Re: [PATCH net-next v4 13/15] net: ravb: Set config mode in ndo_open and reset mode in ndo_close To: Claudiu , , , , , , , CC: , , , Claudiu Beznea References: <20240123125829.3970325-1-claudiu.beznea.uj@bp.renesas.com> <20240123125829.3970325-14-claudiu.beznea.uj@bp.renesas.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Sun, 28 Jan 2024 23:12:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240123125829.3970325-14-claudiu.beznea.uj@bp.renesas.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 01/28/2024 19:59:59 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 182981 [Jan 28 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.74.225 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.74.225 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;omp.ru:7.1.1;127.0.0.199:7.1.2;178.176.74.225:7.7.3,7.4.1,7.1.2 X-KSE-AntiSpam-Info: {cloud_iprep_silent} X-KSE-AntiSpam-Info: ApMailHostAddress: 178.176.74.225 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 01/28/2024 20:05:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 1/28/2024 7:00:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 1/23/24 3:58 PM, Claudiu wrote: > From: Claudiu Beznea > > As some IP variants switch to reset mode (and thus registers content is The register contents? > lost) when setting clocks (due to module standby functionality) to be able > to implement runtime PM and save more power, set the IP's operating mode to > reset at the end of the probe. Along with it, in the ndo_open API the IP > will be switched to configuration, then operation mode. In the ndo_close > API, the IP will be switched back to reset mode. This allows implementing > runtime PM and, along with it, save more power when the IP is not used. > > Signed-off-by: Claudiu Beznea Reviewed-by: Sergey Shtylyov [...] MBR, Sergey