Received-SPF: pass (google.com: domain of linux-kernel+bounces-42005-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 29 Jan 2024 00:58:56 +0200
From: Abel Vesa <abel.vesa@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sibi Sankar <quic_sibis@quicinc.com>,
	Rajendra Nayak <quic_rjendra@quicinc.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 00/11] arm64: dts: qcom: Add more support to X1E80100
 base dtsi, CRD and QCP boards
Message-ID: <ZbbcMFXdL/kmJ61v@linaro.org>
References: <20240126-x1e80100-dts-missing-nodes-v5-0-3bb716fb2af9@linaro.org>
 <ui5a4sr2wa4nta6uvvlejtwuus7uuj54iirddretysd6hcgv3k@iabyr65abxhi>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ui5a4sr2wa4nta6uvvlejtwuus7uuj54iirddretysd6hcgv3k@iabyr65abxhi>

On 24-01-27 20:36:33, Bjorn Andersson wrote:
> On Fri, Jan 26, 2024 at 12:00:11PM +0200, Abel Vesa wrote:
> > This patchset adds every node necessary for both the CRD and QCP to boot
> > with PCIe, USB and embedded DisplayPort.
> > 
> > This patchset depends on the Disp CC and TCSR CC bindings.
> 
> I'm guessing you're referring to the patches from December, which has
> review feedback from your colleagues?
> 
> Please respin the clock series.

Was trying to figure out the GCC_DISP_AHB_CLK pm_clk_add()-ed to the
dispcc. But as discussed off-list, GCC_DISP_XO_CLK falls into same
category and I'm not sure what it is tied to (yet).

Anyway, that should be a separate patchset as it should fix SM8550 and
SM8650 as well.

Meanwhile, here are the clock controllers:
https://lore.kernel.org/r/20240129-x1e80100-clock-controllers-v3-0-d96dacfed104@linaro.org

> 
> Thanks,
> Bjorn
> 
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> > Changes in v5:
> > - Added Konrad's R-b tags to patches 1 through 4 and A-b tag to patch 11
> > - Changed the clock of the usb2 HS PHY to TCSR_USB2_2_CLKREF_EN, the USB1
> >   SSx HS PHY seem to be sharing the TCSR_USB2_1_CLKREF_EN
> > - Prefixed DISP_CC_MDSS_CORE_* gdscs with MDSS_* to be more in line with
> >   SM8[56]50 platforms.
> > - Added "cpu-cfg" icc path to the mdss node.
> > - Marked all USB1 SS[1-3] controllers as dma coherent.
> > - Re-worded the adding TCSR node commit message by just dropping the
> >   "halt" word as the halt registers are not part of this region. The
> >   TCSR offers more than just a clock controller and therefore called it
> >   generically "TCSR register space".
> > - Link to v4: https://lore.kernel.org/r/20240123-x1e80100-dts-missing-nodes-v4-0-072dc2f5c153@linaro.org
> > 
> > Changes in v4:
> > - After a discussion off-list, it was suggested by Bjorn to split in separate patches.
> > - Addressed all of Konrad's comments, except of the clock-names one for the mdss,
> >   which there is nothing to be done about as all non-v5 do clk_bulk_get_all.
> > - Added more support to QCP, to be more aligned with CRD (except touchscreen
> >   and keyboard)
> > - Added a patch to fix some LDOs supplies on QCP
> > - Link to v3: https://lore.kernel.org/r/20231215-x1e80100-dts-missing-nodes-v3-0-c4e8d186adf2@linaro.org
> > 
> > Changes in v3:
> > - Reword the commit messages
> > - Link to v2: https://lore.kernel.org/r/20231215-x1e80100-dts-missing-nodes-v2-0-5a6efc04d00c@linaro.org
> > 
> > Changes in v2:
> > - Reword both commits to make it more clear nodes that are being added
> > - Dropped comments from interrupt maps from pcie nodes
> > - Replace all 0x0 with 0 in all reg properties
> > - Moved on separate lines reg, reset and clock names
> > - Dropped the sram and cpucp nodes
> > - Dropped pmic glink node
> > - Reordered all new clock controller nodes based on address
> > - Dropped unnecessary indent from touchpad and keyboard TLMM nodes
> > - Link to v1: https://lore.kernel.org/r/20231212-x1e80100-dts-missing-nodes-v1-0-1472efec2b08@linaro.org
> > 
> > ---
> > Abel Vesa (7):
> >       arm64: dts: qcom: x1e80100: Add TCSR node
> >       arm64: dts: qcom: x1e80100: Add USB nodes
> >       arm64: dts: qcom: x1e80100: Add PCIe nodes
> >       arm64: dts: qcom: x1e80100: Add display nodes
> >       arm64: dts: qcom: x1e80100-crd: Enable more support
> >       arm64: dts: qcom: x1e80100-qcp: Enable more support
> >       arm64: dts: qcom: x1e80100-qcp: Fix supplies for LDOs 3E and 2J
> > 
> > Sibi Sankar (4):
> >       arm64: dts: qcom: x1e80100: Add IPCC node
> >       arm64: dts: qcom: x1e80100: Add SMP2P nodes
> >       arm64: dts: qcom: x1e80100: Add QMP AOSS node
> >       arm64: dts: qcom: x1e80100: Add ADSP/CDSP remoteproc nodes
> > 
> >  arch/arm64/boot/dts/qcom/x1e80100-crd.dts |  222 +++++
> >  arch/arm64/boot/dts/qcom/x1e80100-qcp.dts |  175 +++-
> >  arch/arm64/boot/dts/qcom/x1e80100.dtsi    | 1368 ++++++++++++++++++++++++++++-
> >  3 files changed, 1758 insertions(+), 7 deletions(-)
> > ---
> > base-commit: 853dab01a34378871b37a5e6a800e97a997fe16c
> > change-id: 20231201-x1e80100-dts-missing-nodes-a09f1ed99999
> > 
> > Best regards,
> > -- 
> > Abel Vesa <abel.vesa@linaro.org>
> >