Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp187587rdb; Sun, 28 Jan 2024 21:06:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/FIdrV7ZROgdM9z1OZewYsLO/oAobv/Qpr1spjlnMcyu+8IsqcIp1kbYuZuSq5tFn+azE X-Received: by 2002:a05:6a00:d42:b0:6dd:88a9:2d0e with SMTP id n2-20020a056a000d4200b006dd88a92d0emr2088494pfv.9.1706504800635; Sun, 28 Jan 2024 21:06:40 -0800 (PST) Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s29-20020a63925d000000b005ce0be7966fsi5153456pgn.898.2024.01.28.21.06.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 21:06:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-42175-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="kCT7/Stc"; arc=fail (signature failed); spf=pass (google.com: domain of linux-kernel+bounces-42175-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42175-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4A8DC2826CF for ; Mon, 29 Jan 2024 05:06:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4064E446CE; Mon, 29 Jan 2024 05:06:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="kCT7/Stc" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45CAC14F98; Mon, 29 Jan 2024 05:06:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.14 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706504781; cv=fail; b=KEtAGKuW6r96IVuqNRf1NNdlKE1UOotI5MAbyl2qRFSVCpzTOsnPFoSCFVZA1ztfg6aecpfu+cmZsvs2NePwIOIuOdDAqxQtKT0CJA5msea2NCmjRTKiDp/Y1sRTEJcNq0H2UxV/Qb8zgVK+8QvoYunnJC1aXSJcJULIh5aMC4g= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706504781; c=relaxed/simple; bh=uMffuci8wgBY05Infchs8EghH7njWqFLtfc8uJEEk3k=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=kSxTjkAN0D3K4A6zKZbf3piz6xp8GtM5s7bgupylh/rOqPfu1OnbZtITn6GPa7Gtl0oDu7r8sJKZ66MaOqJEZemJeqmGFzv6Xvr5MBxrYCKom5fk7jX/jYd0Ib8QVx13vxMdf0nmHcDK6frkJ8jKek6Ml1d7bKQGrZCOYllbX9w= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=kCT7/Stc; arc=fail smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706504780; x=1738040780; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uMffuci8wgBY05Infchs8EghH7njWqFLtfc8uJEEk3k=; b=kCT7/StcdSMtfwHh1DNSNJfHgMzouA0WN0mlywBpIN1oW7qhoNeZy3sl AZEMpHVOn9ag35XIR2y0mqo0h2C3R8Ak8nD1UJV/2ZX5oyQc7IoLPZxRr SPp4c57SO/m+SIIhYvY8Waf873VdRtcmNV1S2Yw2noT61rqDH21X5DKwC V7EcCWtTCQH46zLgggnFB7JcuUqXEpZQNVfvDL0eYDFCztaziuzjQ+t3M 1KNf+LDGj1PV849Uoi92Gi/FnJdGqvLUoTJD2vrtIx4zp9bNBZdsjusJ0 uBYj2RcuouCmYtzwXq7WiKfptrRX8tK3hOpuTgpHKTTB10DW2iA3NlMPB Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10967"; a="2740965" X-IronPort-AV: E=Sophos;i="6.05,226,1701158400"; d="scan'208";a="2740965" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2024 21:06:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10967"; a="906967680" X-IronPort-AV: E=Sophos;i="6.05,226,1701158400"; d="scan'208";a="906967680" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Jan 2024 21:06:17 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 28 Jan 2024 21:06:16 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 28 Jan 2024 21:06:16 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 28 Jan 2024 21:06:16 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 28 Jan 2024 21:06:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GezWRJJLQT1++xC/NDTdPQDUGPVqK164Ztm9xCT7NR9xi4lFEB6N2UGJZ5cGwD/QWTdq3eFwv9Nwey9NQJ2buxp2yEqABk/0wVhlCtnEjiLezvHAeVb36tiUUM6ds4eRtSmsutyGl3HMV0zEyHf3wBkRiHrkSPm5UogVeJN/y/3tac9lJcjtf92eXbIuBIZ1hLWTFfGDbGuCvqWZ2U8pdo2aqr7SdHIAaqF+NSiNskqr/Z1chFjwFgL58cSj6dbJKhAyS4rqb5/AlwJayv+Jm44sElUgeAKW71yUjzdJgxt3lHAbPzGk1mfI7L+6pF7YQDyMFjdbBbmqmX9dCCPs7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4A47QxsIEhWCdheUFe6kI3rXuvBsULfWHYd7sYx2IEk=; b=cU/vmroCYplq136Pi/ImCuv2thsbiIJejsk7UcbMa52xYR7MD6DI2T7jRegEh0gHb/fxDCKxbJiJPoVbwy5b9abOTY6LkqlcfZvhcvH5FtV5GHicwn+YCbylSXBD2nzu9nyQ+fvudE5ZQDEVlgmKZooVh2mh5I3XuLcwEOszIthofxQuGVLrgco0gO7/hEYmoc8Q03h63yh7od1rCCLxOJmh5tNDeL+uGo8cCKTgKTRK1vJGh3UPtOMc9/P7t6mxaXyJCNktvJuA/75XoDI8+PAe633fOTE7X4RXnbHN8AOJYf/QBdYgXGQqc29+b6yQ+5FfEVRqUkF860NGQvu4bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CYYPR11MB8429.namprd11.prod.outlook.com (2603:10b6:930:c2::15) by SJ2PR11MB8371.namprd11.prod.outlook.com (2603:10b6:a03:543::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.32; Mon, 29 Jan 2024 05:06:14 +0000 Received: from CYYPR11MB8429.namprd11.prod.outlook.com ([fe80::5fa2:8779:8bd1:9bda]) by CYYPR11MB8429.namprd11.prod.outlook.com ([fe80::5fa2:8779:8bd1:9bda%3]) with mapi id 15.20.7228.027; Mon, 29 Jan 2024 05:06:14 +0000 From: "Pucha, HimasekharX Reddy" To: Christophe JAILLET , "Brandeburg, Jesse" , "Nguyen, Anthony L" , "David S. Miller" , "Eric Dumazet" , Jakub Kicinski , Paolo Abeni , Jeff Kirsher , "Rustad, Mark D" CC: "intel-wired-lan@lists.osuosl.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: RE: [Intel-wired-lan] [PATCH] ixgbe: Fix an error handling path in ixgbe_read_iosf_sb_reg_x550() Thread-Topic: [Intel-wired-lan] [PATCH] ixgbe: Fix an error handling path in ixgbe_read_iosf_sb_reg_x550() Thread-Index: AQHaS8bQSo7t9TWYS0+rImRNEw+cIbDwSeEw Date: Mon, 29 Jan 2024 05:06:14 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CYYPR11MB8429:EE_|SJ2PR11MB8371:EE_ x-ms-office365-filtering-correlation-id: dc741737-ea5b-4a59-bc73-08dc2088049c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: D6+3lDOP+SZ5FCnrc3pAd0UlWh0fGlJcok6+cKs45sOthSD+ixNmhGRQuU4hpMA0391OmWrW/4G2Orxpa2Yarjif9Xnr7JyEDn9GCDGL4HrNUsJ+OOjr84PwW7ZuycqZ0LdyGSyPoUmFgsKBVZ/Nbia6gcpNSNUVf0t3yh/hHR0IV1qw43VCMGF4J6Ri4P16NKiVhlPatBgG4n1enG+kLipzXUYsnNdl/2VpQ0H9kP+kwWNiqxVunmIFI+o6HyGiQP1W3dWB21LC9yJKCjQagZnOCDETV3hurbRSr5a5YPWnD0cpfTDf5IS4BSGph00e20Gwp0qOVM1X+EH6cu1tfRItHs5jOOp3CmmogoXviUQcX8gqwLwNd8AonzmoL3D4CMTVOzDEu1l4RaQed1UKruyQOG7OzCPQ4cdOoV0iuUlYOlY7iXbL20sIFRunzWvXhTtJUafmlZmkHNuIOnQLkFkQ0xu5hILP3wCu3RAJuOvkJhqLXRzCrVGSoU2ZkoJ7ExNBgNKQnt5W8KuwHSOrOCq8n1US0zZ/AAnlzOqDa05EZqSUChoUj9ISjqxScrGAHEeY/HjdWApM2CsjQ/6Y3lC9UvEow773aBBNN8pQSpViIY7U1paecxnkjkN+9k7M x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CYYPR11MB8429.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(136003)(346002)(396003)(376002)(366004)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(66446008)(52536014)(8936002)(8676002)(4326008)(33656002)(2906002)(5660300002)(86362001)(110136005)(66556008)(76116006)(66946007)(66476007)(316002)(54906003)(6636002)(38070700009)(64756008)(38100700002)(122000001)(82960400001)(53546011)(7696005)(6506007)(9686003)(478600001)(83380400001)(71200400001)(26005)(41300700001)(921011)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1dmHVfuerZijWtk+mvHG2sb+E+KHGRPg/I2jA1Ob/7KxmZ800E4UVZpoJCKL?= =?us-ascii?Q?SKHSwkHkXwxrzRCaXdIW08xeejz5/0b7IeKmwqUDTR7Zj5c8mOXoiyhmam43?= =?us-ascii?Q?3JcOj0z5XBuj3HYUAR0f+kDcIOVtIBrk7Alsnh96tolg8cu5xqJSJ8JStXsa?= =?us-ascii?Q?XFesVwiUexdssb6gmAskMZ4UpOCislBk197gZtXpsBKMYRNPukyH49N9l+7W?= =?us-ascii?Q?LRtXAL7+ulfo2ig5DdjIVz9+fVua4aHZKKEuLOHLBQeCHoq4f5UmUUu3RuL1?= =?us-ascii?Q?CXZFT3EbqXAIv5e4YcegIeWlKFv0rEP2pQo3PRP+5g2gXmw3dychfVd61A9G?= =?us-ascii?Q?Z3hlV9dGDUKE0MxssqR6Gt1d15QrGpfKV7EVxtO0GAZffxzi74EBLCZAAAhI?= =?us-ascii?Q?KHFkbemQmIgwQSp7ButVc8pf+JAzssl+iH7YmiSFtuA+WoOizQJOCR1aVjsP?= =?us-ascii?Q?7J6JfFV3TrocaVGC00K9e17EZP+P4rmRPhi6EZg4v6V5fEhkahb/1bPPVxWl?= =?us-ascii?Q?xbNgrWKE2SY1PgsvF2BqHCcc9wQ/cu9yLP1R0LAnkImH4WUAgNq54jy6YzVn?= =?us-ascii?Q?GPHMpiFnGR3hqLDNnhB98QgxWqyHqUjyggq+gSEkSAKw8SmQ6pWiiB3aKQa1?= =?us-ascii?Q?KT/VatjuUsUBs2Dp8ewz3DsmzWRq6dRMVIePoQw/VkNQ5x6ZLdcZqeGOqHJF?= =?us-ascii?Q?3GnHvGcwmaAqvJmy4kh2JDVE4eVUG3qiq0Vlvs0erI9uFMmFNzajwjL/ax7p?= =?us-ascii?Q?Bdl887E9qqHv4Z4vhD5OBuXd0LR/BZVdrN8bVGYihfYTyfYIC8/2/vAZAm/M?= =?us-ascii?Q?ID918deqo7bW+wPaw+vrSKzF9NZkBLGlJXTv1ONXynrqVAg9XonVdTsDY+Kf?= =?us-ascii?Q?aNzIx7Z3JWQ9gELAbZjSVITzPj9f4cKbjz6s9YYLctSPZHqdWQCaeV7Knkq1?= =?us-ascii?Q?mlEMxsHe6VMWFY62cR/HIOzznn7mdMplQLTepQc7/2onpZqT9ybT47uAd33w?= =?us-ascii?Q?FXTwUB2EyPPEbQ8zBIwdWPCmjtQu6SDGYIuHDwAqv5jGCtWRP/MIC27gorg1?= =?us-ascii?Q?Q7uPs5raX+K2XFzswLtpA4CtRxOXtGu2hK5Yrr+KMLrwVt4OHkAGVpx7Lyix?= =?us-ascii?Q?0o30PMsYRXSgG9bi3zS9H6KATwduoeTRgQtJeR5pcvYFA3YBSVEiZf7KclVM?= =?us-ascii?Q?VSyy/qJDuBd96ES7Wua2ZIiB+GpBJ+XK4r8UxqBXGuDOB5pZMUhoZl/bHg5q?= =?us-ascii?Q?KIerUI2iYwWLUb7A15gjzcaTDX4YZMuNB1/9JgMg/o33Kxba9YLEva4TgS6j?= =?us-ascii?Q?2gGPFH2CX6bY+efmt4WDFLxIV3AfoIX8EoBdHD8AP9VNJ2yIucMgJe0SxTpi?= =?us-ascii?Q?TjRnKpNJI0MAOBijdQJcTfZDxs4hc124726X0dmvHbWSwOmji4i/BaCXsWJ/?= =?us-ascii?Q?ojpXd9h0I5NSF0T5Vp8yMagzvMomrMipYpOQCVcMQLcoLoRfHTzUS2V2Yjtf?= =?us-ascii?Q?ja8dt/lbBJ4m8YAx6XgyFaqnjKyPAIY60YE75fMpfihnwJ0v9K/ayVnCCYk0?= =?us-ascii?Q?De92CP/zdSmkiImMFZ4Fo6sVmwgs6hB5Wu864FbFeuONMJW6kTUXh3lSRmqE?= =?us-ascii?Q?LQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CYYPR11MB8429.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc741737-ea5b-4a59-bc73-08dc2088049c X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2024 05:06:14.4334 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VaSKofGOCKI064snmA5KJMhOok5R1uP8cKAcNYjvrpd1OUVVyznvXUsV0ZixKeahzLsU4HRpEygXkFvH0BB8o9W3iE58OpkHS9IxJzWKrBGBDLyj/AdK3EfVofpvM/cu X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8371 X-OriginatorOrg: intel.com > -----Original Message----- > From: Intel-wired-lan On Behalf Of C= hristophe JAILLET > Sent: Saturday, January 20, 2024 10:56 PM > To: Brandeburg, Jesse ; Nguyen, Anthony L ; David S. Miller ; Eric Duma= zet ; Jakub Kicinski ; Paolo Abeni ; Jeff Kirsher ; Rustad, Mark= D > Cc: Christophe JAILLET ; intel-wired-lan@l= ists.osuosl.org; kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.= org; netdev@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH] ixgbe: Fix an error handling path in i= xgbe_read_iosf_sb_reg_x550() > > All error handling paths, except this one, go to 'out' where > release_swfw_sync() is called. > This call balances the acquire_swfw_sync() call done at the beginning of > the function. > > Branch to the error handling path in order to correctly release some > resources in case of error. > > Fixes: ae14a1d8e104 ("ixgbe: Fix IOSF SB access issues") > Signed-off-by: Christophe JAILLET > --- > This patch is speculative, review with care. > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Tested-by: Pucha Himasekhar Reddy (A Co= ntingent worker at Intel)