Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp197433rdb; Sun, 28 Jan 2024 21:44:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IF1DwwWClxGMYWCdFd/hexOiIBWbhcPAux/ndp6S/UmvAOzbpg/kL6V+2N7PluE5vVLV2jz X-Received: by 2002:a05:6358:98a4:b0:176:6270:8cb6 with SMTP id q36-20020a05635898a400b0017662708cb6mr5130644rwa.25.1706507067580; Sun, 28 Jan 2024 21:44:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706507067; cv=pass; d=google.com; s=arc-20160816; b=GGiMXEW7AyDALkexynofQ3vgn5ZcsYgcqW+28QR26/Q/8IPxjxa+L0pbOyHKUO6Cs9 FxwGZ8DrNV64uNfBE8ztLwSEwXaWSWJELDMj/1JNBj3FBeNqmKfKdwF5/yEUURxHrEh/ GraF5trUPv4eCDsn9D9q5Ho0u76P1E8ICUWJT8czLaCJXC/aIr7Hi6WH0dCZdIj9Jobf hoyUtqWrRxBxt97HZ8ciwzCFfVCsnm1Eml2he2yQrN49LIIx/3ctSsYb89y0HyOPBkEN B31w6i85mTqB7QFBh6tg3Wrmkqqt1tMayPFq5T63SFqWFG6CyDSo9fEAHwc2Q9vk7fuw aCUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=5P19J4UsCEy395Sq3OX4ZVElGZFdAvopFeOiSHWhQEY=; fh=mBtSZ1LF7HAhcAjcl4/cs2wHfMEYLQ0er0IoyQEpYTQ=; b=VeABQX7D+JKuJqOUezJVs1fycXjlKo5Xx2J6LBgTtJ2mr/fenMY+m0F7SkpSAoSYni u5YcYx+qQlrbT0hXlD/AH2dJul3bEYUjgSz1/SJfjr5hNJYOR1ZycNg2q35E/1b4FHIB 55JYVczT+8OiZyWpHxG2hrzYZT8GABisiCcNlyqQvvBecf5Y230z8vU69sY1GWmtOO3+ UD8Qc24c8nyiUiFiy6JSaIpbocRHLxz/i0KMkbFJvggjWs7qFlcIQn3HwyeIJWFZxZ1B HkFyFL0ESzVB91ERXAMr1qXBRKeeLCuCtiru6ydMJKCW9zMQZnO/cGAhvIYC5T1ozbLH 24kA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=dRar5eJu; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-kernel+bounces-42194-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42194-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id o133-20020a62cd8b000000b006ddcebda2d2si5065107pfg.239.2024.01.28.21.44.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 21:44:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-42194-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=dRar5eJu; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-kernel+bounces-42194-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42194-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DBDB7283F50 for ; Mon, 29 Jan 2024 05:44:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1A33545BE8; Mon, 29 Jan 2024 05:44:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="dRar5eJu" Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0F17446CA; Mon, 29 Jan 2024 05:44:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706507056; cv=none; b=svfztWrDPw8oJOshsa4mJLK5Lqrrfe3MfunQ9/nxTJ14lQjOvQst8YD3s3ka6E0zIxUGGnnckSGzTTOjvqlaHaYQPY23cO9+d0vfYbfOcFfYdK1Vxrvx4FCeBIqgVLc+MW1I+Ggm0jPIY0EcZpDLdTxi8wrH86U/sZxYdIQ2enc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706507056; c=relaxed/simple; bh=pyJVcpc0mV/wy4nwItJ7qfaDl9SI0Rs/Nxj67sqOE34=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=lUZ0askajjPMUtBw9mOFqXLlkeWjbEK7ECtXR4lMAR1+u/4Mpyie5fHt2txqSltuYU7uHLMyVrWuEp2jDPuaXdl7yHpkNR5/ZUFk1nDGQ/xUTPph70fc+Wvin9mXzKenHWkPXhajzHeoi/k1ol4a6cs/29dampFduo4DItzWnxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=dRar5eJu; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40T4TVNd000412; Mon, 29 Jan 2024 05:44:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type; s=pp1; bh=5P19J4UsCEy395Sq3OX4ZVElGZFdAvopFeOiSHWhQEY=; b=dRar5eJuhlhXw888NbvsP9CB2dVEj6Wg8i42MaDSFVk7trPXqFEUI25p6YQlJSnlaLmI 1brq5tQlJP4KoA+ApTperTjQTWq1rzxDNIpqPg8Fi3HZpfrYvN4wylBMOgeqIcZSTcVW 2GavLDrAxS69pxFnPcKx376+G7oPSb6MsyOz04VfIvzoZy+4KdGqhPmEK5TVf5hagiI9 1bjyPT+U3yhJCMVxEd5vKTA0bXWaBlEbyyTik8qBRJHJrDYDsb6hQ4UfJNjQMwN/pvJo rwbOJOnME6SUBlIMo7/aNSx9J6k3RVclAhHve4XqYK9q8yu+zPhYDqGXO8rIHLCXV4yQ 7A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vwtaek4v7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Jan 2024 05:44:01 +0000 Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 40T4dcZS031374; Mon, 29 Jan 2024 05:44:00 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vwtaek4u9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Jan 2024 05:44:00 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 40T5R7UZ007964; Mon, 29 Jan 2024 05:43:59 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3vwdnkp8s7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Jan 2024 05:43:59 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 40T5hu6s46661986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Jan 2024 05:43:56 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F206C20043; Mon, 29 Jan 2024 05:43:55 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7753A20040; Mon, 29 Jan 2024 05:43:51 +0000 (GMT) Received: from vaibhav?linux.ibm.com (unknown [9.43.24.56]) by smtpav04.fra02v.mail.ibm.com (Postfix) with SMTP; Mon, 29 Jan 2024 05:43:51 +0000 (GMT) Received: by vaibhav@linux.ibm.com (sSMTP sendmail emulation); Mon, 29 Jan 2024 11:13:50 +0530 From: Vaibhav Jain To: Christophe JAILLET , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Kautuk Consul , Amit Machhiwal , Jordan Niethe Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , Gautam Menghani , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org Subject: Re: [PATCH] KVM: PPC: Book3S HV nestedv2: Fix an error handling path in gs_msg_ops_kvmhv_nestedv2_config_fill_info() In-Reply-To: References: Date: Mon, 29 Jan 2024 11:13:50 +0530 Message-ID: <874jewy9rd.fsf@vajain21.in.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: kpf5wIbPQbNQS9J3hKoQo_0puOIwm1mu X-Proofpoint-GUID: FRQApm0KkC0kJTi0jS-4tya3IfZLlrx8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-29_02,2024-01-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 spamscore=0 clxscore=1011 suspectscore=0 lowpriorityscore=0 mlxlogscore=901 adultscore=0 phishscore=0 bulkscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401290039 Christophe JAILLET writes: > if (kvmppc_gsm_includes(gsm, KVMPPC_GSID_RUN_OUTPUT)) { > - kvmppc_gse_put_buff_info(gsb, KVMPPC_GSID_RUN_OUTPUT, > - cfg->vcpu_run_output_cfg); > + rc = kvmppc_gse_put_buff_info(gsb, KVMPPC_GSID_RUN_OUTPUT, > + cfg->vcpu_run_output_cfg); > if (rc < 0) > return rc; > } > -- Thanks for catching this and the change looks good to me. Reviewed-by: Vaibhav Jain -- Cheers ~ Vaibhav