Received-SPF: pass (google.com: domain of linux-kernel+bounces-42300-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <84827fd6461c9650443608e33afe9eb011793656.camel@gmail.com>
Subject: Re: [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
 "a.zummo@towertech.it" <a.zummo@towertech.it>,
 "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
 "jdelvare@suse.com" <jdelvare@suse.com>,  "linux@roeck-us.net"
 <linux@roeck-us.net>, "robh+dt@kernel.org" <robh+dt@kernel.org>, 
 "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>
Cc: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>, 
	"linux-kernel@vger.kernel.org"
	 <linux-kernel@vger.kernel.org>, "linux-hwmon@vger.kernel.org"
	 <linux-hwmon@vger.kernel.org>, "devicetree@vger.kernel.org"
	 <devicetree@vger.kernel.org>
Date: Mon, 29 Jan 2024 08:55:40 +0100
In-Reply-To: <170c8d6b-3246-493f-8cd9-6ac580cabc28@alliedtelesis.co.nz>
References: <20230403154342.3108-1-Ibrahim.Tilki@analog.com>
	 <147c92f9-b42b-4a51-a6f9-2d90bfe63aa0@alliedtelesis.co.nz>
	 <1b42866bb6f05b7d68e9b8304e42359fccdf2bad.camel@gmail.com>
	 <170c8d6b-3246-493f-8cd9-6ac580cabc28@alliedtelesis.co.nz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-01-29 at 03:28 +0000, Chris Packham wrote:
>=20
> On 26/01/24 20:51, Nuno S=C3=A1 wrote:
> > On Fri, 2024-01-26 at 02:22 +0000, Chris Packham wrote:
> > > Hi All,
> > >=20
> > > On 4/04/23 03:43, Ibrahim Tilki wrote:
> > > > changelog:
> > > > since v5:
> > > > =C2=A0=C2=A0=C2=A0 - dt-binding: add enum value "2" to aux-voltage-=
chargable
> > > > =C2=A0=C2=A0=C2=A0 - dt-binding: remove adi,trickle-diode-enable
> > > > =C2=A0=C2=A0=C2=A0 - dt-binding: change description of trickle-resi=
stor-ohms
> > > > =C2=A0=C2=A0=C2=A0 - dt-binding: reorder as in example schema
> > > > =C2=A0=C2=A0=C2=A0 - parse "wakeup-source" when irq not requested
> > > > =C2=A0=C2=A0=C2=A0 - remove limitation on max31328 irq and clokout
> > > > =C2=A0=C2=A0=C2=A0 - remove error and warning messages during trick=
le charger setup
> > > >=20
> > > > since v4:
> > > > =C2=A0=C2=A0=C2=A0 - dt-binding: remove interrupt names.
> > > > =C2=A0=C2=A0=C2=A0 - dt-binding: add description for "interrupts" p=
roperty
> > > > =C2=A0=C2=A0=C2=A0 - dt-binding: replace deprecated property "trick=
le-diode-disable"
> > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 by "aux-voltage-chargeab=
le"
> > > > =C2=A0=C2=A0=C2=A0 - dt-binding: add new property "adi,trickle-diod=
e-enable"
> > > > =C2=A0=C2=A0=C2=A0 - dt-binding: remove "wakeup-source"
> > > > =C2=A0=C2=A0=C2=A0 - use clear_bit instead of __clear_bit
> > > > =C2=A0=C2=A0=C2=A0 - use devm_of_clk_add_hw_provider instead of of_=
clk_add_provider
> > > > =C2=A0=C2=A0=C2=A0 - use chip_desc pointer as driver data instead o=
f enum.
> > > >=20
> > > > since v3:
> > > > =C2=A0=C2=A0=C2=A0 - add "break" to fix warning: unannotated fall-t=
hrough
> > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Reported-by: kernel test robot <lkp@=
intel.com>
> > > >=20
> > > > since v2:
> > > > =C2=A0=C2=A0=C2=A0 - dt-binding: update title and description
> > > > =C2=A0=C2=A0=C2=A0 - dt-binding: remove last example
> > > > =C2=A0=C2=A0=C2=A0 - drop watchdog support
> > > > =C2=A0=C2=A0=C2=A0 - support reading 12Hr format instead of forcing=
 24hr at probe time
> > > > =C2=A0=C2=A0=C2=A0 - use "tm_year % 100" instead of range check
> > > > =C2=A0=C2=A0=C2=A0 - refactor max313xx_init for readability
> > > >=20
> > > > Ibrahim Tilki (2):
> > > > =C2=A0=C2=A0=C2=A0 drivers: rtc: add max313xx series rtc driver
> > > > =C2=A0=C2=A0=C2=A0 dt-bindings: rtc: add max313xx RTCs
> > > >=20
> > > > =C2=A0=C2=A0 .../devicetree/bindings/rtc/adi,max313xx.yaml |=C2=A0 =
144 +++
> > > > =C2=A0=C2=A0 drivers/rtc/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 11 +
> > > > =C2=A0=C2=A0 drivers/rtc/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0 1 +
> > > > =C2=A0=C2=A0 drivers/rtc/rtc-max313xx.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 | 1053
> > > > +++++++++++++++++
> > > > =C2=A0=C2=A0 4 files changed, 1209 insertions(+)
> > > > =C2=A0=C2=A0 create mode 100644
> > > > Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> > > > =C2=A0=C2=A0 create mode 100644 drivers/rtc/rtc-max313xx.c
> > > What happened to this series in the end? It kind of went off my radar
> > > and I forgot about it.
> > >=20
> > > We've been carrying a version of these changes in our local tree for =
a
> > > while (and using it quite happily I should add).
> > >=20
> > Hi Chris,
> >=20
> > Also not sure.... In the meantime Ibrahim left ADI so if this is not in
> > shape to
> > be merged he won't be able to re-spin. If there's a need for a re-spin,
> > please
> > let me know so I can see internally if there's someone who can continue=
 this
> > work. I would do it myself if I had the HW.
> I've got a board with a max31331 so I can test that. I don't have any of=
=20
> the interrupts hooked up so I won't be able to test that. Looks like=20
> there was some outstanding discussion around the trickle-charge=20
> devicetree properties so I'd need to figure out what was wanted there.=
=20
> I'll try to pick up the last series from the mailing list and go from the=
re.

Thanks Chris!

- Nuno S=C3=A1