Received-SPF: pass (google.com: domain of linux-kernel+bounces-42313-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Inochi Amaoto <inochiama@outlook.com>
To: Conor Dooley <conor@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Inochi Amaoto <inochiama@outlook.com>,
	AnnanLiu <annan.liu.xdu@outlook.com>,
	chao.wei@sophgo.com,
	unicorn_wang@outlook.com,
	robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org,
	paul.walmsley@sifive.com,
	palmer@dabbelt.com,
	aou@eecs.berkeley.edu,
	devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] riscv: dts: sophgo: add watchdog dt node for CV1800
Date: Mon, 29 Jan 2024 15:55:20 +0800
Message-ID:
 <IA1PR20MB495332E3773A4604F95008C3BB7E2@IA1PR20MB4953.namprd20.prod.outlook.com>
In-Reply-To: <9f9a1f5f-2104-4a5c-a837-cd8d18e173d6@linaro.org>
References: <9f9a1f5f-2104-4a5c-a837-cd8d18e173d6@linaro.org>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|MN0PR20MB4644:EE_
X-MS-Office365-Filtering-Correlation-Id: dc8ed6f0-92c8-444f-b3cc-08dc209fa807
X-MS-Exchange-SLBlob-MailProps:
	obhAqMD0nT8ImFmzuH22ketkSXIUwA8oW1qSI1Hc0yVbuiguZfzYLDmcBjKppUlE72saBf3/eQFexr0yluamLweNuW4LQZbEPmJfUFgxo5dFMC7ZFy2yy3L8IOFTZs8pL2Hs4fwCKtbnaKlgkj5CmzghpHvaVt+1hDmEcy2HnvKxuLHGl1jXg5oOQiZhUyJFA/OFj2bDTeJDsBEGD/EwTIFq3Gp9XLIXY8qsvlM3DRMHnMhKXo3HCyL4DZ1tIBuqFAEJZa1qgJ25tG7/RU5nXWlJ5l92L11j/9EhOg5xkfv7/IAUuzEhkg6u54F9+npqCGeq5oAaMPmckojmx6rcwxiSawbtD2fod0UgYfEIKhe8fq22ddJMARacvmZSYrBVR17LhnV7irNWe2OYnop3WJNbASTl6ms2fXsgHEntOqO03WHgHoqkDukeEz5cuAUprHMjgEwDMTVD8N+zFoskyr7UmoSH9f7OtufiNSL5BgqA3krG11GPpIuC/hYC9MA9zvs5FmqEUMhUJoyGpCUMZvXy+YaAw4GX8ziwvbZq2YP8xbvH7qvsmHsexflW6Hl+L6K5tOWhfGMF7+pcgK0ILtAiVSqbb/g3RMgR6H2TNwwQVp/cmq9pc9PgqrH+dh+SlIo+lJ1wJEZV1nZP8x7UwWe0i9fQ9qClGFKrCDegi+k9YTtplZaXF6A46o/X7FaahyIcA0bQbq2/a+qRBaydfVkqhZPCDqlOnvGFGE1RyRIwuHzF7dYBQj/tF5y20NvjEuHknxKTTKgGBX2D+DEc1+9G56O+uCtLhERlLSBy+BG7+SMVFeXI6odVvBlxTRmQ
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IBmEoIRz+DagN3abtCUgeNR/f7sbiW2AbAKiLXe5rtVEMflmgdlP3l2+2MNZ8c+brZisJ0O1RznOOx+4jRzEbhAYaNRmyTbG6le/9E+DiH7cLxxw+D+scjr9T+/n/ppMKV9vBjBdiqVyeArO7RQo+nQi+BziGlxCKLw9Bb5xoUnN3ao80GgUzObz/uc6AI8ib1ilnH3+YTNeCg6RT6thzQ4YdAnIxpQ5hRrzxgSFZG+K4UKyux6FCF9xjzbdIwSRcJS/KQYe85D6wPsQFQy/U/7ttVN/iNMLzu+7L43pyF28jNkwbn8pKO0AFXVLbGpkcJOwQCsPQEQqDE//lsQ4o9+E5652XQUvozC9agoefYgiQurzCNEPNYQ3ONDWDmpEKTNBJrilbcOg9qVDpxS4YJc/I4I6MIKlX6AfWSGKIpYP0udYFJt1GVXoLI460RpKJkUMRROVYqnt86CExtNTzjVpFiLBbzwrGMcBYOK+DLFp715c6Lkuq4gM6Iq+p8xujxXT8mui/GOp8is3QZ5gaTs23242hEg5IxPAEzTqYjLgt15j3SShz4iOcn7DDSppImCx2vTZaX052CkI59BxwfvTQNlp1SubysS5Cs4Yu23zjJHiIUz8JtI/+bni/d3+
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?GCebfqB+z+GK5JdmC7w1olxA9iwoa/IWHTYXMQtTpje9DJ2ZI14JhtiRdbf1?=
 =?us-ascii?Q?Oc3iryB2XYL7kx+XhnqW4k+wE+r7Tzkk8v2Zxky7l7e3lQrcFGLg4Lu3WxYp?=
 =?us-ascii?Q?lvjUIURXcqmuk83NxC8vibF4f9SNIH7GCTqDgeEH8DyECprvwVGSH1IP4/cc?=
 =?us-ascii?Q?FQNAyH/VblyrI3ar3HT5fe6uzqKlCpvGVjBI08jeDowJcYan/jYhxqtVqVEy?=
 =?us-ascii?Q?brCIZUD2RmmgoLhtC4mwsz7V7t/JQVEuyY41VPZsHccti+tI7x0oWqaugOqq?=
 =?us-ascii?Q?UBrPI6op2PiSxL38LmCQUPanZ/GrKnxmXvUabDNUXG5F0rKEC66vKTbS0FEb?=
 =?us-ascii?Q?eiefCx79MGaw6RkBxYvlhWx0S3jV1G6gedMHgCYGxMAJmZ8OTH86FfPctRaz?=
 =?us-ascii?Q?MISV+POYHKrkOLAM0oCeV7TYpprJVXfNXgAMotwkFoDQjTRjDI34EnA/iBaI?=
 =?us-ascii?Q?o+LuyUXOmz6FOHYAkNfK5KI2pdfX/sX6aXPiIZ/6yaxtGG6gRi7awl+N1sft?=
 =?us-ascii?Q?4X2bSiC+vWdfW4djOXgV2mFRbUNajYlKI6zujqa5TwxD7Xx6DjrYsbu7ACfM?=
 =?us-ascii?Q?3JgHcfKoaV4hhjHASpkOBw+FS8YLcVO+1YkzGBwWh+AJ4gWKLe0kagKRtiMv?=
 =?us-ascii?Q?3XXXL31TssYjA+lIiWBmfGxN7hOEpU8wGpNwiNuNCQ2qDZCYl4G84Z+Cls4L?=
 =?us-ascii?Q?1XT/iYui3pEma1tOw+bT79+F4g2rknr9jJSzBoLLkmZxo+BRCuCXfakNMY8G?=
 =?us-ascii?Q?72ZvcfyU/KDD0SD9pLe0oXUJw/erdyWxWD77h+pFnu45VUZovXGP0Y6A5K/5?=
 =?us-ascii?Q?ZDz2KjbxtZn4qGt459FlARg8gWdkZEZ6MF0jFg2yk82RvqrPPyWYVu51C5j0?=
 =?us-ascii?Q?c+yIPk9EpCkxIasHM4rIg+E7bBdawHspOSSMyzwye0FRJN099VCWvhlgqvCO?=
 =?us-ascii?Q?eFLtY6fEn6Sw66mGq1LlgTbUngryqxMkd/V3Nwhnwm8Et48ba1NUIz5NPCZM?=
 =?us-ascii?Q?Y5TGXsslrCN++BSLepsLqLpVp9fAt3rgcKX0N/19Gi8SgL2iiREXgwIyBlG7?=
 =?us-ascii?Q?WO3jyoaloCBcobpuFTp25/yXYXKafCH4+M4irsDqjBZ3vtlZObRoLMfyj3dL?=
 =?us-ascii?Q?nb/3dSOeYx7VhRRqKzC9W8XH/+E5w1UMahuOWkaMU6PSgOpk/pA2MMqisXOe?=
 =?us-ascii?Q?EehKtGn9JQnvNt2NYoockjl8mvOFVpmnwRTffvHW6h6dSfHVUAcd84inhfad?=
 =?us-ascii?Q?epmnf/xOXH4R1v6ntVKoYvgakeJSlvUbR63CNuj1WA=3D=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc8ed6f0-92c8-444f-b3cc-08dc209fa807
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 07:55:27.3774
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR20MB4644

>On Thu, Jan 25, 2024 at 01:39:51PM +0100, Krzysztof Kozlowski wrote:
>> On 25/01/2024 10:46, AnnanLiu wrote:
>> > +
>> > +		pclk: pclk {
>> > +			#clock-cells = <0>;
>> > +			compatible = "fixed-clock";
>> > +			clock-frequency = <25000000>;
>>
>> It does not look like you tested the DTS against bindings. Please run
>> `make dtbs_check W=1` (see
>> Documentation/devicetree/bindings/writing-schema.rst or
>> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
>> for instructions).
>>
>
>> Also, why do you describe internal clock as stub?
>
>Under the --- line it says the patch depends on the clock series, but
>as you pointed out the clock is a "fake" stub, so I don't understand
>what the dependency would be.

This clock should not exist. The watchdog may depend on the clock from
clock controller.