Received-SPF: pass (google.com: domain of linux-kernel+bounces-42327-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, Jason Gunthorpe <jgg@ziepe.ca>,
	"Joerg Roedel" <joro@8bytes.org>, Will Deacon <will@kernel.org>, Robin Murphy
	<robin.murphy@arm.com>
CC: "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 2/2] iommu: Probe right iommu_ops for device
Thread-Topic: [PATCH v2 2/2] iommu: Probe right iommu_ops for device
Thread-Index: AQHaUEbD/g6CTWszfk2HvsRysB/6q7Dwcw3A
Date: Mon, 29 Jan 2024 08:07:34 +0000
Message-ID: <BN9PR11MB52765D2F1B8BCE5C47D37E8E8C7E2@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240126105341.78086-1-baolu.lu@linux.intel.com>
 <20240126105341.78086-3-baolu.lu@linux.intel.com>
In-Reply-To: <20240126105341.78086-3-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XwsmKlqOInGgaiu59zU55kbBBhoCsLPoR4jbWm5MNXdK4v97aBgZAiLUgjm3?=
 =?us-ascii?Q?HOfkbAc3c+qb4EcplRwMY74/oImtDT+YSQ5+rESXA9gRolxWGJu3gi8LW3Yy?=
 =?us-ascii?Q?tI51o7pnfrJ62+7ZlyYOFsFni4HIjsSnXO3ZpgGVQ/QDgra53c6gVGlyw52M?=
 =?us-ascii?Q?5feHuV9pr0V1Z7Zz5ivxJlDitkBZADV6NuixF3mKcthX8f7XUxef/LfabDBX?=
 =?us-ascii?Q?/SL/8XXNSW1K5kJT/8QB2ZW7hHJkbqceq7wJGsTFA45SFCFzO2jF6aLf0ctR?=
 =?us-ascii?Q?7yR14BEYYfOnKWilMftIEEhis+SiTXGjuh6nYkE8TihSSUPV51cdcbD7+t0v?=
 =?us-ascii?Q?JVbTKF2dd7ykgpRmsvabV6D/sT7LzRJxlpAAW86YSbqdwOXxm+/YStvD9PWp?=
 =?us-ascii?Q?7b0YdH1zbukkIbx41xtIPTZyK3H8s7+/36VrY8z06Dkk/u6/NvgMqd2vilO1?=
 =?us-ascii?Q?XNBXSyTFpw00tcJ6q39apX8bto4Eq9a6NOs7y9P4PB6fv2d1uf0q+FukaEzQ?=
 =?us-ascii?Q?Ccl2j8LDzsa03jUkiR/JKbJQKCjymQuO2BvayTr8jo2agCfFbk+SUZAs/1XJ?=
 =?us-ascii?Q?xnvUkpxgZXEZV92mfFb6eOeHOHAisTh1WxpqQI8aAwFW6D+BF0xtBjfy/WLt?=
 =?us-ascii?Q?frbyjNG1rae2JOwc9rdEWki1uhIDLU1QEkURLnhQliBT4gIsMOkGSgEUhpRa?=
 =?us-ascii?Q?F15ZrSrW3n1CP9pI8ZMjvbfLYQ7/7m5TNkLkx/MqNq29rWAXH34umPkvpibg?=
 =?us-ascii?Q?xOByPI3Zu784/GplnfPJaUq9dVt4A9IqEO8tA4dBj083t+SwpDhJNYaMDVcq?=
 =?us-ascii?Q?tCVzURKzeFPf+wKcs5AJHk5fzhk/JLy1gkKVwC/D5dinKdDSPiWB6DN72Iz6?=
 =?us-ascii?Q?2p/A3zvWs6/v2keJmBBKrWrSEUNeMhsk3q4qRMstg3FIXGkkF95NLteiffCo?=
 =?us-ascii?Q?TIshGRAoS1K/U3gsbkvkMfSQqk8UEG/1pHlfQCvdwPydnfrUpPS+h7RGy+xH?=
 =?us-ascii?Q?afIHPneQsg1sYumIXUtiJlFU/GxX65tpx2gJPZTldmMKEP4BLGIEyGhp42ss?=
 =?us-ascii?Q?O27XE0E0RvxH4m0NhqLm9glIDrDv8ws+xZlSEiws/aVCU8w48muM4mIx97Mr?=
 =?us-ascii?Q?1QP32sbIOJdKCQGlPII7imjtW7taJpIlT41+IsDpRpPvS+Hb5Adiz6cCraIT?=
 =?us-ascii?Q?1dp0fgNXkdsDmxXI6NdhE0gPz5dxonXEtwZWRFosu67NLWcsaqB/o996vZM+?=
 =?us-ascii?Q?IOk4PxlT5lX/SJpwQxg4pP1yYxRNNHVZf0dd2Cr/iH67weRhe78PAbAaMURg?=
 =?us-ascii?Q?XEOQ8SCQytxzU5+vyIjl3ane5hEh5jKJm/9jrRyBDElq76qMlpQJSv34W9Bg?=
 =?us-ascii?Q?FkmgKlhSCp7WGMwpsH0KOaVPVaS9wPPUNle9sDXEcNe6h/H9F9M3KMf3tMlk?=
 =?us-ascii?Q?6dr221josUItfnDA3ljgT6jRdE51TSpX0YCPk3jQ+Z9TzT/wAqEzK27Rk7GP?=
 =?us-ascii?Q?vxp/O5/ciH86ea3NrQqJulAi0tL7Ts8epfvCwWPk88OXP2NNtPvCfVY9BEJu?=
 =?us-ascii?Q?c+E3Mnc4eM73Vw8ioE0yMgJwv6x+XF32n3rjCa5x?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a6dbcb26-fd64-48e7-7919-08dc20a1595b
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2024 08:07:34.0401
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: K52BO349Amq7rgeEemmF+xwopQtJB3woARaFC5LD+/EcC0VwYn39m0ZHToMBSAdlxpyThd61P4qOVfm1SzqDvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7718
X-OriginatorOrg: intel.com

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Friday, January 26, 2024 6:54 PM
>=20
> Previously, in the iommu probe device path, __iommu_probe_device() gets
> the iommu_ops for the device from dev->iommu->fwspec if this field has
> been initialized before probing. Otherwise, it is assumed that only one
> of Intel, AMD, s390, PAMU or legacy SMMUv2 can be present, hence it's
> feasible to lookup the global iommu device list and use the iommu_ops of
> the first iommu device which has no dev->iommu->fwspec.
>=20
> The assumption mentioned above is no longer correct with the introduction
> of the IOMMUFD mock device on x86 platforms. There might be multiple
> instances of iommu drivers, none of which have the dev->iommu->fwspec
> field populated.
>=20
> Probe the right iommu_ops for device by iterating over all the global
> drivers and call their probe function to find a match.
>=20
> Fixes: 17de3f5fdd35 ("iommu: Retire bus ops")
> Cc: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>, with a nit:

> +
> +	mutex_lock(&iommu_device_lock);
> +	list_for_each_entry(iter, &iommu_device_list, list) {
> +		iommu_dev =3D __iommu_do_probe_device(dev, iter->ops);
> +		if (!IS_ERR(iommu_dev))
> +			break;
> +	}

here could skip iommu with a valid fwspec.