Received-SPF: pass (google.com: domain of linux-kernel+bounces-42338-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <e2688a01-47d2-4f89-ab92-252f378d37ba@kontron.de>
Date: Mon, 29 Jan 2024 09:17:48 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation
 rounding
To: Adam Ford <aford173@gmail.com>, dri-devel@lists.freedesktop.org
Cc: aford@beaconembedded.com, Inki Dae <inki.dae@samsung.com>,
 Jagan Teki <jagan@amarulasolutions.com>,
 Marek Szyprowski <m.szyprowski@samsung.com>,
 Andrzej Hajda <andrzej.hajda@intel.com>,
 Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>,
 Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
 Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
 Michael Tretter <m.tretter@pengutronix.de>,
 Marco Felsch <m.felsch@pengutronix.de>, linux-kernel@vger.kernel.org
References: <20231212033259.189718-1-aford173@gmail.com>
 <20231212033259.189718-2-aford173@gmail.com>
 <CAHCN7xKKMzOtVaEXzgTgsO4yZF0JZ6=o+TFJOeTCza0fMGss2w@mail.gmail.com>
Content-Language: en-US, de-DE
From: Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <CAHCN7xKKMzOtVaEXzgTgsO4yZF0JZ6=o+TFJOeTCza0fMGss2w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a0d3YU42Tktyb2plbG9TU3dZYXZIV1hEZ0xQMmNZVTFacGhaVGVkTjlTV25E?=
 =?utf-8?B?YVE0NklyV1RaYllBYUgzZDhETnpqbVVyREwrejRMeWl2Sm1OSkRXNmw1Yjl3?=
 =?utf-8?B?YlRzTjFCTTFDaXJlbEsxUkpxSlBhWG9nTDZvaW1ET1JaUWFMWGZZQ1BWU0Vj?=
 =?utf-8?B?RmdabS9mTFJwaE9EN09oZFd3T3ZmRUZyTFMxT2JhL3NvWUlpVXBINFJ6ODVM?=
 =?utf-8?B?MzB5MnhjRVRJcnBjWnRjMU1JRmprWFZlbkJWaGlIMVRiRVJSd0U3TmpINy9J?=
 =?utf-8?B?K01GNU9xblRxVkREVzFpc1l1Y3h6UW1HTExDdVdTaTJkcjkrRTdIOHhVNnpU?=
 =?utf-8?B?WW9TMTVzNTU1anRuMHRCaFpZNzVveUtOampidUNOV3MzZklpbVROUXpKSmp6?=
 =?utf-8?B?MUFKMmdEVDlxNlVPWlRod3E5VVVnVzJVSWlLMzN6Wkl5dFBEaGxIcFhoQWND?=
 =?utf-8?B?WFhVaFowbnZYN3dHeGJPSExLQzN0VUNIQVVWUFFvRnU4VEMyWGFWd0JnZnpY?=
 =?utf-8?B?MWNPRU8yek52RFVYVmpJN2NyRG1HZXBkYkMyQUpzbUZQaHZuSXRuRXRiUlpr?=
 =?utf-8?B?QzlRZ3VkMWpWODdDYUkrejdTOHJBQ3VtMytkbExkeW5kckc4T2hmaGJtRHlX?=
 =?utf-8?B?Q0Q5TEVHaE1LOHBBTWIzREJzdm1pa0FGYlhLNFZvQ2Q0VGovS2Rlc21pS0dX?=
 =?utf-8?B?bTE4SGROeFd2bDhVbUE0M2tyc01OVGU4bDZFUk4xWDhDQUNkUzU2bE9mSG5Z?=
 =?utf-8?B?M3VaeUlFTm42ejZ5QnkyT21RbUxYSEwvd0UvMXlBZElmYTIwUlBGZ0xGS2J2?=
 =?utf-8?B?QVJ3cUtEL1dMMHhFdVdrajcwbWg0cjhMY3djS0ZuZk8yR1YyNW5FeC96Z2NT?=
 =?utf-8?B?MnJEK3F0ZU9ORDdMUXBNOHRmeGwyRDNjbEI2YldObklxbldYTEdmRU9VREZT?=
 =?utf-8?B?WXd6RmY1UWRMTXB3WURROHc4MGpwM0Y0cWpyUzNyazVSZm41amFMUTloMk1a?=
 =?utf-8?B?THFCVWJ3QSt2VUVaNHN5c2ZJUENSd0hIc0VXbk9sZ2dYZk00dVdrTkNMMnRC?=
 =?utf-8?B?MXhzdjRiQ2JyUDJRYlkvVGs4YUtrOWVUL1hlZkNhU0NDa2NieE9CRmRUZVRP?=
 =?utf-8?B?VktTbkFxdHdZRmorNzJuaUgwbXJHR0tJNElBcWpnZitGZGtpY2Y2S2V5RWpz?=
 =?utf-8?B?dlZqRkNveHJPd0ZvZTdKcE4yZWh6eVphVHFPQk5OeUt5RlBTcmFERVpFWXZQ?=
 =?utf-8?B?MEpiWWJSdDRtTTQzSldxZkptR3RNcU51VUVoc3BOUlcyL2x6VDl3S2Yxai9z?=
 =?utf-8?B?ajZDRjJlZEkxSk9EUkthOUs5MGdHRHg5WndGN3pEdmFURlUwWlFtaVhlVDZS?=
 =?utf-8?B?ZlpKRzV6L3lBWCtoVDBEOHFNNTl0eC9OZ1RlRElTRUdEakJOWkZEMElqZjVz?=
 =?utf-8?B?TU9mMDJPeDlmT3J4QVhmUzFzZGt0ZUxWV1IzTkF3d3p3UTY3ODBhSWZXOE90?=
 =?utf-8?B?RFZUM0ZsdHdKYmV3UG5CRkNWQ24wYVlLSnpBNHRxekEwYThMeGdYQmx2ZHFD?=
 =?utf-8?B?bXM4TXVlejVDaFhBVjYrZlpPUjZsY3l4cVZweVVzci9nVkQybGRvUTFacjUz?=
 =?utf-8?B?YW0zVklHekpSelBDMlVjeFhzRzZpa1FYRE1XZWExSnhDTGx5YnR2S3lPalBh?=
 =?utf-8?B?R2JSNW1PaFhjNFoxS01ZV05vbDFjSmxyTmtIUTJHTVlQa0ZXM3VGd0NPRTJy?=
 =?utf-8?B?b1pZZDc0TXBaU1BzYll1VEI4dFdwUkpERHJwWmFCMWJZeEVHSmZwd0xpbnRT?=
 =?utf-8?B?SW5YYzZsTHpMT3M1cmplaEtWQ2c4aHZUMCtYU2VjVGRuYjRIWmkzeFRvalVR?=
 =?utf-8?B?cDB2Uno1VlEwYWxSbEFxQnhoZjJZdnc3T3ZDK1NGUnFjeWRyZ21OTU9KT3p6?=
 =?utf-8?B?dWpEQWx5UTMrbDBUNlFOWDFwS1dlMllNNUZ6U0JuMVFnekZ0b21HcW9hTDk4?=
 =?utf-8?B?YVo4NitqOE1JMk1pVDNyMXlSLzBGWkh3U0xaYUovc3JpMk55WlZMZlU1d3g1?=
 =?utf-8?B?b3crOG9hU1hYWWsxOHhvVlQyYWhHajdpajRQRGgwVW5FbmpESkZhK2I0U2sr?=
 =?utf-8?B?QkdUdFpvVUdFM3RnaFpVQm0xZ1EyZ0FFUnlPTHpXbTdvanFMOHN2MFJTS0dG?=
 =?utf-8?B?N0E9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: eb672d13-c5b3-47fb-5703-08dc20a2c892
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 08:17:50.2953
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hJVD4NdZaeZmAW1157Co3/RWDDMxL8W/59H2QyaaQ6m4yQ9JO7aSD5Z+GePRLm4FRFlXdxJAg3IvhM4BGTN5+DOQ2cpA0rYkCcNd8DwYq8A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAPR10MB5321

On 25.01.24 19:44, Adam Ford wrote:
> On Mon, Dec 11, 2023 at 9:33 PM Adam Ford <aford173@gmail.com> wrote:
>>
>> When using video sync pulses, the HFP, HBP, and HSA are divided between
>> the available lanes if there is more than one lane.  For certain
>> timings and lane configurations, the HFP may not be evenly divisible.
>> If the HFP is rounded down, it ends up being too small which can cause
>> some monitors to not sync properly. In these instances, adjust htotal
>> and hsync to round the HFP up, and recalculate the htotal.
>>
>> Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de> # Kontron BL i.MX8MM with HDMI monitor
>> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> Gentle nudge on this one.  Basically this fixes an issue with the 8MP,
> but it's still unknown why it doesn't work on 8MM or 8MN, but Frieder
> confirmed there are no regressions on 8MM or 8MN.

I only tested two specific display setups on i.MX8MM. So of course I
can't confirm the absence of regressions in general.

Anyway, I think this should be applied.