Received-SPF: pass (google.com: domain of linux-kernel+bounces-42280-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <abc6771f-fafe-4ca7-898a-aecbe017b3c7@linux.intel.com>
Date: Mon, 29 Jan 2024 15:24:39 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: baolu.lu@linux.intel.com, Joerg Roedel <joro@8bytes.org>,
 Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
 Jason Gunthorpe <jgg@ziepe.ca>, "iommu@lists.linux.dev"
 <iommu@lists.linux.dev>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] iommu/vt-d: Remove INTEL_IOMMU_BROKEN_GFX_WA
To: "Tian, Kevin" <kevin.tian@intel.com>,
 Christoph Hellwig <hch@infradead.org>
References: <20240127064512.16744-1-baolu.lu@linux.intel.com>
 <Zbc_mdOYxMIxWAdd@infradead.org>
 <BN9PR11MB5276D63FAC442A415018ACB58C7E2@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Language: en-US
From: Baolu Lu <baolu.lu@linux.intel.com>
In-Reply-To: <BN9PR11MB5276D63FAC442A415018ACB58C7E2@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024/1/29 14:08, Tian, Kevin wrote:
>> From: Christoph Hellwig <hch@infradead.org>
>> Sent: Monday, January 29, 2024 2:03 PM
>>
>> On Sat, Jan 27, 2024 at 02:45:12PM +0800, Lu Baolu wrote:
>>> Commit 62edf5dc4a524 ("intel-iommu: Restore DMAR_BROKEN_GFX_WA
>> option for
>>> broken graphics drivers") was introduced 24 years ago as a temporary
>>> workaround for graphics drivers that used physical addresses for DMA and
>>> avoided DMA APIs. This workaround was disabled by default.
>>>
>>> As 24 years have passed, it is expected that graphics driver developers
>>> have migrated their drivers to use kernel DMA APIs. Therefore, this
>>> workaround is no longer required and could been removed.
>>
>> How about you Cc the intel graphics maintainers and get a confirmation?
>>
> 
> in the worst case there is still "igfx_off" option available to achieve the
> same effect.
> 
> there is really no good reason to keep this config option so long while it
> was intended to be removed in 2.6.32.
> 
> but yes the Intel graphics maintainers should be CCed.
> 

You both are right.

I will add above in the commit message and Cc graphic guys with a new
upgraded version.

Best regards,
baolu