Received-SPF: pass (google.com: domain of linux-kernel+bounces-42386-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Ethan Zhao <haifeng.zhao@linux.intel.com>, "baolu.lu@linux.intel.com"
	<baolu.lu@linux.intel.com>, "bhelgaas@google.com" <bhelgaas@google.com>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>, "jgg@ziepe.ca" <jgg@ziepe.ca>
CC: "dwmw2@infradead.org" <dwmw2@infradead.org>, "will@kernel.org"
	<will@kernel.org>, "lukas@wunner.de" <lukas@wunner.de>, "Liu, Yi L"
	<yi.l.liu@intel.com>, "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, Haorong Ye
	<yehaorong@bytedance.com>
Subject: RE: [PATCH v12 2/5] iommu/vt-d: don't issue ATS Invalidation request
 when device is disconnected
Thread-Topic: [PATCH v12 2/5] iommu/vt-d: don't issue ATS Invalidation request
 when device is disconnected
Thread-Index: AQHaUmYzrQ08B6c1X0Sf33u4K2TbKrDwe42A
Date: Mon, 29 Jan 2024 08:53:48 +0000
Message-ID: <BN9PR11MB5276AEEB81124D55B087F4FB8C7E2@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240129034924.817005-1-haifeng.zhao@linux.intel.com>
 <20240129034924.817005-3-haifeng.zhao@linux.intel.com>
In-Reply-To: <20240129034924.817005-3-haifeng.zhao@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1QLN9u0gS3FPRSG3rl2Shq/gw8tfS57lKIrqfezpIfewHUS8afionH9DSRtC?=
 =?us-ascii?Q?WqWFokks8LV/OunDmUFI+AAaiG4sLDOJlJBkz+9ZTebNHLlq1eHgpTAvvP9h?=
 =?us-ascii?Q?s/jODCVYPMpPbtOd9t9GQpM1Y0fED6y2YvrhRajGXHkVNdo++wKYl+OrqsMi?=
 =?us-ascii?Q?/Er0QQYP7xvGeCXsdePOTwu4mwWZBU4iYN2lldYEuZJI3PheuH0Isvzp0Cpk?=
 =?us-ascii?Q?hPxIR7Xtnhpewq4X5UjszQiRcPXpbrtZ9LVOLStkKiNA229id72c9ERGWty5?=
 =?us-ascii?Q?6H7wMsfSqreSr28Kk5mLmU5WEUh1+G2D/MZOiiACwZvrXPfXnXWfTWJkbpPr?=
 =?us-ascii?Q?KW3QGIgm4tqOb/x7ZFOC/rQjrhavsZkFXLMX6MWHlfi5BV3tdZlSoBtZ/A+J?=
 =?us-ascii?Q?226mved4weh4CsPWbItV9tCHzeneQ4FFy1N7iSHSBJnJ1ZyPb+8a/cABB9ug?=
 =?us-ascii?Q?XHb18b3jCtNZxdJ0fH4mypLjsaTEpkAJbpCC7myji6FUbXGFjepMyHtV+8pw?=
 =?us-ascii?Q?3FzaBwednwFimA+dik7gf7K/P1zzZxQzuQeZuRm33I3MDW5zQRRLx69V97rW?=
 =?us-ascii?Q?sYo61fEpuiKP/lKOQ2vD2VshEHaLAh7XGwxguJTcp/gq4EdySz6SJxiPAreJ?=
 =?us-ascii?Q?TkOLaBCqmb6zvxxccngKORuue5DL+Jpe8p1gIHisBC6hR1hX8fVllyhgIsOm?=
 =?us-ascii?Q?EiXl6GUOnCHlyfTqTW2FDcNEEDroM6/py29CZ3JTXiD5ZDPfiCT7X5skRrEe?=
 =?us-ascii?Q?REZu9/rTABDQer2fkmQBCuJEQ6fB7rxLLJENH8aqwUHNAYfOto9EbsV6CWAR?=
 =?us-ascii?Q?Ei8hRzk1rYDNaaIR9y2BNbdc4spLTnDeJDwEXgOvWw5qqvV2b8DTXTs3hTN+?=
 =?us-ascii?Q?PV7Gr5gv74TPawdKNNfwiirfeSs2bxidinKQy41qUscU3Dpe+xdx8WT0AFWb?=
 =?us-ascii?Q?FdJF0418Cli6uH2FhermO++Q5tWtf4dXca1WOKCSELErczOwrDTqWcw47FwX?=
 =?us-ascii?Q?8s12nHJ/CH/sRr1UNfm62vKK+NOGS1fOg4w4OQFwx4vNgTw3DIsC2cB5k9ss?=
 =?us-ascii?Q?jpMHR0N1JZrJqnVKVrXeULy9wHI3hfX4pkiZXxBEI9V1ZxzaIwj5/Vdua1Lm?=
 =?us-ascii?Q?hsKj5U1VXDMdr97fLWzKzdl3DwrsV5Vbyc488QtdSYgMByeshQSqSOYtvA2y?=
 =?us-ascii?Q?ii6/OAo/VzZrANyGQGnKmj1S5dO3trVUeP6c34UShwIT6FJYfNCQIWaDz1rO?=
 =?us-ascii?Q?bNryh1Z8L5wwQyRo/idRvL51SGhyhxpMJUai35P1UECZis4AOWLeZWzsTXQY?=
 =?us-ascii?Q?b+uSWwPvr6n9HYVlinmnhgN5T7qiBtaHjruKhJbh0bRNJMPpeLeD5HqBOa85?=
 =?us-ascii?Q?+/229i37JwbdhvdTIDApXhkVwegLrtaBesJXkn8V94u0M4S0lK5NDZS7yxw5?=
 =?us-ascii?Q?PCbGUnP/eFlkrEAlXvvUQiZUu1DDxE4cZWTgQSyNYkGMtTLqmFd0NlzuH/Dh?=
 =?us-ascii?Q?skSlLNNGJPFT87RI6cV3yZmdq4c11ZXaoK++jeN3K6/UDn9mUWl47LlXk1TV?=
 =?us-ascii?Q?qkCgW5ZLcYjZI/M3Tn+b/AdDWOp15MTuzVofJQQJ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f89d061-26ba-483b-40e0-08dc20a7cec9
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2024 08:53:48.0182
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2y5EJTUDFVNtdTdNPKF6xIeL+sUyTsXT7kmyxclTVdyVZcLEBy+Uw0SndGi3Z8Y/283yTAfTfk9AN03ds+Uqfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7784
X-OriginatorOrg: intel.com

> From: Ethan Zhao <haifeng.zhao@linux.intel.com>
> Sent: Monday, January 29, 2024 11:49 AM
>=20
[snip]
> Fixes: 6f7db75e1c46 ("iommu/vt-d: Add second level page table interface")
> Tested-by: Haorong Ye <yehaorong@bytedance.com>
> Signed-off-by: Ethan Zhao <haifeng.zhao@linux.intel.com>
> ---
>  drivers/iommu/intel/pasid.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/iommu/intel/pasid.c b/drivers/iommu/intel/pasid.c
> index 3239cefa4c33..953592125e4a 100644
> --- a/drivers/iommu/intel/pasid.c
> +++ b/drivers/iommu/intel/pasid.c
> @@ -214,6 +214,9 @@ devtlb_invalidation_with_pasid(struct intel_iommu
> *iommu,
>  	if (!info || !info->ats_enabled)
>  		return;
>=20
> +	if (pci_dev_is_disconnected(to_pci_dev(dev)))
> +		return;
> +

the long commit msg doesn't tell the fact that this is not a full fix.
surprise removal could happen after that check so there could still
be chance seeing timeout.