Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp261174rdb; Mon, 29 Jan 2024 01:02:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IGImemfNNulahg7XpGh8iRMgpoYIE19Nc+XH+wo9mhNlliDzHJsiIN8iXFoZ84p9v7OEZFz X-Received: by 2002:a05:622a:14c9:b0:42a:540f:db20 with SMTP id u9-20020a05622a14c900b0042a540fdb20mr4643996qtx.111.1706518971843; Mon, 29 Jan 2024 01:02:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706518971; cv=pass; d=google.com; s=arc-20160816; b=OhkC7xWFCO3X1ytrpUu1Io3dIvVUmrK5TpTtY3fqOaJEWm7sn2+2L/G4hlchBYvNCF DQIWxdAJA9mJvHZ8OLeiGUe3eaJavQxiKKAlF2vUyXRRy1HXYP3eYX8iY4qbWcSJQr1N 7B72kc1sFmbikmR0IPZHPC4JE8z0zHeOxhSZHvGoETR0tFpTCVr0RAmZtMCW+AaQsVqs 48hHamNo37txT84gVhibXNh80zhF8Vcz2uQM15WDFK77r4S0apaIOTk9nFAFrC0YJlxy vav4asQ4Jo6C8lCtfA3NAT2KqUYg7KgXYgDRuuEg2qWEA0QDIqBIdtoXXyZcCs1zW40z CXrg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:reply-to:user-agent :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :date:message-id:dkim-signature; bh=cYevMNeoNktot3JAMstftSYPsRaaLyjRhS0LapjonnQ=; fh=W47hZLA1eBjs+U5qCcCP6KyqdUaTdZyetP3o5YeYMmU=; b=nDyN4afNHm/UJ98oZIgfYOdrHcrAKzVxWZ6Vc18owB+IQXXEdbM+7XG6dSAdaYA8n/ L3aXxB1bVJnTVEzx04RTOH8AftJ7Q+z3ZI77ek16W/daZkTgJa8ztfdr/A29pTGhoVqR BGLOGYiZIZigRcIkWTOsnE6VBwkKgwa5zxAm36lmOlRlzOY29qC71bAdJHp5gGQq0FZG 6O1ZFfxiGy2Dz+I1DjuZx2n1Us+F3vhRxrJTY6Utc4gaS7mVcC3G4MpUgM6vKqYGmjue czlz+8ppjzdYJWsP1WCIRapQM45okWVP3FuiOJUNIGCVrSmlJCwJJXaSqi0IJCM5an+F H8Cw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RZIiJg4E; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-42399-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42399-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id c6-20020ac87d86000000b0042aa1660162si2167678qtd.332.2024.01.29.01.02.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 01:02:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-42399-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RZIiJg4E; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-42399-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42399-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8C51E1C228CF for ; Mon, 29 Jan 2024 09:02:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7077454F92; Mon, 29 Jan 2024 09:02:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RZIiJg4E" Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D42DE54BF1 for ; Mon, 29 Jan 2024 09:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706518961; cv=none; b=L9c7SbCGjJVonwsvrB0g5q2m7M6X7BVojqDpPLnUkuwdcpDBHkXhDyTMeX9t2ufjF1VIlvGaGBmhU55/RmJpLjL1KvBVTBsztrnC/fj5d3Rpdn26IsmyGgPeYS1XAlFMCCG4IYacnxrE7w10FZaSD3C5sdsDSWBXxotVefY/r+8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706518961; c=relaxed/simple; bh=X1zJ7Cq8bAtVtLASw0Rg1H/ttk5L9TXWNZzu3ejEejU=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=nBEdE7NGfgjj2MhMT/SSHKoNX9N17Nc739PzHgZssi+xfOUTKn5405/3Bs0jX7bwoq909DJ9G/hcAQJ/6clzCPDXQkZuhHXqNjr0AfOBjKye9GGBuFZXi573cfcSJ/RUWoL4xqHPiLqGU3VW5taM1ty9vgDdVl2uOnkD6CBvW10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RZIiJg4E; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-40ef6442d60so6268415e9.1 for ; Mon, 29 Jan 2024 01:02:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706518958; x=1707123758; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=cYevMNeoNktot3JAMstftSYPsRaaLyjRhS0LapjonnQ=; b=RZIiJg4E7W1RhsITe6CGmpFceCd6HNrVa0jzAvHDNlantalOf/uZBARo7iwIJkBDha O/+615UE0zPcm6EPF/PBBaWPR2Wv2+X5BNPYf3WvhWYR1TptR8ISHEVvN8IKTtm34khO 0WjbB6LdDPcD02x1mtaUHXlU9+9/hB4thjDINgXz2YhUwnLv6iYS+AYJFkXhfal7OVjc Hr7s7ekHxita+EYAZp3xCymIHRNSnq6yabxwWew9eY7WjPRRYmdm5636vZqPZTUQGw5x k4Ap22vflXkDohyCV50CMXpInmkiRRcQyy4qbwxuYVJ52AOSa58o+LxgPZi2zh1DLGr2 Ev9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706518958; x=1707123758; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=cYevMNeoNktot3JAMstftSYPsRaaLyjRhS0LapjonnQ=; b=WNoBBhQcLFDj2nQus7DxXLjyW9On9SEQWL50c5fqQQ1fwqBoohod5IpiBu/QwarJ1E geLACRGXn+bbKEi6RPWyrqm9nu3V2BZJQpelob/bB1GjaPjr3p5rwJ3KesSuE/yiZI9T x/0lNdhwNs+pAQjSM+7m8ubMb4ogNIC85BKrRgx3wGNgt8Mr2L+kixoP2El70SqFj/hq KpGiWTIV4y+fCWzmKHpxtr3fQhdLvyssPhXKCiyCoyT9l9NOYPehGEKDDPscvfbbaeR3 SyEIwdf1uk5rsd0ZezgcycjcxAOudN5t/lGB8qe/yYRaslr8T1u31E5TXfF0OWtDeyq1 l0cg== X-Gm-Message-State: AOJu0YxAtnuh2VquF9gtl0ViLJruFibLygZHjlYl9spHQYZKxz8paQfe L6+vC4VwlJDgXYa1y0P3zdalHC8VbSNqWLHzHZW5mwH5MmL6868KJYRPS6At6+4= X-Received: by 2002:a05:600c:45c9:b0:40e:b6c6:89ee with SMTP id s9-20020a05600c45c900b0040eb6c689eemr4674772wmo.38.1706518958119; Mon, 29 Jan 2024 01:02:38 -0800 (PST) Received: from [192.168.7.29] (212-114-21-58.box.freepro.com. [212.114.21.58]) by smtp.gmail.com with ESMTPSA id r12-20020a05600c35cc00b0040eac0721edsm9554855wmq.3.2024.01.29.01.02.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 01:02:37 -0800 (PST) Message-ID: Date: Mon, 29 Jan 2024 10:02:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v14 2/4] Input: add core support for Goodix Berlin Touchscreen IC From: Neil Armstrong To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bastien Nocera , Hans de Goede , Henrik Rydberg , Jeff LaBundy , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231221-topic-goodix-berlin-upstream-initial-v14-0-04459853b640@linaro.org> <20231221-topic-goodix-berlin-upstream-initial-v14-2-04459853b640@linaro.org> <98ed4ee9-f381-43a0-a5cc-523ad108b374@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: <98ed4ee9-f381-43a0-a5cc-523ad108b374@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/01/2024 16:08, Neil Armstrong wrote: > Hi Dmitry, > > On 11/01/2024 08:20, Dmitry Torokhov wrote: >> Hi Neil, >> >> On Thu, Dec 21, 2023 at 04:21:20PM +0100, Neil Armstrong wrote: >>> Add initial support for the new Goodix "Berlin" touchscreen ICs. >> >> Thank you very much for explaining how reading of additional contacts >> and checksum works, it makes sense now. >> >> I was a bit unhappy about number of times we copy/move the data over; >> could you please try the patch below to see if the device still works >> with it? > > Sure, I'll test it and report you. Ok it still works fine! Sending v15 with those changes and rebased on latest linux-next. Thanks, Neil > >> >> I also shortened some #defines and defines some additional structures. >> Also as far as I can see not everything needs to be packed as the data >> is naturally aligned on the word boundaries. > > Great, thank! > > Neil > >> >> Thanks! >> >