Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp271377rdb; Mon, 29 Jan 2024 01:29:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IECrz9jNEab2ySM5RlJXBPJI5lX76DmCPphnzpIal8sqILnQHYLip4spOYNVJlxnZ1LHYh7 X-Received: by 2002:a05:6214:230e:b0:683:cafb:5921 with SMTP id gc14-20020a056214230e00b00683cafb5921mr6279271qvb.93.1706520545983; Mon, 29 Jan 2024 01:29:05 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706520545; cv=pass; d=google.com; s=arc-20160816; b=GJoo+JozhIlCoo402YiR1WWdbb9brV6oEkvfsbCAAWciyY/ws0eELxdafxCJGxmnt+ BiYt654Tt122iPDiahi4RaazJRdi5WNbefkFKUY540jA2WMwODj3JXHmKmwzAf6Jq+/I JCYhBhVehTC6L0YP4owbGDBZ8q9c1AzKR/3KWm8j16qTxseNK4s5aJ+oJG+3mREPVb/B MmdYFGlpiTx4y0LoKjc2xd/W9bDkRS8/xXAwOGhpLncw6IBH5Gd8/8QABwtF90odZOFG E1NDMdT+DjkX+FBkW235e5eGghi9MPSj3fM2urNKCE9I2Q+fW9zDDsUN2qIOJ1GgjLEK SlJw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=hn9qNS4wUmMn0/IedVdqEWa8YsnO8548Biok/rcVaBY=; fh=UtjiNYbYZwpSkQBvFYcjoqZCLQVWRkcJXV3l/BIBQoQ=; b=p9MVtzYmwEo8HCKLYguDYyy+dGss7i2paiKVH9y0AkulvnhmGs6ZGTroP43JLw1tOS PhpaLLJFkYG7StQaY5K7ZancVPFyUL8VwDRC7B3L7RGxPg3YzuwDyVYNxLmfgyxboHwi 3OJOBHgJW/2/WgRLL7do5111daveS0sCsWPKDYXI3hK1JTFH3Fhb3t/8bU47xA7U4+4V +ypdqS7N/wFTMVFNvPSOJjdlJHV8V08PJ7KQDp95QqkO4vRBfH+PfPwPfS2C9j0pr+PQ Xu6mkqDl6Den3NFuQsa6uHIFFWBpGStI0vd0tKIu9ZojQmydWFk86O4Qjd0QwOhJKr+l x2ww== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VGIyFfbZ; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-42452-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42452-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id gi2-20020a056214248200b00686af113368si7390662qvb.381.2024.01.29.01.29.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 01:29:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-42452-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VGIyFfbZ; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-42452-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42452-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A31211C21FC8 for ; Mon, 29 Jan 2024 09:29:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4E15855E74; Mon, 29 Jan 2024 09:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VGIyFfbZ" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3E5055790 for ; Mon, 29 Jan 2024 09:27:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706520456; cv=none; b=baz27VsADwMrlzioW2VT+mf4IvqHlZscOYnga5d1oz3uR2LKWN997xk9MrIaELcsJxkjUaebJ1PZ1SVUbzIrZefzSJUJmiUs4w/KwyvPtuTj4YdsXfTCQa/94vA+Hxkdhnbhc2NPYz9QWqO6MKr4qKEKL7Ksr66QKbYfvorHxzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706520456; c=relaxed/simple; bh=hn9qNS4wUmMn0/IedVdqEWa8YsnO8548Biok/rcVaBY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sqAUirHpSL4A1kQUWy4mIVreZM0Wny9ai+t11dMKZz8nsZzzcxudWYw2T1tZbGEvTfc9/vwYHOjhmMecCE69iRii+JbtNK3WLfNgLC0KCLmM2onBkLnEmTTRqZ2g7N6P/fQbnl9mEYJ4/KUHgRrxgAed25wQ76e38wk2Zmzn9gs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VGIyFfbZ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706520454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hn9qNS4wUmMn0/IedVdqEWa8YsnO8548Biok/rcVaBY=; b=VGIyFfbZKwUScI7tiNKWbgBMqHSYffnwW19m1T2W4QfbS1Zf6zyUdS2ZgYKsIV6DBYlWvs DYLbHmsxcdK1N2Ryd4kBXIN8Xzt5nLtezQfaj9d44SwbxWWy9P+3njvqkoCaHBIAiPGGnq pRfn0Mst140Vka+CiNi4Op+tATK5ZDQ= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-cfSRzuhYOGiFnYj4rDjiTA-1; Mon, 29 Jan 2024 04:27:28 -0500 X-MC-Unique: cfSRzuhYOGiFnYj4rDjiTA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F01D61C05EB5; Mon, 29 Jan 2024 09:27:27 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.39.192.173]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7C876111E6; Mon, 29 Jan 2024 09:27:25 +0000 (UTC) From: Jose Ignacio Tornos Martinez To: masahiroy@kernel.org Cc: dcavalca@meta.com, jtornosm@redhat.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, nathan@kernel.org, ndesaulniers@google.com, nicolas@fjasle.eu, stable@vger.kernel.org Subject: Re: [PATCH] rpm-pkg: simplify installkernel %post Date: Mon, 29 Jan 2024 10:27:20 +0100 Message-ID: <20240129092724.10064-1-jtornosm@redhat.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Ok, I will simplify the check to copy as you say (cpm --silent returns error if file doesn't exist) and and I will limit the indentation to the modifications. If you are going to modify the rest, I think other style changes are not necessary. Thanks Best regards José Ignacio