Received-SPF: pass (google.com: domain of linux-kernel+bounces-42494-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Sai Krishna Gajula <saikrishnag@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri
 Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Subbaraya Sundeep Bhatta
	<sbhatta@marvell.com>
Subject: Re: [net-next PATCH] octeontx2-pf: Reset MAC stats during probe
Thread-Topic: [net-next PATCH] octeontx2-pf: Reset MAC stats during probe
Thread-Index: AQHaUpimwvoWGDyRoEKlOp7YcAsKuA==
Date: Mon, 29 Jan 2024 09:50:53 +0000
Message-ID: 
 <BY3PR18MB47071D86D89384FFA46286D3A07E2@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20240125110601.124209-1-saikrishnag@marvell.com>
 <20240125172803.01189ac4@kernel.org>
In-Reply-To: <20240125172803.01189ac4@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?eYIokhQjnoAP+t9+wVUta7h1YMr8YUngL7vLQAjhAr63BYA2aobL7t6lu129?=
 =?us-ascii?Q?TfoLsvmucuGd9dlirG8LCTi7WDRyAl4bLS0gcsGAWVMxgqbiZH6X9VG9OEJY?=
 =?us-ascii?Q?O2NeAiAu26D/0uNHbIWGqqYN7Nv/OEnYv19ZOQA7DV4GgliaTC6fBncpyaFX?=
 =?us-ascii?Q?oOH9lIs5ydxk9lQHUbs9aBWHapVLHRycmPkIH4dXKETouYYiBdVIsCcyx9eS?=
 =?us-ascii?Q?snU7Kjk7E5jyco4SDWL2ywKSzEhUJ3hOw04rgw4VswGVqxHGFBty1XS42bdC?=
 =?us-ascii?Q?pPwVlaDysa4uhBqXESHbBj6uOjjsrI73CoIad+W4+ldsLeCcpcAz9pquidgn?=
 =?us-ascii?Q?K9K3Qs0d+feOitm/l/hcu4OKsyVf6vEi0s13pwhtFBPLQJ2TmY2F8+oRfRyA?=
 =?us-ascii?Q?D3zZuXhFgYgh1fNcVt63TomOFMEGOnJbd3bshJ21gMGvA9yIPKtTazdA96ml?=
 =?us-ascii?Q?ScQOAmA1RGlCAQj5XPWzTKK3FpKSk8InfCabKFgvwqwrYnCq2uNIvnBEl48s?=
 =?us-ascii?Q?Wrgl0ia27tFZKpSwzKnagYR03JQ4frUnFUIoM9AI8D/g8YrdQt4FOPLVE9wC?=
 =?us-ascii?Q?SatArZMZWRA2hZYBZE0G+8KZZxQKI/jAc+ECIYMmBdVUyg/zWb9jQF2+9nmf?=
 =?us-ascii?Q?Ypu2l+6Ep481RumYsln1F8cnByPzOU+utLW7wZ+srA3vk/rAAAoFxAsRu55b?=
 =?us-ascii?Q?UcqlpeiAfcAgE/pJg7NAbEeTtj8ns+WvP2sFiCW/f5qV07Z+ya3sT4MwGx98?=
 =?us-ascii?Q?tQ/weByUSDFYtUhANgCPvpd79wKsBuxOc7GWvEeFUwDsjaxP4p4IuokdT0Vt?=
 =?us-ascii?Q?MJiLihQrOjCtciJ4ZQzdYy8g4+QYISy0Zw6+4XHykTIzekENihfvUKwAjJHr?=
 =?us-ascii?Q?ehheP4bDscgDtCy07a06xSgF6W03+VcugXMElyXVSNVSCEtf1+zwFNkeCgAf?=
 =?us-ascii?Q?GRPH7ssgXFtaGdqQAbz8AIteRIjPv6HggPCnPUXYrQONeQhRyQUm1rpTi0ya?=
 =?us-ascii?Q?ispfONommk1NODOiELtWsESpoE3pA23kYqfh0s55FFnmQgF/9ohkEv26fKHw?=
 =?us-ascii?Q?GIe3V4TRaPVnxVU39//PskCaLrhq51PvRgEIQqPc3Veg0ne/m9smVBhwwHiA?=
 =?us-ascii?Q?jY67U9DpANI5W6+GkiwPosW8LpW7PRUX6HTU5QitRXCxOH9yLZ4PF+YJbL4w?=
 =?us-ascii?Q?u7oJFGpo1nV7QX0cgtRdVfc1vRXDdZg8BHHgvOvo0PK42KCcfeH93+5DgRqY?=
 =?us-ascii?Q?PNie6h9Q4BguxIAsbxqs1rnkqJ/C0ydATJDNi1M2BNmwrGL9D9I5HS8HylLB?=
 =?us-ascii?Q?Zhuj/7H0XSd0BlW8NOjkymAEBxpR2IB31hshteZyoP7fLFv4pTlWBdF5abO7?=
 =?us-ascii?Q?3OLZRvUdE6ZS5jQlrKKzA4tnXxHi2rftPRPQ4gXWuOFI/WPVATjYqP2KIIU6?=
 =?us-ascii?Q?aGiz0p2hrCwbdeegYYXTZjRK41DyYF/2okW3UcuA1DGjcvu5o80MLNWV+xPX?=
 =?us-ascii?Q?qSXpZMle5ovE8LIfDpDQlbCW+q76UrQu3kspuwAKsRwX+haWwE6BoD/+luXU?=
 =?us-ascii?Q?yfpQoBdjJZVQEohopnj8cSkqr9q4N0kEWnsz5whs?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f2e7bbb-7bc6-4da0-428d-08dc20afc8a8
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2024 09:50:53.7211
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: a6WDwLa4aljjV2uSNuxieuEcE+cnki3ELgcUvncC5N0aNIuTutBLK67XM2udcqcvPwrvw00/40OsljMu+hyNpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA2PR18MB5886
X-Proofpoint-ORIG-GUID: u072UYNMNr7Bk4-iwYe75R9-nPihFbxb
X-Proofpoint-GUID: u072UYNMNr7Bk4-iwYe75R9-nPihFbxb
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-29_05,2024-01-25_01,2023-05-22_02


> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Friday, January 26, 2024 6:58 AM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri
> Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
> <gakula@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
> Subject: Re: [net-next PATCH] octeontx2-pf: Reset MAC stats during
> probe
>=20
> On Thu, 25 Jan 2024 16:36:01 +0530 Sai Krishna wrote:
> > Reset CGX/RPM MAC HW statistics at the time of driver probe()
> >
> > Also added a devlink option to do the same at runtime, this will be
> > helpful during debug.
> >
> > Usage: Reset MAC stats
> > devlink dev param  set  pci/0002:03:00.0 name mac_stats_reset value
> > true cmode runtime
>=20
> Where are the stats reported? It'd be more intuitive to add the ability t=
o
> reset stats to whatever interface is used to report them. Or one of your =
reset
> interfaces (devlink dev reload).

We are using debugfs interface to report the stats. As you had indicated pr=
eviously not to take input to debugfs, we implemented devlink interface to =
reset the MAC stats.=20