Received-SPF: pass (google.com: domain of linux-kernel+bounces-42733-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <d6bef39c-f940-4097-8ca3-0cf4ef89a743@amd.com>
Date: Mon, 29 Jan 2024 13:52:33 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 5/8] iio: core: Add new DMABUF interface infrastructure
Content-Language: en-US
To: Jonathan Cameron <jic23@kernel.org>, Paul Cercueil <paul@crapouillou.net>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
 Sumit Semwal <sumit.semwal@linaro.org>, Vinod Koul <vkoul@kernel.org>,
 Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
 linux-iio@vger.kernel.org, linux-media@vger.kernel.org,
 dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
 =?UTF-8?Q?Nuno_S=C3=A1?= <noname.nuno@gmail.com>,
 Michael Hennerich <Michael.Hennerich@analog.com>
References: <20231219175009.65482-1-paul@crapouillou.net>
 <20231219175009.65482-6-paul@crapouillou.net>
 <20231221120624.7bcdc302@jic23-huawei>
 <ee5d7bb2fb3e74e8fc621d745b23d1858e1f0c3c.camel@crapouillou.net>
 <20240127165044.22f1b329@jic23-huawei>
From: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <20240127165044.22f1b329@jic23-huawei>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OTlXWEpqbGhlTXp5Q3BZQmNNZlVLc0syYVJiemJGRERkY3NuN2tpQmF6b0RY?=
 =?utf-8?B?WnBDdUJKTmRwWnlBZHJSZjJvUEVqSEo1VXdwRHYxVmJtaXl6RGFCeHJMeHNm?=
 =?utf-8?B?aGFIdDRRN29oMCtzNnl6ai9QZStBZmVvdFJrRDI1MG0wUGR4UlkySGFiQUpq?=
 =?utf-8?B?ck5kQUR4cFNxdk9KeEViekpjZzhxV0dTUTJ1VVFRQTUxWXdxMUt0UGhIRFlj?=
 =?utf-8?B?VXQ4b2VwdGJWYnduQXFLYWp0SlBJc040Q2hUbldWWXhVT2taaGJsMjhXc1o3?=
 =?utf-8?B?Qk9RdGx4cktwTTEvcWErOTFIOFZ2cnlJK1czeDZMb2crSWNWcUVJeGM5Y1F6?=
 =?utf-8?B?cmg1bFE0TURNRGN1QlZsbzl3SDFsYi9pVHlqUExISEN1Y2t1dm5hZnd4d3Vv?=
 =?utf-8?B?ZFhsMW43ZVlQWG9iNExnMlhjbldHT09nSmZWN290eW1PTFBBeXdhTUVkbDRy?=
 =?utf-8?B?eUZlL0NtVVRTNUNBYnd6cjVXSWFscWl6eS9CMUdRbWdGRTcrbmpCaFVRY2JT?=
 =?utf-8?B?MjJQRnovSHhMTTl5MXhDb0lKY2tOQUM3Qzh5OFZBck53UnRiQXQzdEJkeU1v?=
 =?utf-8?B?dFQ5SHV1MXREeU50RGJuanpBZmowN1psUW45TWZnMGMxb2JEV0o5WWVtVkhn?=
 =?utf-8?B?SmFSTDFYM3BZaHp4d245ZzNnWkZwMExxRk9IVXRWb3NhZTRYMFZjVVJtQkx5?=
 =?utf-8?B?R3ZUbWUzZ2t4NytZRWovTCtpcGhJQ3gvR3RTcjF4eXlGeVRhcEtrajVidXU2?=
 =?utf-8?B?VUdXZzdsYWpqM2pIU0JEL1B0VUJIQnEvMWswUW12UFR0a0MzWlQyVXZxdnVN?=
 =?utf-8?B?THl5STJmdzQ2TmJrYmYyQlVwcEthVDg4VWRUa3RQL3dMa1lPOEI0UEd0UG5G?=
 =?utf-8?B?S2ZjRERLODFSQWYvaEQ5MGY2YXhrNHJ0S3ErWk5PVk1ZWTdKZmRIbW9jWTda?=
 =?utf-8?B?RUJxRHdXUWZxN2Y5ZXBQL0xLTDkwRWNBSyt2NGNpMUhBQll2QmlsWDhlN0ND?=
 =?utf-8?B?bElOVDZZR0g0L3lOak1YL2NJV3V6eGFBa040MytMVVBEbzdDdDlhNDVaU3dT?=
 =?utf-8?B?dGJydG1YZ1BQMHFIUGpIbFVNenNsOGk2UWlMbEFSVU5QQ3RJUjgxZ25CWnZ2?=
 =?utf-8?B?djdpTllSQ2pORWRoRmlCVmV1K253dVZvZlFvNXNWcG85MUdMWGtlKzRkZDZY?=
 =?utf-8?B?Tm5ycFc2dDk3WXczSlJBTW5reDZyN0I3dlRxUlRCSkZkeXd1ZFZiQ09hcHVR?=
 =?utf-8?B?bkM1TmtxMUV6Q0w1STJndTEvYlBkOTIyMGdTSjJKQ013SE54VklwbzZhN2dT?=
 =?utf-8?B?WEFyRisrRWl0WExWbE5Ua1h3bEpmZHIwQ2NvYXZIdTNUdVAzUVpqQ2JWNVlm?=
 =?utf-8?B?MGg1Z2dobWR1NWdHNnh1eC9pNHJjemJNV0NNdk9SZUJXU2hpOEo4MGpqc2dS?=
 =?utf-8?B?c0FPVVcrekZma2ZHOXRRdEMrRVNpdlRqTENLYjZsTTBwOVBtQ3RIclFqZEpr?=
 =?utf-8?B?azVTRk8waUtZdkZnU00zZ1RxOTZhaWM5MWkwajFVZ2hTVU1CeTdhSDJteWU2?=
 =?utf-8?B?NjJYYmV6OUkrRWw5Z2VPcGZ3TUJTM0lvakxHUmtodTJ6aXBMTDRrTFhYdjIz?=
 =?utf-8?B?ZDJLb0dtZEE1YjhOaE5SWWFZemZDT1I2YVpwUEhwamNiS1VGb3p5Z2lSQ2h4?=
 =?utf-8?B?dFlEQlk2allCZ21rMkV4TFNURklxVzlnS0VJNjNqUFhpWmNmNFo3TXBIUWhW?=
 =?utf-8?B?cjFTSzNDWUl5K203aWdhNHZwbVBwQ1daZ3dQQ2dlWjV0RnpKYytnc1lYWjlN?=
 =?utf-8?B?eUZFMzR5MWlsQ3RuRWVZQTdxVTl2L296OWpqV1dkckxwNkl6ZElLTUs2TlBP?=
 =?utf-8?B?U3NYbGZybFUvRWpLNWErSXpHbTlDTjAzVzJGTjMwV0NXblFZc2NMQlV2clh2?=
 =?utf-8?B?Z3Z4b0daRG5aeDBzc0dqUklwTmRVOTE1enFMUG9tNG0rT1JqMWlmT2RINUov?=
 =?utf-8?B?djV1NGVJalh4dC9IMWdwcU9qR0VsRzkzMjJQaEY5N29yVkpDQjZ6T2tlTDho?=
 =?utf-8?B?czhTK294OVlDK2N1cjNaRHgrNm9DbmdGYWV5dEluWHY1NTYyeTFMSzZqYVNN?=
 =?utf-8?Q?ERZmOhw0x03hSZeh+OY9JMgFv?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8a38a3a-476e-4675-56a4-08dc20c92da9
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 12:52:40.9135
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bZGa8s5yG7LOLlWGwtAGcrvr9+q1im6/XZZPYGmED7fcCr2V2FEY4qUQ+wnnPiTu
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5515

Am 27.01.24 um 17:50 schrieb Jonathan Cameron:
>>>> +	iio_buffer_dmabuf_put(attach);
>>>> +
>>>> +out_dmabuf_put:
>>>> +	dma_buf_put(dmabuf);
>>> As below. Feels like a __free(dma_buf_put) bit of magic would be a
>>> nice to have.
>> I'm working on the patches right now, just one quick question.
>>
>> Having a __free(dma_buf_put) requires that dma_buf_put is first
>> "registered" as a freeing function using DEFINE_FREE() in <linux/dma-
>> buf.h>, which has not been done yet.
>>
>> That would mean carrying a dma-buf specific patch in your tree, are you
>> OK with that?
> Needs an ACK from appropriate maintainer, but otherwise I'm fine doing
> so.  Alternative is to circle back to this later after this code is upstream.

Separate patches for that please, the autocleanup feature is so new that 
I'm not 100% convinced that everything works out smoothly from the start.

Regards,
Christian.

>
>> Cheers,
>> -Paul