Received-SPF: pass (google.com: domain of linux-kernel+bounces-42761-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <fad515ec-aba3-4f48-b8be-ebc6640899e3@amd.com>
Date: Mon, 29 Jan 2024 07:09:37 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCHv6 10/16] x86/tdx: Convert shared memory back to private on
 kexec
Content-Language: en-US
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>,
 Peter Zijlstra <peterz@infradead.org>,
 Adrian Hunter <adrian.hunter@intel.com>,
 Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>,
 Elena Reshetova <elena.reshetova@intel.com>,
 Jun Nakajima <jun.nakajima@intel.com>,
 Rick Edgecombe <rick.p.edgecombe@intel.com>,
 Tom Lendacky <thomas.lendacky@amd.com>,
 Sean Christopherson <seanjc@google.com>, "Huang, Kai" <kai.huang@intel.com>,
 Baoquan He <bhe@redhat.com>, kexec@lists.infradead.org,
 linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20240124125557.493675-1-kirill.shutemov@linux.intel.com>
 <20240124125557.493675-11-kirill.shutemov@linux.intel.com>
 <f0677a02-72ea-49e8-9499-18eca6b5e8d7@amd.com>
 <r5logoyy46fztohkm6bjobomsrst2izbs2nsts4fegii2uswca@fovizly7y5ju>
From: "Kalra, Ashish" <ashish.kalra@amd.com>
In-Reply-To: <r5logoyy46fztohkm6bjobomsrst2izbs2nsts4fegii2uswca@fovizly7y5ju>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QVRPK3lTeHIxVGNiQThHWmtIM2Qva0w5MldQT3FIcGVRWDIrYTBXYStjaVJk?=
 =?utf-8?B?ZllyK2J5MmFkWFh4azBtVUJTdzV3a3NWVUxZRVZNdkhxaUxxKytubUJPMTJz?=
 =?utf-8?B?RVphQ0tuSmdpaWVtTjhUc08xRUo0aDdoT09XeXI2VGxnMkZUNXZlZkpSR1lS?=
 =?utf-8?B?NEEvd0NFRjd1ZFJDQWJZQnU2YTBpNHpPNUdiVkY0YzFqak5rWkV4b3U1Tlhq?=
 =?utf-8?B?VVo5dlJXY1RhK1JYbWFKc0FaZDlGS3EzRkRqZ05RQnFycXZTL0VqcndWUldt?=
 =?utf-8?B?a21sSGNXTTBxTitodjFWQjdidVhrVzMxYXZLaXl0bG1pZ0FBbFRqaEZleFpa?=
 =?utf-8?B?eGViOXZtRDBmQlkzVG9vb3J3YkFod211cUVEN0ltMTJrbE1HTS9aN2FPSFg5?=
 =?utf-8?B?MFNjLzBTODhkYkgxTlZBN3dSR3JSSlJRWENOQjhrVTQ4cnJLYUIxSTZXOVNm?=
 =?utf-8?B?VE9qa2FtbWwvdGhSY3ZTc3Zrb3h2Mk93YUZQdlc5M2VlaGlkajA5ZEpJdjAz?=
 =?utf-8?B?OEg5TE1nWDJwUzZla3p1amtObG1KTFFRSUxMSmdjMjBZMGVYK0tyYTN1QXRh?=
 =?utf-8?B?MGhSMlFYY3piTS83M2xRZ2ZFWkRsc1RXZTYxRnA5Wk1JeTd2bFU5UVZPYzdS?=
 =?utf-8?B?VU5telN0eEptWFBobnArMTVFTitYWXdadFJyUE1HMmRnK2tWNGdTUkN1VlhT?=
 =?utf-8?B?Vm1TSDFrVHo4eG5JVEhTcUM2NCtNbDBma2RKNER5eTdGa3VMTlFsMjFwZUt4?=
 =?utf-8?B?djFDbTRtR01xMGFqcTVwNUdNUjVWRWNBMHdmbXFYdHpLSlVub1lmU2gxclhW?=
 =?utf-8?B?T29ONzJuTmZRYTdUcTJGdGxGQ0NsNUh1OGF6dXd2cjI2NVAwQ1hQSkYybWI3?=
 =?utf-8?B?OVJRUHF5WWRtTm50ak9yVXBkWWFkSkxCMjU1cXNqQ01HY2tqNUdvaElnYThy?=
 =?utf-8?B?MW9EZ1RIT0p0cVZhZW83R2VHb2lVaWpVVURuTmdOalFyc3YveTVvWndWdnVw?=
 =?utf-8?B?MUxQYVFEejFpUWdzMHV0US90ZU9HOFMxMG5aS0VjNlpkYVVsVkVXOHFFR3Vu?=
 =?utf-8?B?OUoxMEdRL2I3Vjk3NzVXeU1rVHFQY0kvYVRZWFdka3ZXMVpxV0NxYkxWYVpn?=
 =?utf-8?B?Uk14bjlnSyswb1NaNnpEbnNtWSsveXdPcEFwQkFEdU15RW51YlNsejFsTmxV?=
 =?utf-8?B?a2R0TnpLNEV4MjZSZVI0TVhVa1J6N1hRb1FmUktRQjNreVdrVEpuYXBSbFg2?=
 =?utf-8?B?UG1hblRyQmdIcTdUeE01L1R1SFdLUWQwM0hqKzZvWFNHakswWmRzRjBET2x1?=
 =?utf-8?B?cWllc2prKzVzVCszWEIxVVBIemJpQW4wUy9paUtsMW5ZQUZyNjlETXR5Y2s4?=
 =?utf-8?B?T0hpMkRUUFZvYmxBbUFFc0FSR0graUJxdnJZeUdOQTRxVUZiYmM0YUVVNmJv?=
 =?utf-8?B?dStob3kvajRKNWV3eENIbU5xeDR0RlRVM3FPanRvaEFwcFpnL0FtTVNTc0tO?=
 =?utf-8?B?aExEczVlNDYySmpDZDVEdk9LWlFVWmtRWldKNWFMeXlRNUxsVWppZit2QlAx?=
 =?utf-8?B?VW1TRjB0cWQ5V3dPZkIwaER6OHJ4Zjl1YUlJRGY1QzN1c05yK09hTzlWd2tZ?=
 =?utf-8?B?dWp6bCtzamhiREtMM05mMEp4aUlFT25RMmN2amI5TFRBcDVrTHdyS2JMZUdH?=
 =?utf-8?B?bnlXSWIyR1h3R2UvRjVKV2RRRndKUWp0dk1seXExa0JqQTNHeVBCZWJFR2Fs?=
 =?utf-8?B?YmtnTGNTS295NFRhRTIzK1hNYmpiTEhKSmQ4bUZEdGhtUndHdjlsVlVEbUVa?=
 =?utf-8?B?ZjhyYTlleXY3cmZWeHdrSmlqSVgzM2JXdVNHV1ZzTkVwYUlnQjFuS1ByWnpu?=
 =?utf-8?B?QnZDV3h6Um5kTHd1U3I1SVFwZ0hpdEtmSFAyZ1VyQjBHSS91azBxV3ljL01C?=
 =?utf-8?B?aUNQS2F5NHp5a2xSMHpiSXBGUHdaZFEvM3JiNHYwZ1lQbk9EdHYvL2VUcVU4?=
 =?utf-8?B?ZU5kVE9IN1o1bmUxOXgwQjJSZ3lEK3gxNnpkR054SC85R0RUK1BVRlhhbUdu?=
 =?utf-8?B?VDdtTkxmSitrK2VaVis4R2tYUkV1Q3RYQldQK2NESUw4VnVZekJ4dmZxdjFW?=
 =?utf-8?Q?q1HRFvLQ0QkV3BnmPtgj6YpjA?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da58bf17-4f0d-47fe-7335-08dc20cb8cc8
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 13:09:39.3309
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CEc2VcGq8DyXMhcSBVXCfx/3Ib++azGCp1Hbxc+zqLydNpq8OQ9dwARlV9IKerFxoO3817Z44OR9ZvkIjEE3cQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9158

Hello Kirill,

On 1/29/2024 4:36 AM, Kirill A. Shutemov wrote:
> On Mon, Jan 29, 2024 at 04:24:09AM -0600, Kalra, Ashish wrote:
>> In case of SNP and crash/kdump case, we need to prevent the boot_ghcb being
>> converted to shared (in snp_kexec_unshare_mem()) as the boot_ghcb is
>> required to handle all I/O for disabling IO-APIC/lapic, hpet, etc., as the
>> enc_kexec_unshare_mem() callback is invoked before the apics, hpet, etc. are
>> disabled.
>>
>> Is there any reason why enc_kexec_unshare_mem() callback is invoked in crash
>> case before the IO-APIC/lapic, hpet, etc. are shutdown/disabled ?
> Not really. Either way works for TDX. I've tested the patch below. Is it
> what you want?
>
> diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
> index 6585a5f2c2ba..3001f4857ed7 100644
> --- a/arch/x86/kernel/crash.c
> +++ b/arch/x86/kernel/crash.c
> @@ -107,11 +107,6 @@ void native_machine_crash_shutdown(struct pt_regs *regs)
>   
>   	crash_smp_send_stop();
>   
> -	if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT)) {
> -		x86_platform.guest.enc_kexec_stop_conversion(true);
> -		x86_platform.guest.enc_kexec_unshare_mem();
> -	}
> -
>   	cpu_emergency_disable_virtualization();
>   
>   	/*
> @@ -129,6 +124,12 @@ void native_machine_crash_shutdown(struct pt_regs *regs)
>   #ifdef CONFIG_HPET_TIMER
>   	hpet_disable();
>   #endif
> +
> +	if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT)) {
> +		x86_platform.guest.enc_kexec_stop_conversion(true);
> +		x86_platform.guest.enc_kexec_unshare_mem();
> +	}
> +
>   	crash_save_cpu(regs, safe_smp_processor_id());
>   }
>   

Yes, this will work for SNP.

Thanks, Ashish