Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp387885rdb; Mon, 29 Jan 2024 05:33:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IG5i3z18OazBzgWrdi3EtL8NH6zVmJ4XzMS630jgZIZIyWakTnAlE1safiN26eOwKJAyOFl X-Received: by 2002:a05:620a:565:b0:783:6ab0:f15d with SMTP id p5-20020a05620a056500b007836ab0f15dmr5441607qkp.30.1706535205877; Mon, 29 Jan 2024 05:33:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706535205; cv=pass; d=google.com; s=arc-20160816; b=mYg+2riesohMV+pRkNn3sjjFRXeW8Ky1yVRS32eLpwlKre4ERgWYFOTh6MRRKHelOR QCujiSPnnEITWi069bZ+oN6a4E9DerMyvkzQh5ONnt9orAgsY6FtHI3/ZEJfbcjs/FBE wi9cxJiHa1KQdWECSWf1GSJ9VklK7IqEHBZwbgEOWx9WaTiBLXJ+JEeRVy4Z+06bznZv Y31ZJeJ4nQTLH8oxL5v1ZcKrLMBsFuPT0qQffLQKleMbx5lnFnU0pu6YX+/IMexZahCK HtZi8XBctMD7c9C/gxhBKAHo0Oob9W+OoxY24Y7bzyVqEEP06cozG2SBpPo0Bs6iseSI uTIw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=BK3kTu4rO51T+6hQ0GXL+VPtTV0TrbToYj9UeX6NjHI=; fh=Qx5rzi8t3OT5ySocIjA3t5+6Tsi0+E8yCSHJz/2Qnxg=; b=lfB2sGBtzIpYotDYP/PT4B3FA2q8+pw9Eqjp2uSLX45qzbMzR5ASMzJQJz88jKNMWO eTZcM2PwrNv6FY9YJad6Xb1AcSFOSEHeMWfIvMyJF+kWRezYpjTFubkk9aEIatnZ193R u78lToBct2kqdrjCP077IaizbzYuiHIeSWjwW+wyIdafa3iPDSY0Yunab1JPBztzy4ak t/iN47UmXGGI/P9ILdMnl0TFpWJxU/YW+lIyoyryPyfVcHCqrvCPFoYurFWNFFLmqcU+ 8thOGCxLHuhqA/wi4prANe19FZljycWnV+aCAB8PbGK0GhALzMHtOBTAuQXcPR9arCdB UhCQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=wl2qKrAS; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-42807-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42807-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id w4-20020a05620a424400b0078363796704si8196592qko.225.2024.01.29.05.33.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 05:33:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-42807-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=wl2qKrAS; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-42807-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42807-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 821101C25784 for ; Mon, 29 Jan 2024 13:31:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A45D9651AF; Mon, 29 Jan 2024 13:29:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="wl2qKrAS" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C25C867732; Mon, 29 Jan 2024 13:29:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706534967; cv=none; b=Noy0XNvDpI7Gwfsi5POqDtBwuaPJDOAfzOmHFWyPSh58fDJklGu+lJXf4z036a6Ti+uDCWGZp32HKWUrv4Ua5g8ov6PQFQ9monOmsknu5p3kZaCadeaa2DT50f5Qyy3rXOL4gTnMKxDbyEb9X5H3e+I8HsvVs9uLefhKteMv+V4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706534967; c=relaxed/simple; bh=b1pZyK7FsCUmhPlvju8roc6IUuWpgZNleb3xFjmFVeo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NawWaP1De/cfsgGizZnKYLLd7Nz+sY0TSAy3S7MCzwsPquaMaI+fzCf2x6vNclaLsI5+3iUYGiO4tzRgr5xfP28AgSYxOxD7zxIXLN98wnl758VUcd0AqNSe+TLY6O58Gjt/wt5HM8nLbQGr4N1nas1d66wK8k1u6azgZ9LYmUI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=wl2qKrAS; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=BK3kTu4rO51T+6hQ0GXL+VPtTV0TrbToYj9UeX6NjHI=; b=wl2qKrASfp/BvbBxyEVBLUfG3u ykI+KQnWsL+wI8c9s7TpjzZCUrnpfB3ZAUGyH0T/myQ8773F0GoMV100LR7FlWQF3UvVLgTxCDAQp xbt2ZG4lQtplPSlSKcLiFVr+62ZNmVg+MBcgXJ1t1HnaHcrcBf7Yq04WaHlyaWgrUdYA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rURhO-006Nix-ME; Mon, 29 Jan 2024 14:29:18 +0100 Date: Mon, 29 Jan 2024 14:29:18 +0100 From: Andrew Lunn To: Andre Werner Cc: hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC net-next v4 1/2] net: phy: phy_device: Prevent nullptr exceptions on ISR Message-ID: <57ea16c1-530b-40c9-8f94-973c9595923c@lunn.ch> References: <20240121201511.8997-1-andre.werner@systec-electronic.com> <20240121201511.8997-2-andre.werner@systec-electronic.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240121201511.8997-2-andre.werner@systec-electronic.com> On Sun, Jan 21, 2024 at 08:54:48PM +0100, Andre Werner wrote: > If phydev->irq is set unconditionally, check > for valid interrupt handler or fall back to polling mode to prevent > nullptr exceptions in interrupt service routine. > > Signed-off-by: Andre Werner Reviewed-by: Andrew Lunn Andrew