Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp429496rdb; Mon, 29 Jan 2024 06:45:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IGj6Unz1fYI7akVRQ1xnJvIIuNa9k86VnX5hzgQosbkCSAWCdoMG9RCZFMwXcult3m/m25t X-Received: by 2002:a05:622a:1b25:b0:42a:73e0:1463 with SMTP id bb37-20020a05622a1b2500b0042a73e01463mr6788752qtb.96.1706539506342; Mon, 29 Jan 2024 06:45:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706539506; cv=pass; d=google.com; s=arc-20160816; b=AeUG5rgrA95AkweaHImjkW3Y8GV8x+ZGU3SfP8pp0vFycxiB8o0WeCyS2VIPtveSk1 ikzbBO04m2+PbvahFa7aTw+XKcc0Q3MDqtdQ7wZJstYg4Fv43szPGwtqWqiqlrFwD0tW FimOQ67oy3GAcO4j1Ogb4Xx9XnV6CS+0+jvu+IAYhjgZtDq8dbNZa7SGcyl4TSpn1ChO zD3ymLY+4TMQDk9lJRoam/cdbFN7MYBzsMyW2TJGeXcE8X/bjZ/RMgAeU7j64919iY6c NJAHbfsVeyhq482PBdgAsFUIk/WDepd8YmJxDkAuX1VeRj04BpOzcrkwU04mO/Tol3SM BO/g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+Xny/9dxsbpogvH8OKBQOEtr91O6R9Hp8hj1G9BwXFc=; fh=S8scBxfs5nk5vnqxvNFkLwev3iJsCuGY57Dg4V9//2Y=; b=RXtqwndGyIG5ikwZfeH3lMi806z/DU4Nt/6BmqoY1WE2Ml3EE7kCRKPcgX8NawMH2Q Vq6C2dKVx5ywQL9/hSIwBWK29LkBKmGg3/9ZbQq2xyANlpp2GK5HR1vNvU71XG6cn7A8 3EfgkSgXaF5A9hJgcYJiQ4Wt5kDFKL5W4kojMCiKxIQ1bini+ds6bk8GiCuQfDz7zbCL XOPbtMsOIMDpsqdvCZSdPz+Yfuv8sJ4qNGPB1ZLS4xI2fxcUKLgutWLcgw2XGu8yPxb5 qCA8NB4J7tC1bZ/USoJmwK0W36p3Ncqaaz7JqWxNhd+imU325yx+68mZA6Tx9WHAsC4B kHjQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="XtLogM/b"; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-42792-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42792-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 6-20020a05620a04c600b00783fc833975si2557752qks.661.2024.01.29.06.45.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 06:45:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-42792-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="XtLogM/b"; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-42792-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42792-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4E6A81C24F8C for ; Mon, 29 Jan 2024 13:26:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 60B5F64CFC; Mon, 29 Jan 2024 13:26:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="XtLogM/b" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89FBC64CE3; Mon, 29 Jan 2024 13:26:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706534772; cv=none; b=LUg95OFvqAdhiMNS5OW6RNLhqjnn5xqvxNAY1ff8IZcDGhWYKWE+webB3A8Fmvj27yu0B93F/RxiN6/JNtvqZcIj4ZdvyHAHgsCeNbxPJh5kA0SOwV4ikuENJh65uwRkXTyvHkSXyudddkba6FJV1xicahu/EpbH1ttU2aQz4iY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706534772; c=relaxed/simple; bh=xwMcV3tNhSk+2xyVIcFgqQPYvtX3UtKlP6tjwF+wLxU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hqlqYwe8O1D3zKTrKKPeq9Bffh8dP3ivJ2+rzp7STaMLwUQBcVXPjA8EdF5WHUcgjkKXaFx6EWh8nzLGiPcKB42ATNXk+VCRG1RW7hjGwcnrJWEHNGs7Xc0/NJ2emRY4GG6m97qfSo9HUzauh16BOXYZbNd2Iyc7n2CXkZjYssU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=XtLogM/b; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+Xny/9dxsbpogvH8OKBQOEtr91O6R9Hp8hj1G9BwXFc=; b=XtLogM/bjdvsN4LPHEVaTg29du 0Unj6JuGv0EHxkbpUCdxQr8yIE3G+kAX/kJX+wiyiINxVZt1Lp6yByH7mj3xUmi1lsIJPbErTUwmt ENt4Qa0/KXxmZlQbiWoVkUcvX3KDU5VgfBTZTx6wkiPhB1dseNe4GwPAmkU2PFzAy5fwvJoYSW9ze FrjdfFENUWgA9HB218k9Q7AklwhGkZQGIrNRErGK8BCrjzt3nbPGoSpwXOGJ5CTR6Kh/3IeKZ27iR ry4JKdRnvVrQmXBH9x/tXavd2pvkj/91femN7KJwvCkZgitIuCjOSzHUrlWRYO0xRiGLifncssWg1 3Jxna3MQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUReI-00000006hqA-0T1r; Mon, 29 Jan 2024 13:26:06 +0000 Date: Mon, 29 Jan 2024 13:26:06 +0000 From: Matthew Wilcox To: Ming Lei Cc: Dave Chinner , Mike Snitzer , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Don Dutile , Raghavendra K T , Alexander Viro , Christian Brauner , linux-block@vger.kernel.org Subject: Re: [RFC PATCH] mm/readahead: readahead aggressively if read drops in willneed range Message-ID: References: <20240128142522.1524741-1-ming.lei@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jan 29, 2024 at 04:25:41PM +0800, Ming Lei wrote: > Here the single .ra_pages may not work, that is why this patch stores > the willneed range in maple tree, please see the following words from > the original RH report: > > " > Increasing read ahead is not an option as it has a mixed I/O workload of > random I/O and sequential I/O, so that a large read ahead is very counterproductive > to the random I/O and is unacceptable. > " It is really frustrating having to drag this important information out of you. Please send the full bug report (stripping identifying information if that's what the customer needs). We seem to be covering the same ground again in public that apparently you've already done in private. This is no way to work with upstream.