Received-SPF: pass (google.com: domain of linux-kernel+bounces-42951-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 29 Jan 2024 06:59:18 -0800
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andreas Larsson <andreas@gaisler.com>
Cc: Alan Stern <stern@rowland.harvard.edu>, linux-usb@vger.kernel.org,
	Rob Herring <robh@kernel.org>, linux-kernel@vger.kernel.org,
	software@gaisler.com
Subject: Re: [PATCH] usb: uhci-grlib: Explicitly include
 linux/platform_device.h
Message-ID: <2024012905-sulphuric-collie-7ede@gregkh>
References: <20240122082225.984523-1-andreas@gaisler.com>
 <2024012740-amaretto-unvarying-465a@gregkh>
 <b6b66bed-10f1-421a-a561-3e07dcbd6781@gaisler.com>
 <2024012943-print-wronged-e884@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2024012943-print-wronged-e884@gregkh>

On Mon, Jan 29, 2024 at 06:58:50AM -0800, Greg Kroah-Hartman wrote:
> On Mon, Jan 29, 2024 at 08:41:50AM +0100, Andreas Larsson wrote:
> > On 2024-01-28 01:31, Greg Kroah-Hartman wrote:
> > > On Mon, Jan 22, 2024 at 09:22:25AM +0100, Andreas Larsson wrote:
> > >> This fixes relying upon linux/of_platform.h to include
> > >> linux/platform_device.h, which it no longer does, thereby fixing
> > >> compilation problems like:
> > >>
> > >> In file included from drivers/usb/host/uhci-hcd.c:850:
> > >> drivers/usb/host/uhci-grlib.c: In function 'uhci_hcd_grlib_probe':
> > >> drivers/usb/host/uhci-grlib.c:92:29: error: invalid use of undefined type 'struct platform_device'
> > >>    92 |  struct device_node *dn = op->dev.of_node;
> > >>       |                             ^~
> > >>
> > >> Fixes: 0d18bcdebb2f ("of: Stop circularly including of_device.h and of_platform.h")
> > > 
> > > I don't see this commit id in Linus's tree, where is it?
> > 
> > Ah, sorry, it went into Linus's tree with a different commit ID. I
> > should have referred to ef175b29a242.
> 
> Please fix up and resend.

Ah you did, just hadn't read all of my email yet, sorry for the noise...