Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp442663rdb; Mon, 29 Jan 2024 07:06:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IHxRu8y9bCKy3TVErKE8pDcXjlXlTPKzKxvBF1nYHeGsgX2Ne6q6aAc31khegzrDlYRvvbB X-Received: by 2002:a05:622a:1e0a:b0:42a:5224:4ea3 with SMTP id br10-20020a05622a1e0a00b0042a52244ea3mr6334493qtb.57.1706540807564; Mon, 29 Jan 2024 07:06:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706540807; cv=pass; d=google.com; s=arc-20160816; b=QQCVXmHC7OH/vDtkiDVIiQ8V8pxNlvGDGEzYm3GbB+wa1aXkmshpE11GlNDnpjtCdg 9qqeWWuCh2mZf0h0CZ5TQsOScZhRlN+fj7rZmnwfzmsneJeKbfNNgFagBn1PzlIscXgL uE3AQvbh0Kf602oN1y6j8dN/e/sXnHohWb70ApzH2oBS3Js9Szio3BFCmX2tJn3xdfkX JMWMOuq4Gxxj5s6KYBsZhbTvQsipCdqo5m/is5ev4aYqMmxfbdDdCIPExyeIvyXgSqCn 3I86mmu+pdIgUeGdJE8h0kzX4HZxEWBZt81NpQVxR3XaCEn8TTvIhd7EjKLx50Q8a6IU aHAg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=SB7k/BFApJBDg3KYf+GK3Duye99o6PLwEtImHq4bcyM=; fh=/dc/nI52/9w/dBoP8YR9dPOp1c/n4We0Uyk0RS5sFS4=; b=yiGGGwyJvZCXZoHpy1P/dMoGBrRtQOZCoXEVR54enGFAoi8CqPaR5JErC4ACouy3nc egcG+UzX5BDBz1ynSodn5V4taGcI+R3XyBPmWzduipWWBl8nuPJ+k6UWYGknMN875kRn vXy3Z4gORlZ8Bjr4daSYA0vVz8164gzEA9XeX2ZMl44zQIISGowt68v7ynOmsOsRCPUh wpaXGseN6VwL4RYzHglv7LQEqTlKKfiad8y3TQLVnuvp777ce4doHlD5w0n0kh6KsLrZ tT13n7/vbcfN9ZmRlukR9PXpniQ4ONu5c52XZt5a1u2W/xpFl2gixY8I47PKHNzqoh+r YcmQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VdRdT15M; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-42960-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42960-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h9-20020a05622a170900b0042a8e0c1e14si5450339qtk.408.2024.01.29.07.06.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 07:06:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-42960-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VdRdT15M; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-42960-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42960-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 513751C21FF1 for ; Mon, 29 Jan 2024 15:06:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E56FB1534FC; Mon, 29 Jan 2024 15:06:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VdRdT15M" Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EF991534E6 for ; Mon, 29 Jan 2024 15:06:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706540801; cv=none; b=rUT8DYtWCmQsDJpMXyoUp//ofZLtPx6bFAoQvMrROu1tsaiywKEfsFd6s6AeTxrfC3Seyjb4HUS8QPfZw0cIqpCuZduktuRs2f0wHMrR50nTdbWUak9MuhUOO+s2QqtBacMJeY9417uLqb6a+zs5ckrBQRKbV3ZivchmiE9HCjc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706540801; c=relaxed/simple; bh=UdVE88RvKofu1niD7h9x7NM6QyJbb3bceyHPaqVCFyM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UBJIBKQ1kj7rnnq8ImIcG6UJC1pXjt7W9f3BrDVz3aFoioL4AsIjUQuMa2fOz0QBg1NT+zgOt3fCD7LmQ+XetiSF5wBecKsscLYbPXI6xU6Iyp+NUB8SvFxWBfZHm3zwo5NmSYWX4EJvP4WmyqXnIMIM9/HOPMwsQGqGUswFsKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VdRdT15M; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-33ae3be1c37so957283f8f.0 for ; Mon, 29 Jan 2024 07:06:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706540797; x=1707145597; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SB7k/BFApJBDg3KYf+GK3Duye99o6PLwEtImHq4bcyM=; b=VdRdT15MKtBIYKo1FVDLVuBJOyolpgnhYmkvL+t+E380Q7RVpZ2Ht+Ab249wG3NQpe uoX2HB5715VR2K6zWuPUWlIGodBsPjBU7yP/9z5O/krCnjGfOdKlYPtMpWVQWssFIDDA 916K48BGaMT4lDsiFhGZUwR6px2Fgi8O5UwzN8n4DjjOdQeOHr27Bk1APMv78a5ovSjs mr7CbqjvT7/mCQehPrhEHRsGhJupHyt/YkpmJnDHke+VJdz9Yv/Kg42R3s1k33kBzx3i YkV1vJUC2uDVAeHn0e0CElgn8Qv6jICrOPKKnIoiqHKpKW7TdWOgTuztNMrEj2kz60pF 8MSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706540797; x=1707145597; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SB7k/BFApJBDg3KYf+GK3Duye99o6PLwEtImHq4bcyM=; b=S1mW9vZgZrpi3J+WP8xCn1q6z1gTnJwrqR06HS7Evy8Iesd33q29ehi6LRMjY4E7QO BLrVYYV5Nk39nLOySYYd9FIVKPJY+fdSAVy7fMjIRTgGWdaiTTs5eywVqJ5ius2YQryK X7Z/1WwxOPdho765N/2DFVcNw//syJYN/UV3tqe1+yIBHYHNaFqtaWg2B/UiGG18tpdE /pgaxkNmU42UDjFq1jSDg+jPxQDghfrYnFxyVtNt5MUqjX2jCNpXpPE/wWGDluvmr7pu gdGo7H8SyyZ7WFXa4Pj+xsFG0NFcXSN4UCLRu1NygzHAOvdvbOx8u1WtD7Sf9+lqZt3B qMXQ== X-Gm-Message-State: AOJu0YzapyVNeIjY178sasjyuPPLS33QckZVbkeyQo9XJTM5mQ6x+eOk ftyw/Y7MWrxkqBZHuZvZorwu9LxKvOrVwJ4ZZwcKL6Emx2vaPKQFyalhZvVH7KQ= X-Received: by 2002:adf:ce0d:0:b0:33a:e559:5357 with SMTP id p13-20020adfce0d000000b0033ae5595357mr4148708wrn.28.1706540797491; Mon, 29 Jan 2024 07:06:37 -0800 (PST) Received: from localhost ([102.140.209.237]) by smtp.gmail.com with ESMTPSA id k7-20020a5d6e87000000b0033addeabd6fsm7642647wrz.18.2024.01.29.07.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 07:06:37 -0800 (PST) Date: Mon, 29 Jan 2024 18:06:34 +0300 From: Dan Carpenter To: Meir Elisha Cc: Greg Kroah-Hartman , Hans de Goede , Ruan Jinjie , Yang Yingliang , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] Staging: rtl8723bs: Fix block comments warning Message-ID: <888364a5-0445-467b-9e3c-6662019852e4@moroto.mountain> References: <20240129141856.416532-1-meir6264@Gmail.com> <20240129141856.416532-4-meir6264@Gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240129141856.416532-4-meir6264@Gmail.com> On Mon, Jan 29, 2024 at 04:18:55PM +0200, Meir Elisha wrote: > /* > -struct wlan_network *_rtw_dequeue_network(struct __queue *queue) > -{ > - _irqL irqL; > - > - struct wlan_network *pnetwork; > - > - spin_lock_bh(&queue->lock); > - > - if (list_empty(&queue->queue)) > - > - pnetwork = NULL; > - > - else > - { > - pnetwork = container_of(get_next(&queue->queue), struct wlan_network, list); > - > - list_del_init(&(pnetwork->list)); > - } > - > - spin_unlock_bh(&queue->lock); > - > - return pnetwork; > -} > -*/ > + *struct wlan_network *_rtw_dequeue_network(struct __queue *queue) > + *{ > + * _irqL irqL; > + * > + * struct wlan_network *pnetwork; > + * > + * spin_lock_bh(&queue->lock); > + * > + * if (list_empty(&queue->queue)) > + * > + * pnetwork = NULL; > + * > + * else > + * { > + * pnetwork = container_of(get_next(&queue->queue), struct wlan_network, list); > + * > + * list_del_init(&(pnetwork->list)); > + * } > + * > + * spin_unlock_bh(&queue->lock); > + * > + * return pnetwork; > + *} > + */ Delete the dead code. regards, dan carpenter