Received-SPF: pass (google.com: domain of linux-kernel+bounces-42985-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 29 Jan 2024 10:19:24 -0500
From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Conor Dooley <conor@kernel.org>, thinh.nguyen@synopsys.com,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, balbi@kernel.org, devicetree@vger.kernel.org,
	gregkh@linuxfoundation.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	mark.rutland@arm.com, mathias.nyman@intel.com, pku.leo@gmail.com,
	sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH 1/2] dt-bindings: usb: dwc3: Add system bus request info
Message-ID: <ZbfB/KT+fzO/F2e5@lizhi-Precision-Tower-5810>
References: <20240123170206.3702413-1-Frank.Li@nxp.com>
 <20240123-poking-geography-33be2b5ae578@spud>
 <Za/8J8MDJaZEPEKO@lizhi-Precision-Tower-5810>
 <20240123-anew-lilly-0d645bdbfb30@spud>
 <Za//LX9U6QG5A5NW@lizhi-Precision-Tower-5810>
 <20240123-nanometer-atlantic-6465b270043a@spud>
 <ZbAR/NQvjUnf2At+@lizhi-Precision-Tower-5810>
 <46781012-2678-4f6c-9aee-b020cabcbb28@linaro.org>
 <ZbA8ea9Ex+hMdDDZ@lizhi-Precision-Tower-5810>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZbA8ea9Ex+hMdDDZ@lizhi-Precision-Tower-5810>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?GGrgZUdWrc2Y4saG64mheCwHWWv/wueQBM7kNkw2TAS3chJHi6uE9czFzH+k?=
 =?us-ascii?Q?bsXgIeAfaUsEZxiktaFhKc1fhf5T9/xyp8hrV0tUweTv/N8dIL9gsgH4PQ45?=
 =?us-ascii?Q?YfN3ZN19IL37SKuuTrwdTSBFWyTOAzreoaG6Qh/mAqA/UnXwNkOzBzBPklZA?=
 =?us-ascii?Q?eK51+6E8qZCmXukjLPi9XV5qiopUd7bJGjHLVaItO7zUXSUxdeUz4NNmyxDU?=
 =?us-ascii?Q?yCfI13M7bmRU0nxjsRFum7Hn8zCIfFXOWYCjuzkK4i3IEHZ6DJXiiTLJY+sW?=
 =?us-ascii?Q?SUxxnYpAittvABKYMbSRnI4E6xhYOzicbKEKiZ4k+a3PPBhLC0PBx0uhQnY9?=
 =?us-ascii?Q?I2Bwv+Ixw9hltDYDzEK5uC3eKGAOJhuKUTtI489TTwHYg4+jcessHVC43jYs?=
 =?us-ascii?Q?hwvmeCqIpwupeBeHOU489xVLD2r3/JyYsbYebx3GL2WUIKBegTCFbY9E08Hd?=
 =?us-ascii?Q?oNa1oHm6Fexun4SpoBSF3eLzKhc+rXf11+uPZLMRQtMh6xPi5jbcZk0uaqgz?=
 =?us-ascii?Q?/0g8XuVZaHyUE5MPiGXbJM+2ycZTNLjievK3/DBRX4qMcBQ4U3nWEoReXrX9?=
 =?us-ascii?Q?6Tlcoc5SjyGCH+OQUTXrpvbgUZf18dubpM2+rgLzXqsVZQl0obx1lzjvYBUA?=
 =?us-ascii?Q?D5/uZXngWOWvij4KOPrfQnFk7sZvrEN/tGon9uIZ0IZSDz7yiR3MvglAQ7UD?=
 =?us-ascii?Q?WL19fT9J0YuDao3GckxY+/Lfpsq6pIf9vohqx2TEyjjv2a8R2ozNlSprONWn?=
 =?us-ascii?Q?/YHYy5d/lp977kEBH3oEipW3774D4jeWuubU19RC6DTPDChlLhw6tpgVsIpj?=
 =?us-ascii?Q?Rlm236cQ9+5mSi1N4X8BEvxKOTRjr3hRlYxEoTinatKfDrhYTZTH2hUNGmWF?=
 =?us-ascii?Q?k09qhtUWNMuvHjXBGaR5149Zp8RdYa1WbhOnKMuyHXNqOMnygi/0s0SQGi6o?=
 =?us-ascii?Q?IPzeSdRBb1NIozRH1LsUDeqESXa+Vb2+W9rSF8R/jr7/xKd96Z4fSYTs94KI?=
 =?us-ascii?Q?YtIe6wgXCZXkmnmY/MN9MPIV+nIJ+s7DrlyO5c5PQMZM/zSgv2gBpeyvolll?=
 =?us-ascii?Q?zKOdptWL/cSJDOYQCU46rcFHxODmhiK4M14NZ0PkpTQYHhEvDyqspikfctYJ?=
 =?us-ascii?Q?hjZE3Mzw7S7aarO69vCv2b/RZLNLMQ444fTcawG8CctAgUSiYdNgGnRpduJQ?=
 =?us-ascii?Q?K0Pi0t6d2WkkM3Lcf3WTdHsb4esz8DPACiiTrYJvjv7hjfjCPr+qgxKgv5XI?=
 =?us-ascii?Q?lonwOvyvh3M0RN7DIgeGE0Q7S2RuhN2mCL/7/NdicFdNqXIUfXgiZURsYZvS?=
 =?us-ascii?Q?t1PJ2WBcIhEC/uh2rs3frLAKyFYYXtwxGyr+PT2hiA6bmDQzeBRl9N6LdBYH?=
 =?us-ascii?Q?PdD9Lm0A7sFqRP8rOprpKypX1ukaxQ0h1TPJALQbOziVlGhJ0eetrEW8RK1e?=
 =?us-ascii?Q?WWy/JY9XzURwutv3658GxT60uvsCK6PBmLHka5jS0im+/SQI5xv5UNbBZY84?=
 =?us-ascii?Q?SBotIhuhHCKvH3LKBxcHdwYr0KNQbGqjAQcXECFplwVLPdSyJBKVDBAAZxZO?=
 =?us-ascii?Q?Q0wRmiAa7u89PB2HGtY=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aabc90f4-e57f-42e4-296b-08dc20ddb217
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 15:19:33.0027
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IUxxEMeUkIQ3KiGH0s8gxJBV2rkLpe6OAmqP3EL/dlJMxVqxwNzIV55U9rhZJQHUomEynrSNakpI/xQZtjwJyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9966

On Tue, Jan 23, 2024 at 05:23:53PM -0500, Frank Li wrote:
> On Tue, Jan 23, 2024 at 10:46:39PM +0100, Krzysztof Kozlowski wrote:
> > On 23/01/2024 20:22, Frank Li wrote:
> > > On Tue, Jan 23, 2024 at 06:42:27PM +0000, Conor Dooley wrote:
> > >> On Tue, Jan 23, 2024 at 01:02:21PM -0500, Frank Li wrote:
> > >>> On Tue, Jan 23, 2024 at 05:51:48PM +0000, Conor Dooley wrote:
> > >>>> On Tue, Jan 23, 2024 at 12:49:27PM -0500, Frank Li wrote:
> > >>>>> On Tue, Jan 23, 2024 at 05:27:13PM +0000, Conor Dooley wrote:
> > >>>>>> On Tue, Jan 23, 2024 at 12:02:05PM -0500, Frank Li wrote:
> > >>>>>>> Add device tree binding allow platform overwrite default value of *REQIN in
> > >>>>>>> GSBUSCFG0.
> > >>>>>>
> > >>>>>> Why might a platform actually want to do this? Why does this need to be
> > >>>>>> set at the board level and being aware of which SoC is in use is not
> > >>>>>> sufficient for the driver to set the correct values?
> > >>>>>
> > >>>>> In snps,dwc3.yaml, there are already similary proptery, such as
> > >>>>> snps,incr-burst-type-adjustment. Use this method can keep whole dwc3 usb
> > >>>>> driver keep consistent. And not all platform try enable hardware
> > >>>>> dma_cohenrence. It is configable for difference platform.
> > >>>>
> > >>>> When you say "platform", what do you mean? I understand that term to
> > >>>> mean a combination of board, soc and firmware.
> > >>>
> > >>> In my company's environment, "platform" is "board". I will use "board" in
> > >>> future. Is it big difference here?
> > >>
> > >> Nah, that's close enough that it makes no difference here.
> > >>
> > >> I'd still like an explanation for why a platform would need to actually
> > >> set these properties though, and why information about coherency cannot
> > >> be determined from whether or not the boss the usb controller is on is
> > >> communicated to be dma coherent via the existing devicetree properties
> > >> for that purpose.
> > > 
> > > Actually, I am not very clear about reason. I guest maybe treat off power
> > > consumption and performance.
> > > 
> > > What's your judgement about proptery, which should be in dts. Such as
> > > reg, clk, reset, dma and irq, which is tighted with SOC. It is the fixed
> > > value for every SOC. The board dts never change these.
> > 
> > Then it can be deduced from the compatible and there is no need for new
> > properties.
> 
> Okay, I think "*reqinfo" match this. When new Soc(using compatible dwc usb
> controller) appear regardless dma-cohorence or not, connect by AXI3 or
> AXI4, needn't add new propterties. 

Anyone have objection? I will prepare v2 to fix rob's bot error.

Frank

> 
> Frank
> 
> > 
> > Best regards,
> > Krzysztof
> >