Date: Tue, 18 Dec 2007 14:32:21 +0100
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: steve birtles <arm_kernel_development@micromark.net.cn>
Cc: "Remy Bohmer" <linux@bohmer.net>, linux-kernel@vger.kernel.org,
       Russell King - ARM Linux <linux@arm.linux.org.uk>,
       Andrew Victor <linux@maxim.org.za>,
       ARM Linux Mailing List 
	<linux-arm-kernel@lists.arm.linux.org.uk>
Subject: Re: [PATCH v2] atmel_serial: Clean up the code
Message-ID: <20071218143221.790c3571@dhcp-252-066.norway.atmel.com>
In-Reply-To: <25FA62D8-BCBE-4A0E-A98D-F883FB65AFBE@micromark.net.cn>
References: <1197971591-23890-1-git-send-email-hskinnemoen@atmel.com>
	<3efb10970712180214g374749cbh940958e1eff7185c@mail.gmail.com>
	<20071218113337.061a8e59@dhcp-252-066.norway.atmel.com>
	<25FA62D8-BCBE-4A0E-A98D-F883FB65AFBE@micromark.net.cn>
Organization: Atmel Norway
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1521
Lines: 38

On Tue, 18 Dec 2007 21:22:01 +0800
steve birtles <arm_kernel_development@micromark.net.cn> wrote:

> Is there any change can we clean this up?
>   /*
>    * We wrap our port structure around the generic uart_port.
> @@ -142,8 +146,8 @@ static void atmel_set_mctrl(struct uart_port  
> *port, u_int mctrl)
>   #ifdef CONFIG_ARCH_AT91RM9200
>   	if (cpu_is_at91rm9200()) {
>   		/*
> -		 * AT91RM9200 Errata #39: RTS0 is not internally connected to PA21.
> -		 *  We need to drive the pin manually.
> +		 * AT91RM9200 Errata #39: RTS0 is not internally connected
> +		 * to PA21. We need to drive the pin manually.
>   		 */
>   		if (port->mapbase == AT91RM9200_BASE_US0) {
>   			if (mctrl & TIOCM_RTS)
> @@ -228,7 +232,8 @@ static void atmel_stop_rx(struct uart_port *port)
>    */

I'm not sure what you mean. It just breaks the comment to fit within 80
columns...

> and potentially add those flags for  dealing with the  CTS & RTS   ,  
> that may not be used on every board,  because this clean up sit's in  
> my minor changes for the YL9200, specifically to  re-jig the USARTS  
> lines so that we can separate  RXD TXD , from a forced requirment to  
> use  control lines when using  232

Could you just post your changes so that we can see where it fits in?

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/