Received-SPF: pass (google.com: domain of linux-kernel+bounces-43047-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240125170628.2017784-1-tj@kernel.org> <20240125170628.2017784-10-tj@kernel.org>
In-Reply-To: <20240125170628.2017784-10-tj@kernel.org>
From: Lai Jiangshan <jiangshanlai@gmail.com>
Date: Tue, 30 Jan 2024 00:00:22 +0800
Message-ID: <CAJhGHyAuoGNmaaDa0p+wiJMprXYVYnVV75PS4+kPy-fsPJVH8w@mail.gmail.com>
Subject: Re: [PATCH 09/10] workqueue: Implement system-wide nr_active
 enforcement for unbound workqueues
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, Naohiro.Aota@wdc.com, kernel-team@meta.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello, Tejun

On Fri, Jan 26, 2024 at 1:06=E2=80=AFAM Tejun Heo <tj@kernel.org> wrote:

> @@ -5121,6 +5374,9 @@ void workqueue_set_max_active(struct workqueue_stru=
ct *wq, int max_active)
>
>         wq->flags &=3D ~__WQ_ORDERED;
>         wq->saved_max_active =3D max_active;
> +       if (wq->flags & WQ_UNBOUND)
> +               wq->saved_min_active =3D min(wq->saved_min_active, max_ac=
tive);
> +

wq_update_node_max_active() must be also called here.

Thanks
Lai

>         wq_adjust_max_active(wq);
>
>         mutex_unlock(&wq->mutex);